Commit Graph

2527 Commits

Author SHA1 Message Date
Lajos Veres
c34602007c chore(animate): fix typo in a comment 2014-02-27 01:44:25 -08:00
Lajos Veres
8ae296823b docs($sce): fix typo 2014-02-27 01:43:26 -08:00
Lajos Veres
2586e3a2ac docs($compile): fix typo 2014-02-27 01:42:30 -08:00
desertapple
214c65d334 docs($injector): fix typo
Duplicate 'that' words present in the document, just remove one of them.

Closes #6469
2014-02-26 17:14:08 -08:00
Matias Niemelä
f4f1f43d51 fix($animate): ensure all comment nodes are removed during a leave animation
Closes #6403
2014-02-26 17:17:41 -05:00
Matias Niemelä
e71e7b6cae fix($animate): only block keyframes if a stagger is set to occur
Transitions must be blocked so that the initial CSS class can be applied
without triggering an animation. Keyframes do not need to be blocked since
animations are always triggered on the starting CSS class, however, if a
stagger animation is set to occur then all elements for index > 0 should
be blocked. This is to prevent the animation from occuring early on before
the stagger delay for the given element has passed.

With ngAnimate and keyframe animations, IE10 and Safari will render a slight
flicker effect caused by the blocking. This fix resolves this issue.

Closes #4225
2014-02-26 17:08:51 -05:00
Stanislav Sysoev
c914cd99b3 fix(ngAnimate): TypeError Cannot call method 'querySelectorAll' in cancelChildAnimations
When an element containing both ng-repeat and ng-if directives attempts to remove any items from
the repeat collection, the following error is thrown: "TypeError Cannot call method 'querySelectorAll'
of undefined".  This happens because the cancelChildAnimations code naively belives that the jqLite
object always has an element node within it. The fix in this commit addresses to securely check to see
if a node was properly extracted before any child elements are inspected.

Closes #6205
2014-02-26 15:39:54 -05:00
Matias Niemelä
e9881991ca fix($animate): ensure that animateable directives cancel expired leave animations
If enter -> leave -> enter -> leave occurs then the first leave animation will
animate alongside the second. This causes the very first DOM node (the view in ngView
for example) to animate at the same time as the most recent DOM node which ends
up being an undesired effect. This fix takes care of this issue.

Closes #5886
2014-02-26 14:53:57 -05:00
Matias Niemelä
99720fb5ab fix($animate): ensure all animated elements are taken care of during the closing timeout
Closes #6395
2014-02-26 14:23:47 -05:00
Peter Bacon Darwin
332e935048 docs(*): fix jsdoc type expressions
These errors in the docs were preventing some parts of the docs from being
parsed.
2014-02-26 11:47:22 +00:00
Igor Minar
3d6dff44f3 revert: fix($location): parse query string when path is empty in hashbang mode
This reverts commit cad717b117.

This change causes regressions in existing code and after closer inspection
I realized that it is trying to fix an issue that is should not be considered
a valid issue.

The location service was designed to work against either "hash" part of the
window.location when in the hashbang mode or full url when in the html5 mode.

This change tries to merge the two modes partially, which is not right. One
reason for this is that the search part of window.location can't be modified
while in the hashbang mode (a browser limitation), so with this change part
of the search object should be immutable and read-only which will only cause
more confusion.

Relates to #5964
2014-02-25 22:59:31 -08:00
Michał Gołębiowski
6b049c74cc feat($parse): support trailing commas in object & array literals
Per ECMAScript 5.1 specification trailing commas are allowed in object and
array literals. All modern browsers as well as IE>8 support this syntax.
This commit adds support for such syntax to Angular expressions.
2014-02-26 00:38:37 +01:00
Matias Niemelä
4c4537e65e perf($animate): use rAF instead of timeouts to issue animation callbacks 2014-02-24 21:23:18 -05:00
Matias Niemelä
62761428ef chore(core): create a wrapper to manage async callbacks 2014-02-24 21:23:10 -05:00
Matias Niemelä
04d7317cdd chore(core): introduce a wrapper for requestAnimationFrame 2014-02-24 21:23:05 -05:00
Diego Muñoz Escalante
2cd87dbb93 docs($interpolate) fix sample code appearing unformatted
Closes #6418
2014-02-24 18:48:01 +00:00
Alessandro Bahgat
24fe1632b0 docs($routeProvider): correct "slashs" to "slashes"
Closes #6415
2014-02-23 17:49:54 +01:00
Alessandro Bahgat
61b2515c0d docs(ngPluralize): corrected "bounded to" to "bound to"
Closes #6408
2014-02-22 15:29:14 -05:00
Peter Bacon Darwin
f296e2ee12 docs($animate): change @param to use valid types
`{jQuery/jqLite element}` is not a valid jsdoc type and breaks when being
parsed causing the documentation to look wrong.  This commit changes all
such param tags to use `DOMElement` instead, which is what is used for
similar params in `$compile` and `angular.element`.
2014-02-22 13:07:19 +00:00
Sekib Omazic
a4078fcae4 perf($cacheFactory): skip LRU bookkeeping for caches with unbound capacity
Fixes #6193
Closes #6226
2014-02-21 22:29:46 -08:00
Caitlin Potter
cad717b117 fix($location): parse query string when path is empty in hashbang mode
Before this fix, search queries in hashbang mode were ignored if the hash was not present in the
url. This patch corrects this by ensuring that the search query is available to be parsed by
urlResolve when the hashbang is not present.

Closes #5964
2014-02-21 18:31:13 -05:00
Caitlin Potter
c2d447e378 fix(input): use ValidityState to determine validity
In browsers where HTML5 constraint validation is (partially) implemented, an invalid number
entered into an input[type=number] (for example) input element would be visible to the
script context as the empty string. When the required or ngRequired attributes are not used,
this results in the invalid state of the input being ignored and considered valid.

To address this, a validator which considers the state of the HTML5 ValidityState object is
used when available.

Closes #4293
Closes #2144
Closes #4857
Closes #5120
Closes #4945
Closes #5500
Closes #5944
2014-02-21 18:03:24 -05:00
Caitlin Potter
75515852ea fix(isElement): reduce false-positives in isElement tests
Complimentary change to match changed $parse behaviour.
2014-02-21 17:59:01 -05:00
Caitlin Potter
5fe1f39f02 fix($parse): reduce false-positives in isElement tests
There are always going to be false positives here, unfortunately. But
testing different properties will hopefully reduce the number of false
positives in a meaningful way, without harming performance too much.

Closes #4805
Closes #5675
2014-02-21 17:58:48 -05:00
Caitlin Potter
2bce71e9dc feat(ngHref): bind ng-href to xlink:href for SVGAElement
This change makes the ngHref directive useful for SVGAElements by having it bind
to the xlink:href attribute rather than the href attribute.

Closes #5904
2014-02-21 17:56:48 -05:00
Boris Serdyuk
c8e03e34b2 fix($http): do not add trailing question
Closes #6342
2014-02-21 14:51:10 -08:00
Pawel Kozlowski
267b217376 fix($http): send GET requests by default
Fixes #5985
Closes #6401
2014-02-21 14:42:03 -08:00
Peter Bacon Darwin
4a6a3ba7fb docs(*): fix anchors for members in api docs 2014-02-21 19:37:37 +00:00
Sadaoui Abderrahim
7cd79b6f8f docs(ngMock.$interval): fix return description
Closes #6384
2014-02-21 13:48:01 +00:00
James Roome
2a37690f70 docs(ngSubmit): reference correct object ($scope) in example.
Switched from this to $scope. It's confusing using $scope and this interchangeably.

Closes #6375
2014-02-20 17:12:52 -05:00
cnlevy
3193a3a5af docs(core): add note that isObject returns true for arrays
Closes #6353
2014-02-20 14:52:25 -05:00
Sadaoui Abderrahim
6082e2ad16 docs(ngMock): document method ngMock.$interval#cancel()
I have been looking around and was not able to find any informations on how to clear the $interval
but reading the source code, sharing is caring!

Closes #6367
2014-02-20 10:43:05 -05:00
Peter Bacon Darwin
cc1f7539d4 docs(modules): remove unused {@installModule} tags 2014-02-19 21:22:27 +00:00
Steven Petryk
696928dbc6 docs($routeProvider): fix indentation
Closes #6345

Somebody accidentally padded a list with one-too-many indentations, which caused the actual documentation page to render incorrectly. This should fix it.
2014-02-19 08:03:20 -08:00
Caitlin Potter
05fbed5710 fix(jqLite): make jqLite('<iframe src="someurl">').contents() return iframe document, as in jQuery
This is a very tiny change to make behaviour consistent with jQuery.

Closes #6320
Closes #6323
2014-02-18 18:43:59 -05:00
Brad Williams
21dac2a3da docs(ngClass): Explain all 3 ways how to use ngClass
Closes #6324.
2014-02-18 15:08:30 -08:00
Igor Minar
481508d0e7 style: remove ws and enfore no-trailing-ws jscs rule 2014-02-18 10:44:48 -08:00
Caitlin Potter
12e4d3ac4d docs($q): fixup dgeni ngdoc annotations for $q methods
Just a tiny fixup, that's all.

Closes #6317
2014-02-18 12:25:08 -05:00
Paul Dijou
774b2adb89 docs($interpolate): correct small typo 2014-02-18 06:26:24 +00:00
Stéphane Reynaud
e23a6a320e docs(bike-shed-migration): convert doctype and names
To keep the same logic as the commit 2e641ac49f
2014-02-17 14:05:51 +00:00
Matias Niemelä
1de7411c8b chore(ngPluralize): remove useless docs heading 2014-02-16 20:04:22 -05:00
Peter Bacon Darwin
896e34689d docs(NgModelController): don't run contenteditable example on FF 2014-02-16 19:03:45 +00:00
Peter Bacon Darwin
ecdb9a5688 docs(*): fix jshint issues in examples 2014-02-16 19:03:45 +00:00
Julie
c663b39826 chore(e2etests): fix a browser check which was actually assigning the parameter 2014-02-16 19:03:44 +00:00
Peter Bacon Darwin
2123772a65 docs(api): escape params that have <object> in their type
Really the doc-gen process should escape there but for now this should
stop the layout from breaking.
2014-02-16 19:03:44 +00:00
Peter Bacon Darwin
cb1efd818b docs($locationProvider): tag as a provider rather than object 2014-02-16 19:03:44 +00:00
Peter Bacon Darwin
d85505d019 docs(content): fix bad links 2014-02-16 19:03:43 +00:00
Peter Bacon Darwin
7c7477ce45 docs(ngHref): fix example that navigates away from the page 2014-02-16 19:03:43 +00:00
Peter Bacon Darwin
6f0503514f docs(ngRoute): ask for examples to have their base[href] fixed 2014-02-16 19:03:43 +00:00
Peter Bacon Darwin
5c6f9f8e81 docs(ngHref): don't run the breaking protractor test 2014-02-16 19:03:43 +00:00