kylefang/angular.js
1
0
Fork 0
mirror of https://github.com/zhigang1992/angular.js.git synced 2026-04-08 09:07:46 +08:00
Code Issues Packages Projects Releases Wiki Activity
4,770 Commits 18 Branches 121 Tags
093e76fa15f7475cd3f0e6be9cfe60ca2da608c4
Commit Graph

4770 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Julie
093e76fa15 tests(docsAppE2E): fix race condition flake with switching to new frame 
Closes #7569
 2014-05-23 11:29:17 -07:00
Juan Manuel Palacios
28c0497524 docs(tutorial): match html from angular-phonecat in step 7 instructions 
Place phoneId binding in a proper HTML node

The code where the phoneId binding in the phone-detail.html template is first explained in step 7
of the tutorial doesn't make it a child of a proper HTML node, which makes the end-to-end test
against the view (also introduced in step 7) fail.

The test acquires the binding right from the view (by.binding('phoneId')), and apparently this
operation fails when the binding is not a child of an HTML node, and therefore the entire test also
fails. As soon as the binding is placed inside a <span></span> tag pair, the binding is found and
the test passes. The code on github for step 7 has it right, the binding is within the span tags,
but in the documentation I'm patching here the span's are missing.

☆.。.：*・゜☆ MERCI ☆.。.：*・゜☆
 2014-05-23 01:33:07 -04:00
rodyhaddad
88505d8029 refactor($parse): remove the support of JSON parsing mode 
It's a feature that isn't exposed to the public, and is
no longer used internally.
 2014-05-22 15:22:33 -07:00
Zorigt Bazarragchaa
c241a57761 docs(tutorial/index): explain E2E acronym 
It was confusing to read "end 2 end" as a numeric two. I kept wondering what two end(s).
Later in the tutorial, the text switched to "End to End" which made more sense than numeric two.
 2014-05-22 13:21:16 -07:00
Jesse Palmer
b0e985fb67 style: added whitespace 
spaces between the ')' and '{' make code a tad easier to read.

Closes #7542
 2014-05-22 08:50:59 -07:00
Kevin Aenmey
a0dbd95bb9 docs($cacheFactory): fix typo 2014-05-21 16:30:07 -07:00
Tobias Bosch
9fd5450ee8 docs($compile): deprecate replace directives 
BREAKING CHANGE:

The `replace` flag for defining directives that
replace the element that they are on will be removed in the next
major angular version.
This feature has difficult semantics (e.g. how attributes are merged)
and leads to more problems compared to what it solves.
Also, with WebComponents it is normal to have custom elements in the DOM.
 2014-05-21 16:11:00 -07:00
Max Tobias Weber
b5391fae8f docs(tutorial): update code snippet for step 7 
replaced bootstrap 2 with bootstrap 3 classes

Closes #7433
 2014-05-21 15:54:41 -07:00
Jeff Whelpley
b635903ec4 fix($compile): do not merge attrs that are the same for replace directives 
If a directives specifies `replace:true` and the template of the directive contains
a root element with an attribute which already exists at the place
where the directive is used with the same value, don't duplicate the value.

Closes #7463
 2014-05-21 15:51:48 -07:00
Jesse Palmer
c9ee20b64b docs($interpolate): removed function name to match other examples 2014-05-21 15:50:06 -07:00
Freek Wielstra
25ae98ca77 docs($http): clear up Interceptor docs and code 
The documentation and code example of $http interceptors is unclear about whether config can be null
or not, and whether the result should always be a promise or not. This pr clears up the documentation
a bit and removes the literal 'or a promise' interpretation of the docs in the code example.

Closes #7431
Closes #7460
 2014-05-21 15:36:14 -07:00
NateRedding
adb5ee2e0a docs(ngHide): corrected logic in example 
Closes #7436
 2014-05-21 15:27:01 -07:00
Brice
78954ffcde docs(tutorial): improve instructions for causing test failure (step 2) 
Increase readability for test fail line

Closes #6943
 2014-05-21 17:32:31 -04:00
specialorange
3b30a4b64a docs(error/$injector/unpr): clarify which code is being referred to in the text 
Closes #7020
 2014-05-21 22:27:44 +01:00
Edward Brey
866057233c docs(filter): description formatting fix 
as it was, the third parameter's description was displayed as
a code block, rather than a bulletted list.
 2014-05-21 13:58:22 -07:00
Richard Littauer
ec1f4a8c9b test(ngClass): add missing assertions 2014-05-21 13:58:11 -07:00
Tim van den Eijnden
c94190139d docs(tutorial): fix controller unit tests to match phonecat / avoid ReferenceError 
fix 'ReferenceError: PhoneDetailCtrl is not defined' & 'ReferenceError: PhoneListCtrl is not defined' in Karma unit tests

Closes #7421
 2014-05-21 16:38:40 -04:00
Adam Bradley
4896a0b4d4 docs(css): remove Firefox select element drop-down icon 
In firefox the version picker's dropdown icon from the default `select` element
is still showing. This CSS forces FF to hide the ugly default.

Closes #6878
 2014-05-21 21:34:27 +01:00
kalvn
32bd990eda docs(tutorial): corrected version of jquery installed via bower (step 12) 
Corrected the version of jquery in the text content.
 2014-05-21 16:31:30 -04:00
James Vanneman
23723298f9 docs($filter): add runnable example 
Closes #6871
 2014-05-21 21:26:38 +01:00
ABitTooCalm
edab80cddb docs(ngStyle): clarify using styles that are not valid property names 
Closes #6838
 2014-05-21 21:07:54 +01:00
Andrew Mortimer
f4bb006e45 docs(guide/controller): fix typo 2014-05-21 12:32:57 -07:00
Kristof Mattei
cf3f709889 docs(shallowCopy): fixed typo 
Closes #7456
 2014-05-21 11:43:02 -07:00
Tobias Bosch
e9ecd56dca docs(ngModelController): use $sce and $sanitize in the contenteditable example. 
Closes #7464
 2014-05-21 11:39:35 -07:00
Tobias Bosch
f107ef8bd8 docs(): mention implicit usage of 2014-05-21 11:39:25 -07:00
markau
e7eab501db docs(guide/concepts): The service is finance2.js 
Closes #7470
 2014-05-21 10:58:29 -07:00
Tobias Bosch
97fc47f39e docs(guide/concepts): clarify definitions 2014-05-21 10:58:17 -07:00
Sergei Z
6d1c67727a feat(ngMock): add support of mocha tdd interface 
Closes #7489
 2014-05-21 10:56:21 -07:00
Erich
8ba78f08b9 docs(guide/concepts): clarify definitions 
Closes #7483
 2014-05-21 10:56:12 -07:00
Sam Dornan
02a3c31c23 docs(guide/services): fix link to minify Wikipedia page 
Closes #7488
 2014-05-21 10:55:55 -07:00
Yaron Uliel
d4c3d5caaf docs(ngRepeat): fix formatting 2014-05-21 10:28:47 -07:00
Takashi Nakagawa
279f98c4e3 docs(ngModelController): fix indentation code block 
Closes #6660
 2014-05-21 17:09:13 +01:00
Caitlin Potter
5e548edf67 docs(guide/$location): clarify "$watchers" / "$observers" terminology with links 
Add links to API docs for Scope#$watch and Attributes#$observe in $location in order to clarify
the meaning of that terminology.

Closes #7497
 2014-05-21 12:00:16 -04:00
Firexion
acaf9be685 docs(tutorial): add <span> to index.html to match phonecat step4 
Add missing <span> to app/index.html to match actual code on github

☆.。.：*・゜☆ Merci beaucoup! ☆.。.：*・゜☆
 2014-05-21 11:29:30 -04:00
GSC Leticia
bdd75c97ad docs(tutorial): add instructions for running node in Debian-based distributions 
Specifying command for Debian based distributions, like Ubuntu, Mint, etc.

☆.。.：*・゜☆ Fantastique! ☆.。.：*・゜☆
 2014-05-21 11:22:47 -04:00
Peter Bacon Darwin
a3f1cba8ec docs(guide/expression): mention the ternary operator 
Closes #6498
 2014-05-21 14:47:46 +01:00
Peter Bacon Darwin
4195b04072 docs($compile): remove reference to ngRepeat providing compile function 
ngRepeat no longer has the compile function in its directive definition
object, since it retrieves its transclusion via the link function.

Closes 5638
 2014-05-21 14:31:41 +01:00
Peter Bacon Darwin
ccc8ec869b docs(tutorial/step-5): update image to match code 
Closes #2753
 2014-05-21 13:58:48 +01:00
Eli Dalbey
6d8abaedd8 docs(guide/concepts-module-service.png): Typo in image 
The ng-app was called ng=app in diagram image.

Closes #6473
Closes #7528
 2014-05-21 12:51:26 +01:00
Wes Alvaro
fd49d6634c docs(ngRoute): $routeParams is Object.<string, string> 
Closes #7386
 2014-05-21 12:49:04 +01:00
Ralph Giles
cecd5214df docs(*): fix its vs it's typos. 
Only use the apostrophe if you can expand "it's" to "it is" and
still have a grammatical phrase.
 2014-05-20 17:51:32 -04:00
Gaëtan PRIOUR
c5e39c688b docs(tutorial): fixed path to controllersSpec.js file 
☆.。.：*・゜☆ DOMO ARIGATO MR ROBOTO ☆.。.：*・゜☆
 2014-05-20 12:19:33 -04:00
Igor Minar
240608447a revert: fix($compile): pass transcludeFn down to nested transclude directives 
This reverts commit 113850602d.

This change introduced regressions for several scenarios.

reduction: http://jsfiddle.net/5242N/4/
 2014-05-19 15:01:19 -07:00
Slava Fomin
bcb53deda8 docs(NgAnimate): update the list of supported animations 
Closes #7502
 2014-05-19 14:24:26 -04:00
Igor Minar
9d4fa33e35 perf($interpolate): optimize value stringification 
previously we stringified numbers via toJson which was expensive, I optimized
the code so that toJson is invoked only if really necessary

Closes #7501
 2014-05-19 06:35:28 -07:00
Diego Plentz
de1461da78 docs(guide/$location) remove duplicate 'Crawling your app' section 
The "Crawling your app" section was duplicated.
I just removed the duplication and moved the section to the 'Caveats' section.

Closes #7244
 2014-05-19 14:07:36 +01:00
Kebabpizza
2866daf7d6 docs(tutorial): fix link to bower in step 12 
Muchas gracias! \o/
 2014-05-18 20:48:40 -04:00
Brian Ford
b3de37e418 test($compile): use trim helper 2014-05-16 18:19:16 -07:00
Shahar Talmi
a4cc9e1944 fix(ngClass): handle index changes when an item is unshifted 
Closes #7256
 2014-05-16 14:10:38 -07:00
M Alix
f8a1c56cad chore($compile): make webstorm's regexp parser happy 
Minor change puts \- at end of character pattern

In CLASS_DIRECTIVE_REGEXP and COMMENT_DIRECTIVE_REGEXP, putting the \- character at
the end of the character patter speeds up many IDE parsers and alleviates some
errors in certain IDE's. (WebStorm 8)

Functionally absolutely equivalent. No test change needed.

Closes #7093
 2014-05-16 13:12:39 -07:00