mirror of
https://github.com/zhigang1992/angular.js.git
synced 2026-04-23 03:30:02 +08:00
fix(compiler): revert 8611ebe6 - calling \$digest after linking
Change introduced by me in 8611ebe6 results in considerable inefficiencies when the compiler
and linker is used from within a widget, in which case, we call $digest unnecessary since it
will be called by the $apply which called the directive/widget in the first place.
There are only two places when the extra $digest call can be useful - when manually bootstrapping
the app or in tests. However even in tests this behavior can result in unwanted results (especially
when ng:controller is involved). So it is better to leave it for the developer to call $digest
when it is really needed.
This commit is contained in:
@@ -119,6 +119,15 @@ Template.prototype = {
|
||||
* the same scope as the one passed into the template function, or if none were provided it's the
|
||||
* newly create scope.
|
||||
*
|
||||
* It is important to understand that the returned scope is "linked" to the view DOM, but no linking
|
||||
* (instance) functions registered by {@link angular.directive directives} or
|
||||
* {@link angular.widget widgets} found in the template have been executed yet. This means that the
|
||||
* view is likely empty and doesn't contain any values that result from evaluation on the scope. To
|
||||
* bring the view to life, the scope needs to run through a $digest phase which typically is done by
|
||||
* Angular automatically, except for the case when an application is being
|
||||
* {@link guide/dev_guide.bootstrap.manual_bootstrap} manually bootstrapped, in which case the
|
||||
* $digest phase must be invoked by calling {@link angular.scope.$apply}.
|
||||
*
|
||||
* If you need access to the bound view, there are two ways to do it:
|
||||
*
|
||||
* - If you are not asking the linking function to clone the template, create the DOM element(s)
|
||||
@@ -209,7 +218,6 @@ Compiler.prototype = {
|
||||
scope.$element = element;
|
||||
(cloneConnectFn||noop)(element, scope);
|
||||
template.link(element, scope);
|
||||
if (!scope.$$phase) scope.$digest();
|
||||
return scope;
|
||||
};
|
||||
},
|
||||
|
||||
Reference in New Issue
Block a user