kylefang/angular.js
1
0
Fork 0
mirror of https://github.com/zhigang1992/angular.js.git synced 2026-04-18 12:08:17 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(equals): {} and [] should not be considered equivalent

Browse Source 
angular.equals was returning inconsistent values for the comparison between
{} and []:

    angular.equals({}, []) // true
    angular.equals([], {}]) // false

Since these object are not of the same type, they should not be considered
equivalent.
This commit is contained in:
Brenton
2013-06-01 23:29:18 -07:00
committed by Jeff Cross
parent 4a7b6a4555
commit 1dcafd18af
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
test/AngularSpec.js
View File

@@ -289,6 +289,11 @@ describe('angular', function() {
expect(equals(/^abc/, /abc/)).toBe(false);
expect(equals(/^abc/, '/^abc/')).toBe(false);
});
it('should return false when comparing an object and an array', function() {
expect(equals({}, [])).toBe(false);
expect(equals([], {})).toBe(false);
});
});
describe('size', function() {