chore($q): replace plain TypeError with minErr+TypeError in cyclical resolve check

This commit is contained in:
Jeff Cross
2014-08-21 16:02:04 -07:00
parent 1b331f3729
commit 0462b688f9
3 changed files with 48 additions and 3 deletions

View File

@@ -0,0 +1,23 @@
@ngdoc error
@name $q:qcycle
@fullName Cannot resolve a promise with itself
@description
Occurs when resolving a promise with itself as the value, including returning the promise in a
function passed to `then`. The A+ 1.1 spec mandates that this behavior throw a TypeError.
https://github.com/promises-aplus/promises-spec#the-promise-resolution-procedure
```
var promise = $q.defer().promise;
//bad
promise.then(function (val) {
//Cannot return self
return promise;
});
//good
promise.then(function (val) {
return 'some other value';
});
```