From f72cc12b94b96e596ffa79176867efdc6ebdecbf Mon Sep 17 00:00:00 2001 From: Krunoslav Zaher Date: Sun, 26 Jun 2016 14:59:45 +0200 Subject: [PATCH] Improves CONTRIBUTING.md --- .travis.yml | 2 +- CONTRIBUTING.md | 8 ++++++++ scripts/{pre-release-tests.sh => all-tests.sh} | 0 3 files changed, 9 insertions(+), 1 deletion(-) rename scripts/{pre-release-tests.sh => all-tests.sh} (100%) diff --git a/.travis.yml b/.travis.yml index da58ee7b..00c346ad 100644 --- a/.travis.yml +++ b/.travis.yml @@ -8,4 +8,4 @@ notifications: script: - "bundle exec danger --verbose" - - ./scripts/pre-release-tests.sh + - ./scripts/add-tests.sh diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5e47ef6f..b65745d9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -13,6 +13,14 @@ So what does this mean in practice: * Please target your PR to **develop** branch * If you want to make a bigger contribution to the project, please [open an issue first](https://github.com/ReactiveX/RxSwift/issues/new) so we can plan that work, discuss the architecture and brainstorm around that idea first. +## Submitting a Pull Request + +Before submitting a pull request please make sure **`./scripts/all-tests.sh`** is passing (exits with 0), otherwise we won't be able to pull your code. + +To be able to run `./scripts/all-tests.sh`, you'll need to install [xcpretty](https://github.com/supermarin/xcpretty). + +`sudo gem install xcpretty` + ## Developer's Certificate of Origin 1.1 By making a contribution to this project, I certify that: diff --git a/scripts/pre-release-tests.sh b/scripts/all-tests.sh similarity index 100% rename from scripts/pre-release-tests.sh rename to scripts/all-tests.sh