From 84e2a3b9140dcf28cdbed8e84153d3c86d7cdafc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Eloy=20Dur=C3=A1n?= Date: Wed, 19 Mar 2014 20:06:12 +0100 Subject: [PATCH] [test] Let tests fail on 32-bit, now that we reverted to LLVM 3.3. --- test/helpers/bacon.rb | 2 -- test/test/spec/main_spec.rb | 6 +++--- test/test/spec/memory_spec.rb | 2 +- test/test/spec/special_selectors_spec.rb | 8 ++++---- test/test/spec/string_spec.rb | 2 +- test/test/spec/weakref_spec.rb | 2 +- 6 files changed, 10 insertions(+), 12 deletions(-) diff --git a/test/helpers/bacon.rb b/test/helpers/bacon.rb index b33498a1..54ec829d 100644 --- a/test/helpers/bacon.rb +++ b/test/helpers/bacon.rb @@ -34,8 +34,6 @@ module Bacon alias_method :on_64bit_it, RUBY_ARCH =~ /64/ ? :it : :xit - alias_method :broken_on_32bit_it, :on_64bit_it - alias_method :on_ios_it, defined?(UIView) ? :it : :xit end diff --git a/test/test/spec/main_spec.rb b/test/test/spec/main_spec.rb index d00cb7ae..a94f2508 100644 --- a/test/test/spec/main_spec.rb +++ b/test/test/spec/main_spec.rb @@ -16,7 +16,7 @@ describe 'A method accepting a 32-bit struct' do end describe 'A method returning a 64-bit struct' do - broken_on_32bit_it "can be called" do + it "can be called" do o = TestMethod.new o.methodReturningCGSize.should == CGSize.new(1, 2) end @@ -28,7 +28,7 @@ describe 'A method returning a 64-bit struct' do end describe 'A method returning a 128-bit struct' do - broken_on_32bit_it "can be called" do + it "can be called" do o = TestMethod.new o.methodReturningCGRect.should == CGRect.new(CGPoint.new(1, 2), CGSize.new(3, 4)) end @@ -161,7 +161,7 @@ class TestPrivateMethod end describe "A private method" do - broken_on_32bit_it "cannot be called with #public_send" do + it "cannot be called with #public_send" do o = TestPrivateMethod.new o.foo.should == 42 o.send(:foo).should == 42 diff --git a/test/test/spec/memory_spec.rb b/test/test/spec/memory_spec.rb index d7c13663..3b7d28db 100644 --- a/test/test/spec/memory_spec.rb +++ b/test/test/spec/memory_spec.rb @@ -226,7 +226,7 @@ class Proc end describe "C functions that return retained objects" do - broken_on_32bit_it "returns an autoreleased object if the function name contains 'Create'" do + it "returns an autoreleased object if the function name contains 'Create'" do lambda { CFStringCreateWithFormat(nil, {}, '%@', 42) }.should.be.autoreleased diff --git a/test/test/spec/special_selectors_spec.rb b/test/test/spec/special_selectors_spec.rb index 0a1b2247..e789c264 100644 --- a/test/test/spec/special_selectors_spec.rb +++ b/test/test/spec/special_selectors_spec.rb @@ -23,24 +23,24 @@ describe "Objective-C predicate" do end describe "Objective-C subscripting" do - broken_on_32bit_it "is available in its Ruby `#[]` getter form" do + it "is available in its Ruby `#[]` getter form" do obj = TestSpecialSelectors.new obj.should.respond_to :[] end - broken_on_32bit_it "is available in its Ruby `#[]=` setter form" do + it "is available in its Ruby `#[]=` setter form" do obj = TestSpecialSelectors.new obj.should.respond_to :[]= end - broken_on_32bit_it "works with indexed-subscripting" do + it "works with indexed-subscripting" do obj = TestSpecialSelectors.new o = obj[0] = 42 obj[0].should == 42 o.should == 42 end - broken_on_32bit_it "works with keyed-subscripting" do + it "works with keyed-subscripting" do obj = TestSpecialSelectors.new o = obj['a'] = 'foo' obj['a'].should == 'foo' diff --git a/test/test/spec/string_spec.rb b/test/test/spec/string_spec.rb index 89d6a0e6..9c01834b 100644 --- a/test/test/spec/string_spec.rb +++ b/test/test/spec/string_spec.rb @@ -36,7 +36,7 @@ describe "Strings with multibyte characters" do "..€€……".index("…").should == 4 end - broken_on_32bit_it "finds the most right-side index of a character" do + it "finds the most right-side index of a character" do "..€€……".rindex(".").should == 1 "..€€……".rindex("€").should == 3 "..€€……".rindex("…").should == 5 diff --git a/test/test/spec/weakref_spec.rb b/test/test/spec/weakref_spec.rb index 891fe9e1..4a72f96a 100644 --- a/test/test/spec/weakref_spec.rb +++ b/test/test/spec/weakref_spec.rb @@ -65,7 +65,7 @@ describe "WeakRef" do end end - broken_on_32bit_it "raises a WeakRef::RefError if messaged when the reference is no longer alive" do + it "raises a WeakRef::RefError if messaged when the reference is no longer alive" do autorelease_pool do @ref = WeakRef.new(Object.new) lambda { @ref.to_s }.should.not.raise