Commit Graph

644 Commits

Author SHA1 Message Date
Blake Watters
c19a500ca8 Fix indentation inconsistencies in dealloc 2012-01-24 20:45:20 -05:00
Blake Watters
98cb113abf Invalidate the timer before dispatching error delegate callbacks 2012-01-24 20:45:17 -05:00
Brian Morton
7174937bb8 Remove duplicate timer creation. Fixes #517. 2012-01-24 11:10:17 -05:00
Brian Morton
b2c4b2f677 Move RKRequest timeoutTimer creation to a helper method so that we can test the number of times it is invoked. 2012-01-24 11:10:17 -05:00
Jeff Arena
fa44916184 Merge pull request #505 from spenrose/xml-attributes-bug
This fixes a bug where attributes of a object would also get added to parent object.
2012-01-20 08:36:51 -08:00
Marlon Andrade
377d350259 adding treatment for dates before jan 1st 1970 2012-01-20 09:36:22 -05:00
Brian Morton
035e7732b8 Add RKRequestConnectionTimeoutError to throw when our connection timeout has been exceeded. 2012-01-20 09:20:09 -05:00
Brian Morton
90716335f5 Add support for timing out an RKRequest via a timeoutTimer and a timeout property.
* Add timeoutInterval property on RKRequest with a default value of 120.0
* Add timeout method that is called by the timer when the timeout interval has been exceeded to cancel the request and return an error via didFailLoadWithError:
* Add invalidateTimeoutTimer method that is called by RKResponse when the NSURLConnection begins receiving data.
* Add call to invalidateTimeoutTimer in RKRequest cancelAndInformDelegate: so we don't have a dangling timer.
* Add timer creation to sendAsynchronously and sendSynchronously
2012-01-20 09:19:45 -05:00
Brian Morton
8051fbd9ab Invalidate the RKRequest timer in RKResponse when the NSURLConnection begins receiving data. 2012-01-20 09:17:26 -05:00
Brian Morton
8946f4d702 Add timeoutInterval property to RKClient so that it can be passed on to RKRequest. 2012-01-20 09:17:16 -05:00
Brian Morton
dab403a9c1 Responsibly invalidate the timeoutTimer when the RKRequest is deallocated. Move location of timer creation for asynchronous request. 2012-01-20 09:17:00 -05:00
Brian Morton
15d05f1493 Move the invalidateTimeoutTimer call in RKResponse from didReceiveData to didReceiveResponse and didFailWithError so we are sure its always called and as early as possible. 2012-01-20 09:15:35 -05:00
Scott Penrose
c6fd924b73 This fixes a bug where attributes of a object would also get added to parent object.
XML to parse
```
<exchange_rate type="XML_RATE_TYPE_EBNK_MIDDLE" valid_from="2011-08-03 00:00:00.0">
    <currency name="AUD" quota="1" rate="18.416"/>
    <currency name="HRK" quota="1" rate="3.25017"/>
    <currency name="DKK" quota="1" rate="3.251"/>
</exchange_rate>
```

BEFORE FIX
```
<CFBasicHash 0xab93140 [0x520b38]>{type = mutable dict, count = 1,
entries =>
	0 : <CFString 0xabacac0 [0x520b38]>{contents = "exchange_rate"} = <CFBasicHash 0xaba99e0 [0x520b38]>{type = mutable dict, count = 6,
entries =>
	0 : <CFString 0xabc1e40 [0x520b38]>{contents = "currency"} = (
        {
        name = AUD;
        quota = 1;
        rate = "18.416";
    },
        {
        name = HRK;
        quota = 1;
        rate = "3.25017";
    },
        {
        name = DKK;
        quota = 1;
        rate = "3.251";
    }
)
	1 : <CFString 0xaba9940 [0x520b38]>{contents = "name"} = <CFString 0xaba9960 [0x520b38]>{contents = "DKK"}
	2 : <CFString 0xaba9990 [0x520b38]>{contents = "rate"} = <CFString 0xaba99c0 [0x520b38]>{contents = "3.251"}
	3 : <CFString 0xaba9980 [0x520b38]>{contents = "quota"} = <CFString 0xaba99a0 [0x520b38]>{contents = "1"}
	4 : <CFString 0xab93180 [0x520b38]>{contents = "type"} = <CFString 0xab931b0 [0x520b38]>{contents = "XML_RATE_TYPE_EBNK_MIDDLE"}
	5 : <CFString 0xab93190 [0x520b38]>{contents = "valid_from"} = <CFString 0xab93220 [0x520b38]>{contents = "2011-08-03 00:00:00.0"}
}

}
```

AFTER FIX
```
<CFBasicHash 0xa689830 [0x520b38]>{type = mutable dict, count = 1,
entries =>
	0 : <CFString 0xa6816a0 [0x520b38]>{contents = "exchange_rate"} = <CFBasicHash 0xa6897c0 [0x520b38]>{type = mutable dict, count = 3,
entries =>
	0 : <CFString 0xa692100 [0x520b38]>{contents = "valid_from"} = <CFString 0xa692190 [0x520b38]>{contents = "2011-08-03 00:00:00.0"}
	1 : <CFString 0xa680860 [0x520b38]>{contents = "currency"} = (
        {
        name = AUD;
        quota = 1;
        rate = "18.416";
    },
        {
        name = HRK;
        quota = 1;
        rate = "3.25017";
    },
        {
        name = DKK;
        quota = 1;
        rate = "3.251";
    }
)
	2 : <CFString 0xa6920f0 [0x520b38]>{contents = "type"} = <CFString 0xa692120 [0x520b38]>{contents = "XML_RATE_TYPE_EBNK_MIDDLE"}
}

}
```
2012-01-14 17:12:17 -05:00
Brian Morton
0f3f3d5702 Add support for mapping an array to an NSOrderedSet. 2012-01-13 00:04:40 -08:00
Ray Fix
7be7da61cb Fix for ocassional crashes using http basic auth 2012-01-09 20:10:39 -05:00
David Young-Chan Kay
6a18ebd91b RKRequest: Added null check for HTTP Basic username and password. Closes #493. 2012-01-09 20:08:26 -05:00
Blake Watters
89a4e579fd Revert "Merge branch 'nolanw-request-delegate-gets-failed-auth-challenge'"
This reverts commit d6510d963f, reversing
changes made to a1e2061106.
2012-01-09 19:53:23 -05:00
Blake Watters
4d99d28a4d Merge pull request #477 from rayfix/fix-log-root-key-path
Fixed logging of root key path on object mapping. Remove TODO comment.
2011-12-16 21:23:21 -08:00
chethan
ea0cbed8dc Fixed logging of root key path on object mapping. Remove TODO comment that is done. 2011-12-16 18:20:24 -08:00
Blake Watters
af7a7d22b6 Lowered logging level for body from Info to Debug 2011-12-15 13:41:00 -05:00
Blake Watters
e5e05a0563 Added delegate callback when authentication challenge fails. closes #462 2011-12-13 21:16:30 -05:00
Julien Grimault
a1e2061106 Modified asserts in RKObjectLoader processMappingResult to allow synchronous requests. 2011-12-13 20:58:15 -05:00
Blake Watters
4f24470d13 Merge pull request #465 from rayfix/url-encoding-fix
Encoded params from RKURLs getting extra 25's.
2011-12-13 15:02:37 -08:00
Matthias Bartelmeß
e123eaa5fb Updated RKResponse to respect the encoding returned in the Content-Type header (charset=XXX). Exposed
encoding information as methods on RKResponse
2011-12-13 17:03:31 -05:00
Blake Watters
5d8e62e6a5 Merge pull request #468 from rayfix/should-delete-orphans-451
Add Delegate for shouldDeleteOrphanedObject:
2011-12-13 12:42:06 -08:00
Ray Fix
21c3b6af39 Fix static analayzer warning for uninitialized variable 2011-12-13 15:33:14 -05:00
Blake Watters
4c8a7f1103 Merge pull request #470 from inquinity/master
Fixed: RKResponse parsedBody will fail when encountering a parsing error if it was called with a nil NSError pointer
2011-12-13 12:12:11 -08:00
Robert Altman
2969e6b9f3 Added missing non-null test for NSError pointer 2011-12-12 17:06:17 -06:00
Ray Fix
f23b242e87 First cut at issue 451, shouldDeleteOrphanedObject.
The test is currently failing and the 6 results are
returned instead of keeping alive only the original
4 result objects.  Requires further investigation.
2011-12-11 09:13:35 -08:00
Ray Fix
7eaa0bccfe Fix test failure. Encoded URLs getting extra 25's. 2011-12-09 18:18:08 -08:00
Blake Watters
4a45a15da1 Fixed nearly all broken tests for OS X target 2011-12-09 00:30:34 -05:00
Blake Watters
479864902b Fixed all build warnings on OS X Framework target 2011-12-08 23:23:20 -05:00
Nolan Waite
9cc6de8dc4 Request delegate can learn of authentication failures 2011-12-08 13:17:52 -07:00
Blake Watters
8ca1a5bd99 Remove relative import paths from Parsers 2011-12-02 09:27:23 -05:00
Blake Watters
6f68ffb342 Applied patch from Scott Penrose to handle issues with NSNull values mapped to Core Data properties. closes #436
Added RKLogWarning for aiding in further debugging. So far unable to trap this in a unit test, but have had
several complaints about the issue on the mailing list.
2011-12-02 09:27:23 -05:00
Blake Watters
8a39f93e62 Add support for handling 204 'No Content' responses. fixes #450 2011-12-02 09:27:22 -05:00
Blake Watters
a11c999950 Added CoreData.h import to main RestKit header. Updated quick start installation language. 2011-12-02 09:26:37 -05:00
Blake Watters
563f5e909b Updated all example projects to build against the new project. Cleaned up header imports for flattened project structure 2011-12-02 09:26:36 -05:00
Blake Watters
f5008ff9fe Cleaned up broken specs for iOS. 2011-12-02 09:26:35 -05:00
Blake Watters
5b718890ac Checking in work in progress on the library reorganization 2011-12-02 09:26:35 -05:00
Blake Watters
ceb7eb478a Merge pull request #425 from jsullivanlive/patch-1
Adding missing exception name
2011-12-01 16:45:08 -08:00
Michael Fleet
0a0c3ac59e Fixed bug where local requests for bundle resources returned a NSURLResponse instead of a NSHTTPURLResponse, and therefore doesn't respond to statusCode or allHeaderFields. 2011-12-01 11:43:22 -05:00
Michael Fleet
6391e5083a Fixed bug where escaped spaces (%20) in URLs were stripped by [NSURL path] and not restored, causing request failures. 2011-12-01 11:41:28 -05:00
Blake Watters
7ee6fb54f9 Merge pull request #433 from aaroncrespo/master
Unreleased dateFormatter.
2011-11-28 06:22:37 -08:00
Blake Watters
70e2accd1d Remove performSelector invocations that have resulted in App Store rejections. fixes #442 2011-11-17 15:32:48 -05:00
Tony Lee
a5661061ec The OAuth use correct parameters to make signature for HTTP PUT/POST. 2011-11-10 17:29:27 +08:00
Blake Watters
fd80eae643 Reworked reachability initialization to support usage when there is no Internet connectivity.
* When the reachabilityObserver property of RKClient is nil, assume we have reachability
* When the baseURL configured contains an IP address or localhost, use hostname based reachability
* Else fall through to using Internet reachability if the user has not configured an observer directly
2011-11-09 08:17:46 -05:00
Blake Watters
dad00a4f6f Fix typo 'current' => 'concurrent' 2011-11-04 11:28:54 -03:00
Aaron Crespo
6b8ab373ac Update Code/ObjectMapping/RKObjectMapping.m 2011-11-03 16:26:50 -03:00
James Sullivan
8282bdb644 Fixing missing exception name. Without it, no exception is printed to the console in debug mode and no stack trace persists, which makes it very hard to debug. 2011-10-27 21:57:19 -03:00