kylefang/RestKit
1
0
Fork 0
mirror of https://github.com/zhigang1992/RestKit.git synced 2026-04-23 20:31:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Finalized to existingObjectWithID: approach after benchmarking fetch request strategy

Browse Source
This commit is contained in:
Blake Watters
2012-07-20 16:09:58 -04:00
parent 093a76e7b2
commit 5af66a4e89
2 changed files with 33 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
Code/CoreData/RKEntityByAttributeCache.m
View File

@@ -179,33 +179,23 @@
- (NSArray *)objectsWithAttributeValue:(id)attributeValue inContext:(NSManagedObjectContext *)context
{
attributeValue = [self shouldCoerceAttributeToString:attributeValue] ? [attributeValue stringValue] : attributeValue;
NSMutableArray *objectIDs = [self.attributeValuesToObjectIDs objectForKey:attributeValue];
NSMutableArray *objectIDs = [[self.attributeValuesToObjectIDs objectForKey:attributeValue] copy];
if (objectIDs) {
NSFetchRequest *fetchRequest = [[NSFetchRequest alloc] init];
fetchRequest.entity = self.entity;
fetchRequest.predicate = [NSPredicate predicateWithFormat:@"self in %@", objectIDs];
__block NSArray *objects;
__block NSError *error;
[context performBlockAndWait:^{
objects = [context executeFetchRequest:fetchRequest error:&error];
}];
if (! objects) {
RKLogWarning(@"Failed to retrieve cached objects. Execution failed for fetch request: %@", fetchRequest);
RKLogCoreDataError(error);
/**
NOTE:
In my benchmarking, retrieving the objects one at a time using existingObjectWithID: is significantly faster
than issuing a single fetch request against all object ID's.
*/
NSMutableArray *objects = [NSMutableArray arrayWithCapacity:[objectIDs count]];
for (NSManagedObjectID *objectID in objectIDs) {
NSManagedObject *object = [self objectForObjectID:objectID inContext:context];
if (object) {
[objects addObject:object];
} else {
RKLogDebug(@"Evicting objectID association for attribute '%@'=>'%@' of Entity '%@': %@", self.attribute, attributeValue, self.entity.name, objectID);
[self removeObjectID:objectID forAttributeValue:attributeValue];
}
}
// NSMutableArray *objects = [NSMutableArray arrayWithCapacity:[objectIDs count]];
// for (NSManagedObjectID *objectID in objectIDs) {
// NSManagedObject *object = [self objectForObjectID:objectID inContext:context];
// if (object) {
// [objects addObject:object];
// } else {
// RKLogDebug(@"Evicting objectID association for attribute '%@'=>'%@' of Entity '%@': %@", self.attribute, attributeValue, self.entity.name, objectID);
// [self removeObjectID:objectID forAttributeValue:attributeValue];
// }
// }
return objects;
}
@@ -262,7 +252,7 @@
objectID = [object objectID];
attributeValue = [object valueForKey:self.attribute];
}];
NSAssert([entity isEqual:self.entity], @"Cannot remove object with entity '%@' from cache with entity of '%@'", [entity name], [self.entity name]);
NSAssert([entity isEqual:self.entity], @"Cannot add object with entity '%@' to cache for entity of '%@'", [entity name], [self.entity name]);
// Coerce to a string if possible
[self setObjectID:objectID forAttributeValue:attributeValue];
}
@@ -277,7 +267,7 @@
objectID = [object objectID];
attributeValue = [object valueForKey:self.attribute];
}];
NSAssert([entity isEqual:self.entity], @"Cannot remove object with entity '%@' from cache with entity of '%@'", [entity name], [self.entity name]);
NSAssert([entity isEqual:self.entity], @"Cannot remove object with entity '%@' from cache for entity of '%@'", [entity name], [self.entity name]);
[self removeObjectID:objectID forAttributeValue:attributeValue];
}