kylefang/RestKit
1
0
Fork 0
mirror of https://github.com/zhigang1992/RestKit.git synced 2026-04-24 04:46:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

Updates to relationship connection execution system for better encapsulation and reuse.

Browse Source 
* Reworked execution of relationship connection operations to use dependencies instead of queue suspension.
* Migrates responsibility for connecting relationships from `RKManagedObjectRequestOperation` into `RKManagedObjectResponseMapperOperation`. This ensures that you get a mapped and connected object graph back from the response mapper if you are using it outside of a request operation.
* Add `parentOperation` to managed object mapping data source to establish dependencies.
This commit is contained in:
Blake Watters
2012-10-15 16:06:22 -04:00
parent 1ad2cabf2a
commit 342c57213b
6 changed files with 70 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
Code/CoreData/RKManagedObjectMappingOperationDataSource.h
View File

@@ -31,6 +31,23 @@
*/
@interface RKManagedObjectMappingOperationDataSource : NSObject <RKMappingOperationDataSource>
///------------------------------------------------------------------
/// @name Initializing a Managed Object Mapping Operation Data Source
///------------------------------------------------------------------
/**
Initializes the receiver with a given managed object context and managed object cache.
@param managedObjectContext The managed object context with which to associate the receiver. Cannot be nil.
@param managedObjectCache The managed object cache used by the receiver to find existing object instances by primary key.
@return The receiver, initialized with the given managed object context and managed objet cache.
*/
- (id)initWithManagedObjectContext:(NSManagedObjectContext *)managedObjectContext cache:(id<RKManagedObjectCaching>)managedObjectCache;
///-----------------------------------------------------
/// @name Accessing the Managed Object Context and Cache
///-----------------------------------------------------
/**
The managed object context with which the receiver is associated.
*/
@@ -44,18 +61,24 @@
*/
@property (nonatomic, strong, readonly) id<RKManagedObjectCaching> managedObjectCache;
///---------------------------------------------------
/// @name Configuring Relationship Connection Queueing
///---------------------------------------------------
/**
The parent operation upon which instances of `RKRelationshipConnectionOperation` created by the data source are dependent upon.
When connecting relationships as part of a managed object mapping operation, it is possible that the mapping operation itself will create managed objects that should be used to satisfy the connections mappings of representations being mapped. To support such cases, is is desirable to defer the execution of connection operations until the execution of the aggregate mapping operation is complete. The `parentOperation` property provides support for deferring the execution of the enqueued relationship connection operations by establishing a dependency between the connection operations and a parent operation, such as an instance of `RKMapperOperation` such that they will not be executed by the `operationQueue` until the parent operation has finished executing.
*/
@property (nonatomic, weak) NSOperation *parentOperation;
/**
The operation queue in which instances of `RKRelationshipConnectionOperation` will be enqueued to connect the relationships of mapped objects.
If `nil`, then the operation queue returned from `[NSOperationQueue currentQueue]` will be used.
Please see the documentation for `parentOperation` for a discussion of this property's function.
*/
@property (nonatomic, strong) NSOperationQueue *operationQueue;
/**
Initializes the receiver with a given managed object context and managed object cache.
@param managedObjectContext The managed object context with which to associate the receiver. Cannot be nil.
@param managedObjectCache The managed object cache used by the receiver to find existing object instances by primary key.
@return The receiver, initialized with the given managed object context and managed objet cache.
*/
- (id)initWithManagedObjectContext:(NSManagedObjectContext *)managedObjectContext cache:(id<RKManagedObjectCaching>)managedObjectCache;
@property (nonatomic, weak) NSOperationQueue *operationQueue;
@end

21
Code/CoreData/RKManagedObjectMappingOperationDataSource.m
View File

@@ -28,6 +28,10 @@
#import "RKManagedObjectCaching.h"
#import "RKRelationshipConnectionOperation.h"
// Set Logging Component
#undef RKLogComponent
#define RKLogComponent RKlcl_cRestKitCoreData
extern NSString * const RKObjectMappingNestingAttributeKeyName;
@interface RKManagedObjectMappingOperationDataSource ()
@@ -149,20 +153,15 @@ extern NSString * const RKObjectMappingNestingAttributeKeyName;
RKRelationshipConnectionOperation *operation = [[RKRelationshipConnectionOperation alloc] initWithManagedObject:mappingOperation.destinationObject
connectionMapping:connectionMapping
managedObjectCache:self.managedObjectCache];
// TODO: This should really be done using dependencies...
if (self.operationQueue) {
[self.operationQueue addOperation:operation];
[operation setCompletionBlock:^{
if ([mappingOperation.delegate respondsToSelector:@selector(mappingOperation:didConnectRelationship:usingMapping:)]) {
[mappingOperation.delegate mappingOperation:mappingOperation didConnectRelationship:connectionMapping.relationship usingMapping:connectionMapping];
}
}];
} else {
[operation start];
[operation setCompletionBlock:^{
if ([mappingOperation.delegate respondsToSelector:@selector(mappingOperation:didConnectRelationship:usingMapping:)]) {
[mappingOperation.delegate mappingOperation:mappingOperation didConnectRelationship:connectionMapping.relationship usingMapping:connectionMapping];
}
}
}];
if (self.parentOperation) [operation addDependency:self.parentOperation];
NSOperationQueue *operationQueue = self.operationQueue ?: [NSOperationQueue currentQueue];
[operationQueue addOperation:operation];
RKLogTrace(@"Enqueued %@ dependent upon parent operation %@ to operation queue %@", operation, self.parentOperation, operationQueue);
}
}
}