kylefang/RestKit
1
0
Fork 0
mirror of https://github.com/zhigang1992/RestKit.git synced 2026-05-03 15:04:53 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix issue where repeatedly mapping a to-many relationship without identification attributes would cause the first object in the relationship to be inappropriately reused

Browse Source
This commit is contained in:
Blake Watters
2013-01-26 12:10:55 -05:00
parent d761de0ea7
commit 039c7c443d
5 changed files with 51 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
Code/CoreData/RKManagedObjectMappingOperationDataSource.m
View File

@@ -105,6 +105,22 @@ static NSDictionary *RKEntityIdentificationAttributesForEntityMappingWithReprese
return entityIdentifierAttributes;
}
static id RKMutableCollectionValueWithObjectForKeyPath(id object, NSString *keyPath)
{
id value = [object valueForKeyPath:keyPath];
if ([value isKindOfClass:[NSArray class]]) {
return [object mutableArrayValueForKeyPath:keyPath];
} else if ([value isKindOfClass:[NSSet class]]) {
return [object mutableSetValueForKeyPath:keyPath];
} else if ([value isKindOfClass:[NSOrderedSet class]]) {
return [object mutableOrderedSetValueForKeyPath:keyPath];
} else if (value) {
return [NSMutableArray arrayWithObject:value];
}
return nil;
}
@interface RKManagedObjectDeletionOperation : NSOperation
- (id)initWithManagedObjectContext:(NSManagedObjectContext *)managedObjectContext;
@@ -215,12 +231,12 @@ extern NSString * const RKObjectMappingNestingAttributeKeyName;
// If we are mapping within a relationship, try to find an existing object without identifying attributes
if (relationship) {
id existingObjects = [mappingOperation.destinationObject valueForKeyPath:relationship.destinationKeyPath];
if (existingObjects && ![existingObjects respondsToSelector:@selector(count)]) existingObjects = @[ existingObjects ];
id mutableArrayOrSetValueForExistingObjects = RKMutableCollectionValueWithObjectForKeyPath(mappingOperation.destinationObject, relationship.destinationKeyPath);
NSArray *identificationAttributes = [entityMapping.identificationAttributes valueForKey:@"name"];
for (NSManagedObject *existingObject in existingObjects) {
for (NSManagedObject *existingObject in mutableArrayOrSetValueForExistingObjects) {
if (! identificationAttributes) {
managedObject = existingObject;
[mutableArrayOrSetValueForExistingObjects removeObject:managedObject];
break;
}