kylefang/ProMotion
1
0
Fork 0
mirror of https://github.com/zhigang1992/ProMotion.git synced 2026-04-23 11:57:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'refs/heads/master' into pm2-accessory-type

Browse Source 
* refs/heads/master:
  Fixes deprecation warning.
  Add long_press_action to the cell non-deprecated whitelist.
  Added migration guide to README
  Update README.md
  Version 2.0.0.rc1

Conflicts:
	lib/ProMotion/table/cell/table_view_cell_module.rb
This commit is contained in:
Mark Rickert
2014-06-23 20:44:11 -04:00
parent 37cb5a7015 6522e838a9
commit 416126d953
3 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
README.md
View File

@@ -87,6 +87,8 @@ end
Overview: In ProMotion 2.0, we removed deprecated APIs, refactored and cleaned up a ton of code, pulled `PushNotification` and `MapScreen` into their own gems, and simplified the API. It now builds 55% faster and is 20%+ lighter.
Follow our [Migration Guide](https://github.com/clearsightstudio/ProMotion/wiki/Migration-Guide:-ProMotion-1.2-to-2.0) for a painless upgrade.
**API changes**
1. Extracted `PM::MapScreen` into [ProMotion-map](https://github.com/clearsightstudio/ProMotion-map)
@@ -111,7 +113,7 @@ Overview: In ProMotion 2.0, we removed deprecated APIs, refactored and cleaned u
3. Moved many files around into a more logical, simpler structure.
4. Removed `PM::Conversions`. The only helper we were using was the `objective_c_method_name` method, and that was only used in `PM::Styling`. So we moved it there.
5. New module, `PM::NavBarModule`. Moved any navigation controller methods into this module, cleaning up the `PM::ScreenModule` quite a bit.
6. Lots of code refactoring -- CodeClimate went from 2.47 to 3.42 GPA.
6. Lots of code refactoring -- CodeClimate went from [2.47 to 3.35 GPA](http://clrsight.co/jh/8fi5l31nzs.png).
7. Much cleaner `open` code!
8. Converted several *slow* functional tests into *fast* unit tests with the same coverage.

4
lib/ProMotion/table/cell/table_view_cell_module.rb
View File

@@ -23,9 +23,9 @@ module ProMotion
# TODO: Remove this in ProMotion 2.1. Just for migration purposes.
def check_deprecated_styles
whitelist = [ :title, :subtitle, :image, :remote_image, :accessory, :selection_style, :action, :arguments, :cell_style, :cell_class, :cell_identifier, :editing_style, :search_text, :keep_selection, :height, :accessory_type ]
whitelist = [ :title, :subtitle, :image, :remote_image, :accessory, :selection_style, :action, :long_press_action, :arguments, :cell_style, :cell_class, :cell_identifier, :editing_style, :search_text, :keep_selection, :height, :accessory_type ]
if (data_cell.keys - whitelist).length > 0
PM.logger.deprecated("In #{self.table_screen.class.to_s}#table_data, you should set :#{(data_cell.keys - whitelist).join(", :")} in a `styles:` hash. See TableScreen documentation.")
PM.logger.deprecated("In #{self.table_screen.class.to_s}#table_data, you should set :#{(data_cell.keys - whitelist).join(", :")} in a `style:` hash. See TableScreen documentation.")
end
end

2
lib/ProMotion/version.rb
View File

@@ -1,3 +1,3 @@
module ProMotion
VERSION = "2.0.0" unless defined?(ProMotion::VERSION)
VERSION = "2.0.0.rc1" unless defined?(ProMotion::VERSION)
end