Garrett Moon
49239f6899
Merge pull request #86 from foursquare/check-nil-url
...
Guard against nil url in category methods
2015-10-28 11:30:53 -07:00
Brian Dorfman
755fb0f253
Remove my name from xcode's auto gen header template
2015-10-28 11:27:22 -07:00
Brian Dorfman
0add2f2846
Remove unnecessary forward declaration
2015-10-28 11:27:22 -07:00
Brian Dorfman
ce61f2d43b
Remove category methods from umbrella header.
...
LLVM's module documentation is a little arcane, but I believe this is the correct syntax to get what we want.
2015-10-28 11:27:22 -07:00
Brian Dorfman
3bc02e3c24
Add a new project for building Carthage framework
2015-10-28 11:27:22 -07:00
Brian Dorfman
836223b241
Guard against nil url in category methods
2015-10-26 17:09:59 -07:00
Garrett Moon
c3ac95ad26
Merge pull request #81 from farhanpatel/farhanpatel-placeholder
...
Placeholder image is set even if url is nil
2015-10-23 15:06:34 -07:00
Garrett Moon
25d83331b0
Add queue name
2015-10-23 14:05:22 -07:00
Garrett Moon
65d9c582fb
Fix a race condition in PINURLSessionManager
...
The callback queue cannot be concurrent because there's no way to guarantee the
operations happen FIFO.
Also fixed an issue where authentication wouldn't happen if the PINURLSessionManager
delegate didn't respond to didReceiveChallenge:
2015-10-23 14:05:22 -07:00
Brian Dorfman
999b5305ec
Only call respondsToSelector once.
2015-10-23 14:05:22 -07:00
Brian Dorfman
52c7463350
Optionally pass full result to category implementor
2015-10-23 14:05:22 -07:00
Garrett Moon
bbc0a9c86f
URLs need to be HTTPs
2015-10-23 11:39:12 -07:00
Farhan Patel
21b3cb197f
Placeholder image is set even if url is nil
...
In the PinRemoteImageCategory if a url is nil but a placeholder is provided the placeholder is removed instead of being set on the UIImage.
2015-10-19 11:02:31 -07:00
Garrett Moon
c7246b3cd0
Merge pull request #75 from foursquare/master
...
Optionally pass full result to category implementor
2015-10-14 16:53:35 -07:00
Brian Dorfman
2106b3c6f4
Only call respondsToSelector once.
2015-10-14 16:48:01 -07:00
Garrett Moon
dc0458ff3e
So, uh,
...
+ (UIImage * _Nonnull)imageWithCGImage:(CGImageRef _Nonnull)cgImage
says it returns a non-nil value but documentation says:
Return Value
A new image object for the specified Quartz image, or nil if the method could not initialize the image from the specified image reference.
So we're guarding against a nil inputImage
2015-10-14 14:40:33 -07:00
Brian Dorfman
4eaf1994e9
Optionally pass full result to category implementor
2015-10-14 12:23:50 -07:00
Adam Speakman
82015fb881
Return image result type of 'None' if no image is downloaded
...
Previously the resultType was being returned
PINRemoteImageResultTypeDownload even when the download failed. Now, we
check to see if the image has been set and if it not then we return
PINRemoteImageResultTypeNone.
2015-10-11 10:21:36 -04:00
Garrett Moon
e1cf9343e4
Merge branch 'master' of https://github.com/kerrmarin/PINRemoteImage into kerrmarin-master
2015-10-06 16:14:46 -07:00
Kurry
21e95bfd82
made changes so FLAnimatedImage is optional and updated PINCache and pod version
2015-10-04 15:07:06 -04:00
Kerr Marin Miller
63749f0122
Remove optional method from image categories
2015-10-04 10:17:46 +01:00
Kerr Marin Miller
fb4d9327f0
Make pin_defaultOptions optional
2015-10-03 10:45:44 +01:00
Sam Dean
c0e74f10eb
Replace @import with #import
2015-09-30 14:39:13 +01:00
Kerr Marin Miller
b0a4289389
Add default PINRemoteImageManagerDownloadOptions for each of the image categories
2015-09-30 11:15:26 +01:00
Garrett Moon
4ba0affc3f
[CIFilter outputImage] can return nil, [CIContext createCGImage:fromRect:] requires a non-nil CIImage as input.
2015-09-28 17:00:16 -07:00
Kurry
d83f9a36b4
updated documentation to say 'Create and Return'
2015-09-13 12:43:38 -04:00
Kurry
b795c4e384
added support for custom http request headers
2015-09-11 23:08:33 -04:00
Bilge Taylan Ulusoy
a3b58bb706
Deleted forgotton nullabel
2015-09-11 22:21:40 +02:00
Bilge Taylan Ulusoy
0229cf1410
authenticationChallenge tests + removed nullable
2015-09-11 19:55:54 +02:00
Bilge Taylan Ulusoy
dfd5a8d67e
Call completionHandler if authenticationChallenge Block is not set
...
Using NSURLSessionAuthChallengePerformDefaultHandling
2015-09-11 11:36:56 +02:00
Bilge Taylan Ulusoy
f321dc4ce4
-didReceiveAuthenticationChallenge:forTask:completionHandler: Implementation
2015-09-11 11:29:33 +02:00
Bilge Taylan Ulusoy
cc47fddd36
Implemented -URLSession:task:didReceiveChallenge:completionHandler: in PINURLSessionManager
2015-09-11 11:27:06 +02:00
Bilge Taylan Ulusoy
03d930064e
Include authentication handling in PINURLSessionManagerDelegate
2015-09-11 11:24:09 +02:00
Bilge Taylan Ulusoy
6ebe4cc42d
Preparing to support authentication challenge handling
2015-09-11 11:20:35 +02:00
Kurry
9765a37f97
initialized error to nil
2015-09-10 18:34:45 -04:00
Kurry
b7f1856d36
fixed issue with 404 response not returning error, and added test for empty url
2015-09-10 17:54:08 -04:00
Kurry
5ebba1967b
fixed issue with error not being set when URL is nil
2015-09-10 15:22:25 -04:00
Garrett Moon
b699bac81a
Merge pull request #49 from pinterest/fixCategoryProcessorCallOffMainThread
...
Pass through all the variables :/
2015-09-03 16:50:22 -07:00
Garrett Moon
0605492fc8
Merge pull request #46 from pinterest/fixProgressRaceCondition
...
Fix race conditions in progress generation
2015-09-03 16:49:37 -07:00
Garrett Moon
7bc11f8ebd
Pass through all the variables :/
2015-09-03 14:23:50 -07:00
Garrett Moon
f2bde95b2a
Readability improvements, thanks Jon!
2015-09-03 14:21:33 -07:00
Garrett Moon
25b2a33444
Remove unused queue. Thanks Kurry Tran!
2015-08-29 15:27:17 -07:00
Garrett Moon
ea8fad0c20
More awesome fixes from Jon
2015-08-27 14:28:34 -07:00
Garrett Moon
578bfd2a28
Cleanup, thanks Jon!
2015-08-27 11:14:42 -07:00
Jon Parise
2f07f44e09
Merge pull request #45 from pinterest/addProgressType
...
add PINRemoteImageResultTypeProgress
2015-08-27 07:37:00 -10:00
Garrett Moon
8d3d37dec2
Passing incorrect error
2015-08-27 07:30:17 -10:00
Garrett Moon
5e3ab338e1
Fix race conditions in progress generation
2015-08-26 13:48:52 -07:00
Garrett Moon
7e6d5e439c
add PINRemoteImageResultTypeProgress
2015-08-26 13:46:26 -07:00
Garrett Moon
ea39f08954
Merge pull request #40 from waltflanagan/Fix39
...
Addresses #39
2015-08-20 06:39:55 -07:00
Mike Simons
0715074f0f
Adding comments for CGImageOrientation enum
...
Until minimum sdk is >= 8.0 we can't use the actual enum
2015-08-17 20:01:27 -04:00
