Marius Landwehr
db1e2be8fd
PINRemoteImageDownloadTask got the same manager problem
2015-12-21 21:35:29 +01:00
Marius Landwehr
22fe19780c
found the weierd bug in PINRemoteImageProcessorTask as well, maybe we should go in deeper…
2015-12-21 21:35:29 +01:00
Marius Landwehr
35abe961d8
PINRemoteImageProcessor is now better with swift
2015-12-21 21:35:29 +01:00
Marius Landwehr
350d3ed0ba
setPriority is not implemented in the PINRemoteImageTask, it should be kicked, but that's maybe another pull request then
2015-12-21 21:35:01 +01:00
Marius Landwehr
a638b89e2f
cancelWithUUID:manager: is a bit weierd because manager is not needed, maybe it's obsolete?
2015-12-21 21:35:01 +01:00
Marius Landwehr
c99735d5e4
added better swift support for PINRemoteImageTask
2015-12-21 21:35:01 +01:00
Marius Landwehr
69d4a27c7b
PINCache is indeed nullable see https://github.com/pinterest/PINRemoteImage/pull/101/files#diff-3c9a124fee465b8e3daf9ca2426d4da4R115
2015-12-21 21:35:00 +01:00
Marius Landwehr
cb29048a63
added more swift nullable, nonnull operators
2015-12-21 21:34:19 +01:00
Marius Landwehr
8921f5e15b
Added swift support for PINURLSessionManager
2015-12-21 21:32:38 +01:00
Marius Landwehr
6da303e715
added swift support for PINRemoteImageManagerResult
2015-12-21 21:32:38 +01:00
Marius Landwehr
e8377d2e21
Added swift support for PINProgressiveImage
2015-12-21 21:32:38 +01:00
Marius Landwehr
e71b9ceecf
PINCache is indeed nullable see https://github.com/pinterest/PINRemoteImage/pull/101/files#diff-3c9a124fee465b8e3daf9ca2426d4da4R115
2015-12-21 21:32:38 +01:00
Marius Landwehr
ead70e87b4
added more swift nullable, nonnull operators
2015-12-21 21:32:38 +01:00
Marius Landwehr
1c73c140ff
added more swift nullable, nonnull operators
2015-12-21 21:31:41 +01:00
Marius Landwehr
93e8edbbe8
cleared a warning for the nonnull extern const of PINRemoteImageManagerErrorDomain
2015-12-21 21:31:41 +01:00
Marius Landwehr
bee20b5887
added better swift support for PINRemoteImageManager.h
2015-12-21 21:31:41 +01:00
Garrett Moon
a19ac9f05b
Merge pull request #105 from bsmith11/addSharedImageManagerConfiguration
...
Support for sharedImageManager with custom configuration
2015-12-15 13:50:34 -08:00
Garrett Moon
b7cace0802
Revert "use NS_EXTENSION_UNAVAILABLE_IOS instead of PIN_APP_EXTENSIONS"
...
This reverts commit 464bb1921c
2015-12-14 14:34:27 -08:00
Garrett Moon
08b5b94573
processor property is unused
2015-12-14 14:33:38 -08:00
Garrett Moon
4922e90adf
Merge pull request #107 from foursquare/session-auth-challenge
...
Fix crash in urlSession authentication challenge.
2015-12-09 10:28:13 -08:00
Garrett Moon
2271a04091
Merge pull request #108 from mRs-/NS_EXTENSION_UNAVAILABLE_IOS
...
use NS_EXTENSION_UNAVAILABLE_IOS instead of PIN_APP_EXTENSIONS
2015-12-09 10:24:54 -08:00
Marius Landwehr
464bb1921c
use NS_EXTENSION_UNAVAILABLE_IOS instead of PIN_APP_EXTENSIONS
2015-12-09 07:47:15 +01:00
Brian Dorfman
21e69bcf80
Fix crash in urlSession authentication challenge.
...
Implement delegate method for when there is a session-level authentication challenge so that the call isn't forwarded to the task version.
Make sure we always strongSelf inside blocks.
2015-12-08 17:32:27 -08:00
Bradley Smith
cc9f900a95
- added sharedImageManager configuration
2015-12-07 16:05:31 -05:00
Garrett Moon
d810d8e2d9
More asserts on timeouts, increase timout for CI
2015-12-05 15:48:56 -08:00
Garrett Moon
f89895d6c6
Merge pull request #104 from pinterest/removeDecodeForProgressive
...
Remove decode for CI progressive images
2015-12-05 14:28:02 -08:00
Garrett Moon
fd6ddbf508
Add assert for error to log webp error which seems to error often on CI
2015-12-05 14:18:47 -08:00
Garrett Moon
75283da491
Add asserts for timeouts so we understand why tests fail
2015-12-05 14:18:47 -08:00
Garrett Moon
77e3fe563a
Need to release image if returning
2015-12-05 14:18:47 -08:00
Garrett Moon
18f09cbff9
Merge pull request #103 from pinterest/addAssertsForTimeouts
...
Add asserts for timeouts so we understand why tests fail
2015-12-05 14:17:52 -08:00
Garrett Moon
3dd13b726a
Add assert for error to log webp error which seems to error often on CI
2015-12-05 13:35:10 -08:00
Garrett Moon
1bac095042
Remove decode for CI progressive images
...
Previously, I'd speculatively decoded images returned from the progressive CIContext
because I'd read that doing so would move the memory from the GPU to the CPU, hopefully
making drawing faster.
I decided to test this hypothesis and by drawing the un-'decoded' image and the image
directly returned from CIContext. Here are some results:
When decoded is drawn before regular
[22486:30240049] decoded - 'regular': 0.000263
[22486:30240097] decoded - 'regular': 0.000242
[22486:30240306] decoded - 'regular': 0.000092
[22486:30240068] decoded - 'regular': 0.000384
[22486:30240096] decoded - 'regular': 0.000111
[22486:30240074] decoded - 'regular': 0.000089
[22486:30240046] decoded - 'regular': 0.000273
[22486:30240351] decoded - 'regular': 0.000250
[22486:30240307] decoded - 'regular': 0.000313
[22486:30240308] decoded - 'regular': 0.000684
[22486:30240307] decoded - 'regular': 0.000485
[22486:30240069] decoded - 'regular': 0.002414
[22486:30240052] decoded - 'regular': 0.000397
[22486:30240049] decoded - 'regular': 0.000293
[22486:30240351] decoded - 'regular': 0.000145
When regular is drawn before decoded
[22610:30246046] decoded - 'regular': 0.000056
[22610:30246030] decoded - 'regular': 0.000473
[22610:30246029] decoded - 'regular': 0.000138
[22610:30246053] decoded - 'regular': 0.000387
[22610:30246030] decoded - 'regular': -0.000006
[22610:30246026] decoded - 'regular': 0.000714
[22610:30246034] decoded - 'regular': 0.000097
[22610:30246621] decoded - 'regular': 0.000039
[22610:30246024] decoded - 'regular': 0.000121
[22610:30246662] decoded - 'regular': -0.000090
[22610:30246030] decoded - 'regular': -0.000057
[22610:30246619] decoded - 'regular': 0.000443
[22610:30246033] decoded - 'regular': 0.001297
[22610:30246623] decoded - 'regular': -0.000020
[22610:30246057] decoded - 'regular': 0.001249
[22610:30246660] decoded - 'regular': 0.000208
[22610:30246659] decoded - 'regular': 0.000048
[22610:30246709] decoded - 'regular': -0.000327
[22610:30246027] decoded - 'regular': 0.000953
[22610:30246025] decoded - 'regular': 0.001228
[22610:30246659] decoded - 'regular': 0.001141
Decoding the image makes little difference and that the difference shows that
the 'decoded' image actually takes longer to draw.
So, we'll save memory and processing time by returning the CGImage from the
context directly as opposed to attempting to decode it.
2015-12-05 13:09:14 -08:00
Garrett Moon
b676b54aa2
Add asserts for timeouts so we understand why tests fail
2015-12-02 17:50:37 -08:00
Garrett Moon
5f47bd8041
Merge pull request #102 from pinterest/fixLeak
...
Need to release image if returning
2015-12-02 11:16:11 -08:00
Garrett Moon
c41b7824dc
Need to release image if returning
2015-12-02 10:25:47 -08:00
Garrett Moon
8f190d90d7
need double quotes
2015-12-01 16:42:15 -08:00
Garrett Moon
c604a16525
try and re-enable iOS 8 testing
2015-12-01 16:32:49 -08:00
Garrett Moon
1cbb1dd3f7
not sure why ordering matters…
2015-12-01 16:14:37 -08:00
Garrett Moon
ad2da81234
specify simulator
2015-12-01 16:10:52 -08:00
Garrett Moon
763a8f4a31
Just try 9.1 for now
2015-12-01 15:59:05 -08:00
Garrett Moon
e1ae08ccc9
Maybe it's this?
2015-12-01 13:32:16 -08:00
Garrett Moon
3795deac14
Don't codesign Tests either
2015-12-01 13:26:40 -08:00
Garrett Moon
fde84c3bf1
Travis didn't like my whitespace
2015-12-01 13:19:04 -08:00
Garrett Moon
baf72008cb
Turn off required code signing
2015-12-01 13:14:55 -08:00
Garrett Moon
52e4cfbd8c
Disable code signing
2015-12-01 13:09:22 -08:00
Garrett Moon
7b5c6b54e9
Remove development team
2015-12-01 13:05:43 -08:00
Garrett Moon
6ea5292c41
Try Xcode 7.1 instead
2015-12-01 12:37:17 -08:00
Garrett Moon
fd3f16c92d
Add iOS 9 testing, drop iOS 7
2015-12-01 12:31:46 -08:00
Garrett Moon
b31ebeb8ee
Switch to Xcode 7
2015-12-01 12:29:17 -08:00
Garrett Moon
623f6fefa5
Merge pull request #99 from pinterest/fixProgressiveCrash
...
CIImage doesn't retain its CGImage :(
2015-11-24 11:50:34 -08:00
