Garrett Moon
c3ac95ad26
Merge pull request #81 from farhanpatel/farhanpatel-placeholder
...
Placeholder image is set even if url is nil
2015-10-23 15:06:34 -07:00
Garrett Moon
3f1ce1c817
Merge pull request #83 from pinterest/fixTestsIniOS9
...
URLs need to be HTTPs
2015-10-23 14:12:17 -07:00
Garrett Moon
25d83331b0
Add queue name
2015-10-23 14:05:22 -07:00
Garrett Moon
65d9c582fb
Fix a race condition in PINURLSessionManager
...
The callback queue cannot be concurrent because there's no way to guarantee the
operations happen FIFO.
Also fixed an issue where authentication wouldn't happen if the PINURLSessionManager
delegate didn't respond to didReceiveChallenge:
2015-10-23 14:05:22 -07:00
Brian Dorfman
999b5305ec
Only call respondsToSelector once.
2015-10-23 14:05:22 -07:00
Brian Dorfman
52c7463350
Optionally pass full result to category implementor
2015-10-23 14:05:22 -07:00
Garrett Moon
d531084aed
Merge pull request #84 from pinterest/fixRaceConditionInURLSessionManager
...
Fix a race condition in PINURLSessionManager
2015-10-23 13:48:37 -07:00
Garrett Moon
6fb56c327f
Add queue name
2015-10-23 13:32:04 -07:00
Garrett Moon
bbc0a9c86f
URLs need to be HTTPs
2015-10-23 11:39:12 -07:00
Garrett Moon
e0fad29d0a
Fix a race condition in PINURLSessionManager
...
The callback queue cannot be concurrent because there's no way to guarantee the
operations happen FIFO.
Also fixed an issue where authentication wouldn't happen if the PINURLSessionManager
delegate didn't respond to didReceiveChallenge:
2015-10-23 11:36:58 -07:00
Farhan Patel
21b3cb197f
Placeholder image is set even if url is nil
...
In the PinRemoteImageCategory if a url is nil but a placeholder is provided the placeholder is removed instead of being set on the UIImage.
2015-10-19 11:02:31 -07:00
Garrett Moon
c7246b3cd0
Merge pull request #75 from foursquare/master
...
Optionally pass full result to category implementor
2015-10-14 16:53:35 -07:00
Brian Dorfman
2106b3c6f4
Only call respondsToSelector once.
2015-10-14 16:48:01 -07:00
Garrett Moon
edf3c8b075
Merge pull request #74 from pinterest/maybeFixProgressiveCrash
...
So, uh,
2015-10-14 14:49:17 -07:00
Garrett Moon
dc0458ff3e
So, uh,
...
+ (UIImage * _Nonnull)imageWithCGImage:(CGImageRef _Nonnull)cgImage
says it returns a non-nil value but documentation says:
Return Value
A new image object for the specified Quartz image, or nil if the method could not initialize the image from the specified image reference.
So we're guarding against a nil inputImage
2015-10-14 14:40:33 -07:00
Brian Dorfman
4eaf1994e9
Optionally pass full result to category implementor
2015-10-14 12:23:50 -07:00
Garrett Moon
da495cd790
Merge pull request #71 from adamsp/correct_resulttype_on_download_failure
...
Return image result type of 'None' if no image is downloaded
2015-10-11 10:15:54 -07:00
Adam Speakman
82015fb881
Return image result type of 'None' if no image is downloaded
...
Previously the resultType was being returned
PINRemoteImageResultTypeDownload even when the download failed. Now, we
check to see if the image has been set and if it not then we return
PINRemoteImageResultTypeNone.
2015-10-11 10:21:36 -04:00
Garrett Moon
ea92ecb754
Up to 1.2.1 to fix podspec issues
2015-10-09 09:46:49 -07:00
Garrett Moon
93d0258680
Merge branch 'kerrmarin-master'
2015-10-06 16:15:07 -07:00
Garrett Moon
e1cf9343e4
Merge branch 'master' of https://github.com/kerrmarin/PINRemoteImage into kerrmarin-master
2015-10-06 16:14:46 -07:00
Garrett Moon
e5ff05eab0
Merge pull request #58 from Kurry/feature/make-flanimatedimage-optional
...
made changes so FLAnimatedImage is optional / updated PINCache / fix issue with tag not updated
2015-10-06 16:11:26 -07:00
Kurry
21e95bfd82
made changes so FLAnimatedImage is optional and updated PINCache and pod version
2015-10-04 15:07:06 -04:00
Kerr Marin Miller
63749f0122
Remove optional method from image categories
2015-10-04 10:17:46 +01:00
Kerr Marin Miller
fb4d9327f0
Make pin_defaultOptions optional
2015-10-03 10:45:44 +01:00
Kerr Marin Miller
01c90a2cd5
Make source tag be the same as the podspec version
2015-10-01 10:41:38 +01:00
Garrett Moon
1c82b99c85
Merge pull request #64 from net-a-porter-mobile/stories/import
...
Replace @import with #import
2015-09-30 15:04:25 -07:00
Sam Dean
c0e74f10eb
Replace @import with #import
2015-09-30 14:39:13 +01:00
Kerr Marin Miller
b0a4289389
Add default PINRemoteImageManagerDownloadOptions for each of the image categories
2015-09-30 11:15:26 +01:00
Garrett Moon
0efb49b1b4
Merge pull request #62 from pinterest/fixCrashInPINProgressiveImage
...
Fix crash in PINProgressiveImage
2015-09-28 17:08:44 -07:00
Garrett Moon
4ba0affc3f
[CIFilter outputImage] can return nil, [CIContext createCGImage:fromRect:] requires a non-nil CIImage as input.
2015-09-28 17:00:16 -07:00
Garrett Moon
dcf1fa695b
Update podspec to 1.2
2015-09-22 10:12:12 -07:00
Garrett Moon
c00f8ffc95
Require PINCache 2.1 for Xcode 7 support.
2015-09-22 10:08:45 -07:00
Jon Parise
ce27752953
Merge pull request #53 from Kurry/feature/support-for-custom-http-request-headers
...
added support for custom http request headers
2015-09-14 08:40:01 -07:00
Kurry
d83f9a36b4
updated documentation to say 'Create and Return'
2015-09-13 12:43:38 -04:00
Kurry
b795c4e384
added support for custom http request headers
2015-09-11 23:08:33 -04:00
Garrett Moon
6fddc34adc
Merge pull request #52 from bulusoy/master
...
Authentication support
2015-09-11 14:35:00 -07:00
Bilge Taylan Ulusoy
a3b58bb706
Deleted forgotton nullabel
2015-09-11 22:21:40 +02:00
Bilge Taylan Ulusoy
0229cf1410
authenticationChallenge tests + removed nullable
2015-09-11 19:55:54 +02:00
Bilge Taylan Ulusoy
dff91d09d3
Added NSAppTransportSecurity for iOS9
...
WARNING, allows all requests!
2015-09-11 19:48:28 +02:00
Bilge Taylan Ulusoy
adb18d2da0
Updated readme (again)
2015-09-11 11:48:21 +02:00
Bilge Taylan Ulusoy
bad75075bc
Updated readme
2015-09-11 11:42:01 +02:00
Bilge Taylan Ulusoy
dfd5a8d67e
Call completionHandler if authenticationChallenge Block is not set
...
Using NSURLSessionAuthChallengePerformDefaultHandling
2015-09-11 11:36:56 +02:00
Bilge Taylan Ulusoy
f321dc4ce4
-didReceiveAuthenticationChallenge:forTask:completionHandler: Implementation
2015-09-11 11:29:33 +02:00
Bilge Taylan Ulusoy
cc47fddd36
Implemented -URLSession:task:didReceiveChallenge:completionHandler: in PINURLSessionManager
2015-09-11 11:27:06 +02:00
Bilge Taylan Ulusoy
03d930064e
Include authentication handling in PINURLSessionManagerDelegate
2015-09-11 11:24:09 +02:00
Bilge Taylan Ulusoy
6ebe4cc42d
Preparing to support authentication challenge handling
2015-09-11 11:20:35 +02:00
Garrett Moon
2c3a2d6885
Merge pull request #51 from Kurry/bugfix/image-not-found-but-error-null
...
Bugfix Image Not Found But Error null
2015-09-10 15:53:10 -07:00
Kurry
9765a37f97
initialized error to nil
2015-09-10 18:34:45 -04:00
Kurry
b7f1856d36
fixed issue with 404 response not returning error, and added test for empty url
2015-09-10 17:54:08 -04:00
