Garrett Moon
29b0b4ac65
Fixes a crash in task callbacks
...
While all methods on tasks are called within the manager's lock,
dispatching to another queue obviously means the manager may not
be locked anymore.
I also moved calling progress download callbacks to the download
task so it's similar to progress image.
Hopefully these issues have been fixed, but it leads me to believe
a better architecture would be to make the tasks immutable by the
manager and have the tasks manage a lock on themselves. I'll need
to think about that more.
2016-02-23 11:01:56 -08:00
Garrett Moon
06485660d2
Fix warning due to int conversion
2016-02-17 16:00:41 -08:00
Garrett Moon
d23487c57e
That would have been bad.
2016-02-17 13:43:01 -08:00
Garrett Moon
5f609a7cde
Remove load and instead make supportsQOS method. Thanks @appleguy!
2016-02-17 13:43:01 -08:00
Garrett Moon
ed5fa6af52
We only need to check respondsToSelector once and set QOS on queue, not each operation.
2016-02-17 13:43:01 -08:00
Garrett Moon
b57161ddcb
Callback on callback queue
2016-02-10 18:20:55 -08:00
Garrett Moon
ae91afe047
Merge branch 'feature/add-download-progress' of https://github.com/maicki/PINRemoteImage into maicki-feature/add-download-progress
2016-02-10 18:16:45 -08:00
Michael Schneider
c2a5f4220b
Call PINRemoteImageDownloadTask callback blocks outside the PINRemoteImageManager lock
...
We call the callback blocks outside the lock that way blocking the callback won't lock up PINRemoteImageManager.
2016-02-10 14:36:25 -08:00
Michael Schneider
07b779eb4b
Rename PINRemoteImageManagerDownloadProgress to PINRemoteImageManagerProgressDownload
2016-02-10 14:23:57 -08:00
Michael Schneider
5d5dada353
Rename downloadProgress: to progressDownload:
2016-02-10 14:13:56 -08:00
Michael Schneider
e2f8f67c1d
Change progress block name to progressImage
2016-02-10 13:54:00 -08:00
Garrett Moon
dd3738bc4a
Priority is only available on iOS 8 and above.
2016-02-09 15:31:18 -08:00
Michael Schneider
da255a576c
Add optional block to track download progress of image
2016-02-08 20:28:29 -08:00
Garrett Moon
ec0fa5b85a
Remove deprecated methods in preperation for 2.0
2016-02-08 17:02:30 -08:00
Adlai Holler
0ef39a8b7f
Make WebP + CocoaPods + use_frameworks! work again
2016-02-05 15:35:09 -08:00
Garrett Moon
ff59acafa4
Allow setting of progress block to add or cancel updates
2016-02-03 12:59:44 -08:00
Garrett Moon
997c747bf1
Merge branch 'add-generics-for-image-url-arrays' of https://github.com/rounak/PINRemoteImage into rounak-add-generics-for-image-url-arrays
2016-02-02 14:28:00 -08:00
rounak
6a90410322
Add generics to collections
2016-02-01 22:19:51 -08:00
Michael Schneider
f18c250f3e
Merge branch 'master' into feature/osx-support
2016-01-30 16:33:15 -08:00
Garrett Moon
1c17ece5e6
missed nullability specifier
2016-01-25 14:29:43 -08:00
Garrett Moon
bcb0bd9fc2
Allow maximum progressive render size to be set
2016-01-25 10:53:29 -08:00
Garrett Moon
f8671046d0
Return if radius will be less than FLT_EPSILON
2016-01-25 10:31:07 -08:00
Garrett Moon
1ee0d2563a
cleanup
2016-01-25 10:31:07 -08:00
Garrett Moon
38436d021a
Remove unneeded notification removal
2016-01-25 10:31:07 -08:00
Garrett Moon
c98d5626f2
Switch to Accelerate for blurring
...
Core Image crashes were still showing up in our stack traces
even after many speculative fixes. Lets see if accelerate does
better.
2016-01-25 10:31:07 -08:00
Garrett Moon
873e26a183
Allow blurring of progressive to be disabled
2016-01-22 14:14:17 -08:00
Garrett Moon
561251adb9
After continually seeing crashes on createCGImage:fromRect: I'm ready
...
to try some speculative fixes. This moves the rendering to a serial queue
A bit disappointing, this will be reverted if it doesn't address the crashes.
If it does… well, we'll have more to work on.
2016-01-19 12:38:37 -08:00
Garrett Moon
971049b47a
Merge pull request #101 from mRs-/better-swift-support
...
Better swift support for optionals
2016-01-15 11:40:02 -08:00
Marius Landwehr
3e385dc0c9
switched nonnull to nullable on pin_setDownloadImageOperation for NSUUID and for the deprecated method
2016-01-15 07:33:41 +01:00
Marius Landwehr
bd9006d86e
rework on PINURLSessionManager
2016-01-12 21:46:54 +01:00
Marius Landwehr
d283377b0d
added better swift support for deprecated methods
2016-01-12 21:46:44 +01:00
Michael Schneider
cd20716750
Fix using NSGraphicsContext in creating a CGImage in NSImage category
2016-01-06 14:58:34 +01:00
Michael Schneider
8df9dc00c6
Add support for OS X to library
...
Mapping generic classes like PINImage, PINImageView and PINButton to the equivalent UIKit or AppKit classes. Throughout the framework use these mappings instead of the concrete UIKit / AppKit names. Furthermore we provide a category on NSImage that is adding methods that are not available on NSImage but on UIImage.
2016-01-04 17:39:50 +01:00
Michael Schneider
9b8b0afc6d
Pass through setUpdateWithProgress: value to prefixed property
...
Fixes the setUpdateWithProgress: method that currently calls itself instead of passing the value through to the prefixed pin_updateWithProgress property. This results into a infinite loop and a crash.
2016-01-04 14:56:29 +01:00
Marius Landwehr
a5e36046bc
Removed the warnings and create an issue for this.
2015-12-21 21:35:30 +01:00
Marius Landwehr
0cd4a176a3
Did some rework from the feedback on the pull request
2015-12-21 21:35:29 +01:00
Marius Landwehr
b016ecdc25
added swift support for the CategoryManager
...
I skipped the deprecations because, they are deprecated and we hope no one is using them any more in swift anyway
2015-12-21 21:35:29 +01:00
Marius Landwehr
337027351e
added better swift support for UIImage+DecodedImage
2015-12-21 21:35:29 +01:00
Marius Landwehr
ac3f85deae
added better swift support to PINDataTaskOperation
2015-12-21 21:35:29 +01:00
Marius Landwehr
377944a1be
swift support for PINRemoteImageCallbacks
2015-12-21 21:35:29 +01:00
Marius Landwehr
0502a63081
better swift support for PINRemoteImageDownloadTask
2015-12-21 21:35:29 +01:00
Marius Landwehr
db1e2be8fd
PINRemoteImageDownloadTask got the same manager problem
2015-12-21 21:35:29 +01:00
Marius Landwehr
22fe19780c
found the weierd bug in PINRemoteImageProcessorTask as well, maybe we should go in deeper…
2015-12-21 21:35:29 +01:00
Marius Landwehr
35abe961d8
PINRemoteImageProcessor is now better with swift
2015-12-21 21:35:29 +01:00
Marius Landwehr
350d3ed0ba
setPriority is not implemented in the PINRemoteImageTask, it should be kicked, but that's maybe another pull request then
2015-12-21 21:35:01 +01:00
Marius Landwehr
a638b89e2f
cancelWithUUID:manager: is a bit weierd because manager is not needed, maybe it's obsolete?
2015-12-21 21:35:01 +01:00
Marius Landwehr
c99735d5e4
added better swift support for PINRemoteImageTask
2015-12-21 21:35:01 +01:00
Marius Landwehr
69d4a27c7b
PINCache is indeed nullable see https://github.com/pinterest/PINRemoteImage/pull/101/files#diff-3c9a124fee465b8e3daf9ca2426d4da4R115
2015-12-21 21:35:00 +01:00
Marius Landwehr
cb29048a63
added more swift nullable, nonnull operators
2015-12-21 21:34:19 +01:00
Marius Landwehr
8921f5e15b
Added swift support for PINURLSessionManager
2015-12-21 21:32:38 +01:00
