Adlai Holler
af7bfe3f59
Revert "Fix raw value for .None option"
...
This reverts commit 897fd4c55f
2015-11-23 13:49:59 -08:00
Adlai Holler
897fd4c55f
Fix raw value for .None option
2015-11-22 10:49:15 -08:00
Garrett Moon
61bc84c940
Merge pull request #98 from pinterest/protectAgainstMaxContextSize
...
Respect the maximum size of CIContexts
2015-11-20 18:16:21 -08:00
Garrett Moon
b52d4a867a
Improve readability
2015-11-20 18:11:23 -08:00
Garrett Moon
db588e49cc
Respect the maximum size of CIContexts
2015-11-20 18:04:01 -08:00
Adlai Holler
bace9ce8d6
Remove explicit options values
2015-11-20 15:53:04 -08:00
Adlai Holler
5fadcb46d0
Use NS_OPTIONS for PINRemoteImageManagerDownloadOptions
2015-11-20 15:24:57 -08:00
Connor Montgomery
022b554b7b
Merge pull request #95 from connor/http
...
Fix for local image URLs throwing an error.
2015-11-09 13:04:37 -05:00
Connor Montgomery
213ce3cb14
fix test
2015-11-09 13:00:05 -05:00
Connor Montgomery
1fcc55c296
check class instead
2015-11-09 12:23:08 -05:00
Connor Montgomery
5884bc29cc
Don't cast .
2015-11-09 12:11:33 -05:00
Connor Montgomery
dbf05ce687
Fix for local image URLs
2015-11-09 12:00:27 -05:00
Garrett Moon
5702efdb64
Fix degraded view controller on iOS 9
2015-11-06 09:54:06 -08:00
Garrett Moon
eef725a0e2
Merge pull request #88 from pinterest/addBadges
...
Add badges
2015-11-03 10:57:19 -08:00
Garrett Moon
52c0ea15d2
CocoaPods support is a little more tried and tested, putting it first
2015-11-03 10:56:23 -08:00
Garrett Moon
d9021cb007
Add CocoaPods and Tavis CI Badges
2015-11-03 10:54:45 -08:00
Garrett Moon
1105926e27
Updating podspec for 1.2.2 release
2015-11-03 10:34:01 -08:00
Garrett Moon
49239f6899
Merge pull request #86 from foursquare/check-nil-url
...
Guard against nil url in category methods
2015-10-28 11:30:53 -07:00
Garrett Moon
a1faca7a3d
Update pods
2015-10-28 11:27:23 -07:00
Brian Dorfman
823002b734
Update installation instructions in readme.
...
Add carthage instructions and provide a bit more info on manual installation.
Also move cocoapods and carthage sections above manual since they are preferred.
2015-10-28 11:27:22 -07:00
Brian Dorfman
755fb0f253
Remove my name from xcode's auto gen header template
2015-10-28 11:27:22 -07:00
Brian Dorfman
0add2f2846
Remove unnecessary forward declaration
2015-10-28 11:27:22 -07:00
Brian Dorfman
ce61f2d43b
Remove category methods from umbrella header.
...
LLVM's module documentation is a little arcane, but I believe this is the correct syntax to get what we want.
2015-10-28 11:27:22 -07:00
Brian Dorfman
66a889e061
Remove xcscmblueprint and update gitignore
2015-10-28 11:27:22 -07:00
Brian Dorfman
3bc02e3c24
Add a new project for building Carthage framework
2015-10-28 11:27:22 -07:00
Brian Dorfman
836223b241
Guard against nil url in category methods
2015-10-26 17:09:59 -07:00
Garrett Moon
c3ac95ad26
Merge pull request #81 from farhanpatel/farhanpatel-placeholder
...
Placeholder image is set even if url is nil
2015-10-23 15:06:34 -07:00
Garrett Moon
3f1ce1c817
Merge pull request #83 from pinterest/fixTestsIniOS9
...
URLs need to be HTTPs
2015-10-23 14:12:17 -07:00
Garrett Moon
25d83331b0
Add queue name
2015-10-23 14:05:22 -07:00
Garrett Moon
65d9c582fb
Fix a race condition in PINURLSessionManager
...
The callback queue cannot be concurrent because there's no way to guarantee the
operations happen FIFO.
Also fixed an issue where authentication wouldn't happen if the PINURLSessionManager
delegate didn't respond to didReceiveChallenge:
2015-10-23 14:05:22 -07:00
Brian Dorfman
999b5305ec
Only call respondsToSelector once.
2015-10-23 14:05:22 -07:00
Brian Dorfman
52c7463350
Optionally pass full result to category implementor
2015-10-23 14:05:22 -07:00
Garrett Moon
d531084aed
Merge pull request #84 from pinterest/fixRaceConditionInURLSessionManager
...
Fix a race condition in PINURLSessionManager
2015-10-23 13:48:37 -07:00
Garrett Moon
6fb56c327f
Add queue name
2015-10-23 13:32:04 -07:00
Garrett Moon
bbc0a9c86f
URLs need to be HTTPs
2015-10-23 11:39:12 -07:00
Garrett Moon
e0fad29d0a
Fix a race condition in PINURLSessionManager
...
The callback queue cannot be concurrent because there's no way to guarantee the
operations happen FIFO.
Also fixed an issue where authentication wouldn't happen if the PINURLSessionManager
delegate didn't respond to didReceiveChallenge:
2015-10-23 11:36:58 -07:00
Farhan Patel
21b3cb197f
Placeholder image is set even if url is nil
...
In the PinRemoteImageCategory if a url is nil but a placeholder is provided the placeholder is removed instead of being set on the UIImage.
2015-10-19 11:02:31 -07:00
Garrett Moon
c7246b3cd0
Merge pull request #75 from foursquare/master
...
Optionally pass full result to category implementor
2015-10-14 16:53:35 -07:00
Brian Dorfman
2106b3c6f4
Only call respondsToSelector once.
2015-10-14 16:48:01 -07:00
Garrett Moon
edf3c8b075
Merge pull request #74 from pinterest/maybeFixProgressiveCrash
...
So, uh,
2015-10-14 14:49:17 -07:00
Garrett Moon
dc0458ff3e
So, uh,
...
+ (UIImage * _Nonnull)imageWithCGImage:(CGImageRef _Nonnull)cgImage
says it returns a non-nil value but documentation says:
Return Value
A new image object for the specified Quartz image, or nil if the method could not initialize the image from the specified image reference.
So we're guarding against a nil inputImage
2015-10-14 14:40:33 -07:00
Brian Dorfman
4eaf1994e9
Optionally pass full result to category implementor
2015-10-14 12:23:50 -07:00
Garrett Moon
da495cd790
Merge pull request #71 from adamsp/correct_resulttype_on_download_failure
...
Return image result type of 'None' if no image is downloaded
2015-10-11 10:15:54 -07:00
Adam Speakman
82015fb881
Return image result type of 'None' if no image is downloaded
...
Previously the resultType was being returned
PINRemoteImageResultTypeDownload even when the download failed. Now, we
check to see if the image has been set and if it not then we return
PINRemoteImageResultTypeNone.
2015-10-11 10:21:36 -04:00
Garrett Moon
ea92ecb754
Up to 1.2.1 to fix podspec issues
2015-10-09 09:46:49 -07:00
Garrett Moon
93d0258680
Merge branch 'kerrmarin-master'
2015-10-06 16:15:07 -07:00
Garrett Moon
e1cf9343e4
Merge branch 'master' of https://github.com/kerrmarin/PINRemoteImage into kerrmarin-master
2015-10-06 16:14:46 -07:00
Garrett Moon
e5ff05eab0
Merge pull request #58 from Kurry/feature/make-flanimatedimage-optional
...
made changes so FLAnimatedImage is optional / updated PINCache / fix issue with tag not updated
2015-10-06 16:11:26 -07:00
Kurry
21e95bfd82
made changes so FLAnimatedImage is optional and updated PINCache and pod version
2015-10-04 15:07:06 -04:00
Kerr Marin Miller
63749f0122
Remove optional method from image categories
2015-10-04 10:17:46 +01:00
