mirror of
https://github.com/tappollo/IGListKit.git
synced 2026-01-12 22:45:13 +08:00
b71c346f66
Summary:  Noticed an issue when trying to build the examples project that I couldn't because of the Swiftlint build phase (see the image above) As it turns out in between the version I have installed (0.16.1) and the latest (0.19.0) they've made it so you can drop `lint` from the command (which is the default task). I see two options really: 1. We add `lint` to the command which at least lets older versions of Swiftlint compile the project without making changes to run phases. It's worth noting that this means that certain (newer) rules won't be detected. 2. We add a way of detecting if they have an older version (likely by comparing the output of `$(swiftlint version)` to the version we know it works on. And display a more appropriate message and not fail the build. Happy to discuss this heshamsalman jessesquires rnystrom Closes https://github.com/Instagram/IGListKit/pull/796 Differential Revision: D5137557 Pulled By: rnystrom fbshipit-source-id: b6c85197d7a66e37976d66b646c9c9241827ce42
