Files
IGListKit/Dangerfile
Hesham Salman a5d5213e5b Update Dangerfile to be less noisy, close #792
Summary:
Issue fixed: #792

- [ ] All tests pass. Demo project builds and runs.
- [ ] I added tests, an experiment, or detailed why my change isn't tested.
- [ ] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [ ] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/795

Differential Revision: D5132076

Pulled By: rnystrom

fbshipit-source-id: 7d68f842e0244d6c6184982ee434dc4da22cc7c6
2017-05-25 13:46:06 -07:00

24 lines
907 B
Ruby

not_declared_trivial = !(github.pr_title.include? "#trivial")
has_source_changes = !git.modified_files.grep(/Source/).empty?
# Make it more obvious that a PR is a work in progress and shouldn't be merged yet
warn("PR is classed as Work in Progress") if github.pr_title.include? "[WIP]"
# Warn when there is a big PR
warn("Big PR") if git.lines_of_code > 500
# Changelog entries are required for changes to library files.
no_changelog_entry = !git.modified_files.include?("CHANGELOG.md")
if has_source_changes && no_changelog_entry && not_declared_trivial && git.lines_of_code > 10
fail("Any source code changes should have an entry in CHANGELOG.md.")
end
# Docs are regenerated when releasing
has_doc_changes = !git.modified_files.grep(/docs\//).empty?
if has_doc_changes
warn("Docs are regenerated when creating new releases.")
end
swiftlint.config_file = '.swiftlint_CI.yml'
swiftlint.lint_files