kylefang/IGListKit
1
0
Fork 0
mirror of https://github.com/tappollo/IGListKit.git synced 2026-06-13 00:18:47 +08:00
Code Issues Packages Projects Releases Wiki Activity

consistent use of finall class

Browse Source 
Summary:
You are already using `final class` as the default swift declaration as I guess most people agree this is best practice for classes you are not planning to inherit from :) So I just made the example code more consistent.

I will not add much more reasoning to why, other than open source projects like this is a _big_ inspirations and starting ground to play with swift for new develoeprs joining the iOS community. Nuding them to ask the right questions (composition vs inheritance) early could only be a good thing (?)

- [X] All tests pass. Demo project builds and runs.
- [X] No new tests. No new classes.
- [X] No breaking changes.
- [X] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/master/.github/CONTRIBUTING.md)
Closes https://github.com/Instagram/IGListKit/pull/539

Differential Revision: D4696591

Pulled By: rnystrom

fbshipit-source-id: 73539b907452ec0cb7a8e842a95cb4fd27138f2f
This commit is contained in:
Nikolai Johan Heum
2017-03-12 13:12:23 -07:00
committed by Facebook Github Bot
parent 139507325c
commit a7855d15ac
15 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Examples/Examples-iOS/IGListKitExamples/ViewControllers/DisplayViewController.swift
View File

@@ -15,7 +15,7 @@
import UIKit
import IGListKit
class DisplayViewController: UIViewController, IGListAdapterDataSource {
final class DisplayViewController: UIViewController, IGListAdapterDataSource {
lazy var adapter: IGListAdapter = {
return IGListAdapter(updater: IGListAdapterUpdater(), viewController: self, workingRangeSize: 0)