78 Commits

Author SHA1 Message Date
Ryan Nystrom
0001920b75 Refactor text styles to use StyledText (#1490) 2018-02-04 19:09:42 -05:00
Bas Broek
6075edcee5 Add "Jump to..." to make an action sheet more expressive (#1405) 2018-01-13 17:21:32 -05:00
Ryan Nystrom
cb15bc47c8 use new dropdown for browsing files (#1400) 2018-01-13 16:37:29 -05:00
Ryan Nystrom
755be5af2e Refactor autocomplete control and wire it up in comment editing (#1326)
* refactor text view delegate to be 1:many

* move autocomplete stuff to its own controller + API

* refactor VC to work with new autocomplete controller

* update pods with new message stuff

* reorganize and fixup files

* app builds

* better names

* thread autocomplete to comment SC

* autocomplete working in edit

* finish refactor
2018-01-02 09:14:28 -05:00
Ryan Nystrom
29f7f67ff8 View notifications by repository (#1291)
* get subscriptions api

* stub subscription ctrl

* use icon bar items, inject inbox type

* wire up repo list

* push notif, show all for repos

* clean path

* fix spinner bar item bugs

* call correct mark-read apis

* alert titles

* sort repos by alpha

* unify show-all callsite

* nits
2017-12-19 10:11:59 -05:00
Ryan Nystrom
20e1b6f6df Design polish (#1275)
* new tab icon design

* more spacing for action cells

* action cells larger, background colors

* fix assignee/reviewer spacing

* label colors, refine header spacing

* bump up label radius

* add close and lock options

* wire up close mutation

* wire up lock

* remove dead code
2017-12-17 16:09:26 -05:00
Bas Broek
0db76b3b76 Add + update a11x for navigation titles (#1257)
* Add + update a11x for navigation items

* A file is not a file extension
2017-12-16 22:15:29 -05:00
Bas Broek
7f04139794 Disable animations when reduce motion enabled (#1167) 2017-12-10 18:15:44 -05:00
Ryan Nystrom
7a60f6a4a0 auto shrink title label (#1169) 2017-12-03 16:59:52 -05:00
Ryan Nystrom
270903e1ae refactor dir and blob paths, add tests (#1165) 2017-12-03 16:36:43 -05:00
Ryan Nystrom
50b6ed7581 actually show an empty state on base list vc (#1140) 2017-12-02 19:16:27 -05:00
Bas Broek
872da1f458 [Cleanup] Remove nil-default completion parameters (#1131)
* Remove nil-default completion parameters

* Remove redundant character trimming
2017-12-02 18:48:32 -05:00
Ryan Nystrom
3724798277 Convert repo code browsing to base VC and IGLK (#1097) 2017-11-27 13:08:44 -05:00
James Sherlock
a504a87033 Use AttributedStringCell for IssueLabeledCell (#1071)
* Use AttributedStringCell for IssueLabeledCell

* Code review changes
2017-11-26 12:31:27 -05:00
Ryan Nystrom
a313f6e110 reference commit cells use attr string cell (#1068) 2017-11-23 11:30:06 -05:00
Joe Rocca
ca9c9df1df Tightened right bar items (#916)
* tightened right bar items, closes #896

* added UIBarButtonItem and UIPopoverPresentationController extensions
2017-11-10 12:39:40 -05:00
Hesham Salman
1e2e0c1698 Chore/bookmark rewrite (#865)
* Unified store behavior, new bookmark model

- Added a `Store` protocol to the project with default implementations
  that should be sufficient for most models. (#855)
- Switched images in the notification type category to #imageLiterals,
  so we can avoid the optionality of the image.

* Implemented BookMark ViewModel

* Created Bookmark Collection Cell

* Created Bookmark View Controller

Done:
  - Displays empty state
  - Displays bookmarks
  - Allows for adding of new bookmarks
  - Navigating to bookmarks

In flight:
  - Clear All

TODO:
  - Search
  - Cleanup old files & remove SwipeCell hacks

* Unified search and clear all behavior

The search bar and clear all buttons between the search and bookmarks
page had different styles and behavior. This PR:
  - Makes a generic clear-all header
  - Gives one to each VC
  - Makes them behave the same to the user re: visibility etc

* Re-implemented filter

* Deleted old files

* Attributed String Sizing

* Removed bookmark store tests

* Reloading bookmarks & namespacing

Can now reload bookmarks through the listener pattern (#773, #783).
Bookmark store is now correctly namespaced again.
2017-11-06 09:03:29 -05:00
Ryan Nystrom
2ca2cfb9dc Better FlatCache usage in notifications (#795)
* Better FlatCache usage in notifications

* fix paging bug on notifications
2017-10-31 21:31:20 -07:00
Ryan Nystrom
0dd568396a Add title/subtitle header style and use for Issues (#761) 2017-10-27 10:46:18 -04:00
Ryan Nystrom
8276fc5492 Bookmark tab icons (#727)
* Bookmark tab icons

* tweak so inner star is slightly smaller
2017-10-24 23:46:17 -04:00
Bas Broek
073fab0bde Merge branch 'master' into text-fixes 2017-10-24 05:43:22 +02:00
Hesham Salman
f213bac924 Thin SwiftLint ruleset (#704)
* Thin SwiftLint ruleset

* Disabled trailing_whitespace rule
2017-10-23 16:58:09 -04:00
Bas Broek
359794debf Some general text improvements 2017-10-22 22:49:52 +02:00
Hesham Salman
ad6caa286d Swapped Bar Button Items (#644)
Catpitalization
2017-10-22 14:01:18 -04:00
Rizwan Mohamed Ibrahim
bd10b4e032 Add Bookmarks tab (#601)
* [ADD] Bookmarks for repo, issues and pull request

* [FIX] Bookmark model decoding from archive

* [ADD] Clear all option for bookmarks

* [ADD] Search bookmarks with search bar

* [ADD] Swipe to delete for bookmarks (only when search bar is not active)

* [ADD] Bookmark cell accessible and some cleanup

* [ADD] Incorporate review comments

* [ADD] Reuse notification type instead of bookmark type

* [ADD] Incorporate review comments
- Enum over struct on bookmark model
- Github bookmark tab icon
- Smooth deselection, Single tap to scroll to top, cleanup
-
2017-10-22 14:00:50 -04:00
Ryan Nystrom
5bae4ba89d [WIP] Add FlatCache lib and use for Notifications (#632)
* init FlatCache lib

* tests for all other cases

* install flatcache to freeitme project, move VM creation into client

* refactor and split up inbox design

* fixup flatcache pod
2017-10-22 00:08:42 -04:00
Bas Broek
980fba6cc0 Move some hardcoded "Search"es to Constants (#616) 2017-10-21 20:35:57 -04:00
Ryan Nystrom
357e7e1bde Finish wiring up edit comments (#594) 2017-10-18 12:14:17 -04:00
Ryan Nystrom
deb937ef00 only filter notifications at end so inbox zero doesnt show up on empty results 2017-10-14 12:11:43 -04:00
Ryan Nystrom
40dfd85e7b notification VMs use filter method 2017-10-14 12:06:36 -04:00
Ryan Nystrom
a58c26836d add filtering to base list VC 2017-10-14 11:56:23 -04:00
Weyert de Boer
6779557f22 Add search to issues (#506)
* Added the generic SearchBar section controller
Added a helper method for searching notifications

* Strip the unwanted characters from the search query

* Add a first version of searching issues in Repository screen

* Improve the search for the Repository screen

* Improve the filtering of issues by changing the order

* Fixed the compiling issues to make the project compile again
2017-10-14 11:11:07 -04:00
Weyert de Boer
1ffda90eae Renamed Strings.swift to Constants.swift (#517)
* Renamed `Strings.swift` to `Constants.swift`, fixes #498
Added the product urls to `Constants.swift`, partly fixes #494

* Wrapped the strings in a `Strings`-enum

* Really shouldn't manually retype things

* Update project.pbxproj
2017-10-14 11:06:25 -04:00
Ryan Nystrom
cfd93c14a0 resuable cancel action, text view config, MD actions menu and control, init edit comments 2017-10-08 20:53:40 +01:00
Ryan Nystrom
30c758b4ac new base list VC, refactor repo issues, fixes #493 2017-10-05 22:37:40 +01:00
Ryan Nystrom
dbcee5d343 double tap search tab to focus search bar, fixes #424 2017-09-26 21:23:27 -04:00
Ryan Nystrom
c1d80c7a37 scroll to top of inbox when tapping tab once, fixes #285 2017-09-26 20:12:39 -04:00
Ryan Nystrom
9cb36a13e3 move tab hiding to issue vc, fixes #370 2017-09-26 18:08:45 -04:00
James Sherlock
f40557eeaf Native Create Issue (#311)
* Add a "Create Issue" view controller, Hook up networking, Enable bug reporting

* Add create issue button to all repos

* Fix navigation for tablet, Add markdown controls view

* Remove new issue button if issues are not enabled

* Add localization for new issue text

* Update scrollView insets on keyboard, Add slight background

* More style changes, moved preview to it's own button, expanding text view, return takes you to next field

* Update bug report repository

* Design changes

* Add markdown controls to new issue
2017-09-25 11:24:14 -04:00
Bas Broek
ac94168de0 Add handoff support for issues (#331)
* Add handoff support for issues

* Update Info.plist
2017-09-25 10:36:07 -04:00
Dylan Lewis
a3276615d5 [413] Use shared colours for standard UI components (#421)
* Update UISwitch on tint color

Align green with shared color

* Update tintColor of all UIAlertControllers

* Create factory for SFSafariViewController

* Update SFSafariViewController tint color

Only in the .configured factory

* Use SFSafariViewController factory everywhere

* Create factory for UIAlertController

* Use UIAlertController factory everywhere
2017-09-24 18:32:32 -04:00
Ryan Nystrom
d6219f05e3 hide tab bar when collapsing on some VCs, fixes #296 2017-09-10 16:10:44 -04:00
Ryan Nystrom
7bec0c4288 split VC delegate tests, fixes #297 2017-09-10 15:57:24 -04:00
Ryan Nystrom
d83fff055c notifications now inbox 2017-09-05 23:19:59 -04:00
Ryan Nystrom
69445ff8a3 email interaction handling, thread text delegate down to table cells 2017-09-05 22:31:57 -04:00
Ryan Nystrom
4fe95bbc25 custom tab bar icons 2017-09-04 11:57:34 -04:00
Ryan Nystrom
77f57ffd8d fix infi loop bug in split VC expansion handling 2017-09-03 17:41:59 -04:00
Ryan Nystrom
f5a7d8e487 move settings to tab 2017-09-02 17:33:54 -04:00
Ryan Nystrom
f54be54b7b pop instead of set VCs, more comments 2017-09-01 13:21:50 -04:00
Ryan Nystrom
22bad56156 fixup nav and add comments 2017-09-01 11:45:10 -04:00