* create new nav view
* issue nav title wired up
* more button now system action
* better sized bookmark assets
* wire up title actions on repo
* tweak compression UI
* revert helper hack
* Use even more shared code for bookmarks in nav bar
* correct selected/not logic
* restore image changing in action
* add haptics
* swap actions between add and remove
* Add Bookmark nav items
* [ADD] Bookmark actions to nav right item and remove bookmark alert action
* [ADD] Bookmark nav right item for Repo and remove bookmark alert action
* [CHOR] Clean up old bookmark alert action
* [ADD] Shared function for toggling bookmark
* Unified store behavior, new bookmark model
- Added a `Store` protocol to the project with default implementations
that should be sufficient for most models. (#855)
- Switched images in the notification type category to #imageLiterals,
so we can avoid the optionality of the image.
* Implemented BookMark ViewModel
* Created Bookmark Collection Cell
* Created Bookmark View Controller
Done:
- Displays empty state
- Displays bookmarks
- Allows for adding of new bookmarks
- Navigating to bookmarks
In flight:
- Clear All
TODO:
- Search
- Cleanup old files & remove SwipeCell hacks
* Unified search and clear all behavior
The search bar and clear all buttons between the search and bookmarks
page had different styles and behavior. This PR:
- Makes a generic clear-all header
- Gives one to each VC
- Makes them behave the same to the user re: visibility etc
* Re-implemented filter
* Deleted old files
* Attributed String Sizing
* Removed bookmark store tests
* Reloading bookmarks & namespacing
Can now reload bookmarks through the listener pattern (#773, #783).
Bookmark store is now correctly namespaced again.
* [ADD] Bookmarks for repo, issues and pull request
* [FIX] Bookmark model decoding from archive
* [ADD] Clear all option for bookmarks
* [ADD] Search bookmarks with search bar
* [ADD] Swipe to delete for bookmarks (only when search bar is not active)
* [ADD] Bookmark cell accessible and some cleanup
* [ADD] Incorporate review comments
* [ADD] Reuse notification type instead of bookmark type
* [ADD] Incorporate review comments
- Enum over struct on bookmark model
- Github bookmark tab icon
- Smooth deselection, Single tap to scroll to top, cleanup
-
* Move duplicate share UIAlertActions to AlertActions struct #359
Create helper AlertActions struct for convenient UIAlertAction's instantiation.
* Create AlertActionBuilder #359
The AlertActionBuilder is used to create custom UIAlertAction's with constituent parts.
* Create UIAlertController+Action #359
UIAlertController+Action extension provide a convinient way for adding actions into the UIAlertController.
* Move additional UIAlertAction duplicates into AlertAction #359
* NewIssueTableViewController: Use correct titles for alert actions #359
Use "Go back" and "Discard" titles instead of "No" and "Yes".
* IssueCommentSectionController: Refactor alert actions #359
* SettingsViewController: Refactor onSignOut alert actions #359
* Add a "Create Issue" view controller, Hook up networking, Enable bug reporting
* Add create issue button to all repos
* Fix navigation for tablet, Add markdown controls view
* Remove new issue button if issues are not enabled
* Add localization for new issue text
* Update scrollView insets on keyboard, Add slight background
* More style changes, moved preview to it's own button, expanding text view, return takes you to next field
* Update bug report repository
* Design changes
* Add markdown controls to new issue
* Update UISwitch on tint color
Align green with shared color
* Update tintColor of all UIAlertControllers
* Create factory for SFSafariViewController
* Update SFSafariViewController tint color
Only in the .configured factory
* Use SFSafariViewController factory everywhere
* Create factory for UIAlertController
* Use UIAlertController factory everywhere