Commit Graph

66 Commits

Author SHA1 Message Date
Ryan Nystrom
0001920b75 Refactor text styles to use StyledText (#1490) 2018-02-04 19:09:42 -05:00
Rizwan Mohamed Ibrahim
99989c3b8b [FIX] Remove user name action from repo view (#1410) 2018-01-14 12:11:32 -05:00
Ryan Nystrom
ca3bc322a7 New navigation title dropdown control (#1399)
* create new nav view

* issue nav title wired up

* more button now system action

* better sized bookmark assets

* wire up title actions on repo

* tweak compression UI

* revert helper hack
2018-01-13 15:54:20 -05:00
Dragiša Spasojević
09f0ba6ff5 Remove unused code 2017-12-17 18:33:45 +01:00
Bas Broek
0db76b3b76 Add + update a11x for navigation titles (#1257)
* Add + update a11x for navigation items

* A file is not a file extension
2017-12-16 22:15:29 -05:00
Ryan Nystrom
8e30bacb81 master repo VC background is white (#1214) 2017-12-11 09:04:03 -05:00
Bas Broek
7f04139794 Disable animations when reduce motion enabled (#1167) 2017-12-10 18:15:44 -05:00
Bas Broek
0ccf2d0ca7 Add repo+author name to action sheet, title accessibility (#1120) 2017-12-02 11:26:37 -05:00
Ryan Nystrom
3724798277 Convert repo code browsing to base VC and IGLK (#1097) 2017-11-27 13:08:44 -05:00
Ryan Nystrom
00414833fd local Tabman to fix inset issues (#923) 2017-11-11 21:53:12 -05:00
Joe Rocca
ca9c9df1df Tightened right bar items (#916)
* tightened right bar items, closes #896

* added UIBarButtonItem and UIPopoverPresentationController extensions
2017-11-10 12:39:40 -05:00
Rizwan Mohamed Ibrahim
ab28e739bc [CHOR] @objc at same line as func (#888) 2017-11-07 13:37:36 -05:00
Ryan Nystrom
33faea80f2 More shared logic for bookmarks in nav item (#884)
* Use even more shared code for bookmarks in nav bar

* correct selected/not logic

* restore image changing in action

* add haptics

* swap actions between add and remove
2017-11-07 09:57:25 -05:00
Rizwan Mohamed Ibrahim
7c23286628 Changes Bookmark action to be a nav bar item (#879)
* Add Bookmark nav items

* [ADD] Bookmark actions to nav right item and remove bookmark alert action

* [ADD] Bookmark nav right item for Repo and remove bookmark alert action

* [CHOR] Clean up old bookmark alert action

* [ADD] Shared function for toggling bookmark
2017-11-07 08:46:12 -05:00
Hesham Salman
1e2e0c1698 Chore/bookmark rewrite (#865)
* Unified store behavior, new bookmark model

- Added a `Store` protocol to the project with default implementations
  that should be sufficient for most models. (#855)
- Switched images in the notification type category to #imageLiterals,
  so we can avoid the optionality of the image.

* Implemented BookMark ViewModel

* Created Bookmark Collection Cell

* Created Bookmark View Controller

Done:
  - Displays empty state
  - Displays bookmarks
  - Allows for adding of new bookmarks
  - Navigating to bookmarks

In flight:
  - Clear All

TODO:
  - Search
  - Cleanup old files & remove SwipeCell hacks

* Unified search and clear all behavior

The search bar and clear all buttons between the search and bookmarks
page had different styles and behavior. This PR:
  - Makes a generic clear-all header
  - Gives one to each VC
  - Makes them behave the same to the user re: visibility etc

* Re-implemented filter

* Deleted old files

* Attributed String Sizing

* Removed bookmark store tests

* Reloading bookmarks & namespacing

Can now reload bookmarks through the listener pattern (#773, #783).
Bookmark store is now correctly namespaced again.
2017-11-06 09:03:29 -05:00
Ryan Nystrom
0851d198d7 Update Tabman with recent bugfixes (#868)
* Update Tabman with recent bugfixes

* remove debug code
2017-11-06 09:01:46 -05:00
James Sherlock
63cc844b0a Use repository default branch rather than master for file view (#849) 2017-11-04 21:42:54 -04:00
Ryan Nystrom
e82e23df29 Repo uses title/subtitle (#820) 2017-10-31 23:59:36 -07:00
Ryan Nystrom
18801a1064 Refactor alert titles (#818) 2017-10-31 22:03:15 -07:00
Ryan Nystrom
aa15d3e6d5 Remove iOS 11 navigation titles (#816) 2017-10-31 22:02:53 -07:00
Ryan Nystrom
f0efae3317 Inject bookmarks, cleanup (#780) 2017-10-27 11:35:19 -04:00
Rizwan Mohamed Ibrahim
199ce48047 [ADD] Bookmarks per user account (#738) 2017-10-27 10:55:22 -04:00
Rizwan Mohamed Ibrahim
fba236450b Adds options to remove bookmark (#696)
* [ADD] options to remove bookmark

* [ADD] Move bookmark actions to bottom of action sheet
2017-10-24 21:43:22 -04:00
Rizwan Mohamed Ibrahim
40091dd4a1 [ADD] Large title for bookmarks with search controller (#692) 2017-10-24 21:40:35 -04:00
Hesham Salman
f213bac924 Thin SwiftLint ruleset (#704)
* Thin SwiftLint ruleset

* Disabled trailing_whitespace rule
2017-10-23 16:58:09 -04:00
Rizwan Mohamed Ibrahim
bd10b4e032 Add Bookmarks tab (#601)
* [ADD] Bookmarks for repo, issues and pull request

* [FIX] Bookmark model decoding from archive

* [ADD] Clear all option for bookmarks

* [ADD] Search bookmarks with search bar

* [ADD] Swipe to delete for bookmarks (only when search bar is not active)

* [ADD] Bookmark cell accessible and some cleanup

* [ADD] Incorporate review comments

* [ADD] Reuse notification type instead of bookmark type

* [ADD] Incorporate review comments
- Enum over struct on bookmark model
- Github bookmark tab icon
- Smooth deselection, Single tap to scroll to top, cleanup
-
2017-10-22 14:00:50 -04:00
Ryan Nystrom
1f734514a9 browse repo dirs 2017-10-14 15:40:36 -04:00
Ryan Nystrom
34ebd869ad Revert "Added iOS 11 searchController UINavigationItem (#522)"
This reverts commit c32eda7989.
2017-10-13 20:05:16 -04:00
Ryan Nystrom
5ecfc19fee replace status bar calls with toast 2017-10-12 21:34:51 -04:00
Joe Rocca
c32eda7989 Added iOS 11 searchController UINavigationItem (#522)
* added iOS 11 searchController UINavigationItem, fixes #376

* set iOS 11 UINavigationItem largeTitleDisplayMode to never
2017-10-11 13:40:55 -04:00
Ryan Nystrom
cb4cec0c3a fix tabman to 1.0.1 to avoid bugs 2017-10-07 18:37:51 +01:00
Ryan Nystrom
1c38ff4d5c swift 4 migration 2017-10-07 14:46:10 +01:00
Ryan Nystrom
30c758b4ac new base list VC, refactor repo issues, fixes #493 2017-10-05 22:37:40 +01:00
Ivan Magda
f8d0cc7f12 Move duplicate share UIAlertActions to AlertAction struct #359 (#431)
* Move duplicate share UIAlertActions to AlertActions struct #359

Create helper AlertActions struct for convenient UIAlertAction's instantiation.

* Create AlertActionBuilder #359

The AlertActionBuilder is used to create custom UIAlertAction's with constituent parts.

* Create UIAlertController+Action #359

UIAlertController+Action extension provide a convinient way for adding actions into the UIAlertController.

* Move additional UIAlertAction duplicates into AlertAction #359

* NewIssueTableViewController: Use correct titles for alert actions #359

Use "Go back" and "Discard" titles instead of "No" and "Yes".

* IssueCommentSectionController: Refactor alert actions #359

* SettingsViewController: Refactor onSignOut alert actions #359
2017-09-29 16:21:17 -04:00
Ryan Nystrom
8d1aa57301 present new issue VC modally, fixes #449 2017-09-28 20:11:50 -04:00
Ryan Nystrom
5fe34ce698 fix tabman bug when tabbar is visible 2017-09-26 21:05:13 -04:00
Ryan Nystrom
550c93e700 action title says "New Issue" 2017-09-25 22:53:52 -04:00
James Sherlock
f40557eeaf Native Create Issue (#311)
* Add a "Create Issue" view controller, Hook up networking, Enable bug reporting

* Add create issue button to all repos

* Fix navigation for tablet, Add markdown controls view

* Remove new issue button if issues are not enabled

* Add localization for new issue text

* Update scrollView insets on keyboard, Add slight background

* More style changes, moved preview to it's own button, expanding text view, return takes you to next field

* Update bug report repository

* Design changes

* Add markdown controls to new issue
2017-09-25 11:24:14 -04:00
Dylan Lewis
a3276615d5 [413] Use shared colours for standard UI components (#421)
* Update UISwitch on tint color

Align green with shared color

* Update tintColor of all UIAlertControllers

* Create factory for SFSafariViewController

* Update SFSafariViewController tint color

Only in the .configured factory

* Use SFSafariViewController factory everywhere

* Create factory for UIAlertController

* Use UIAlertController factory everywhere
2017-09-24 18:32:32 -04:00
Ryan Nystrom
873ad37e7e only show issues page when enabled, fixes #379 2017-09-23 10:29:53 -04:00
Ryan Nystrom
00ed7ec1e6 backout center align 2017-09-23 10:25:11 -04:00
Ryan Nystrom
8adf246d08 center pages on repo, fixes #383 2017-09-23 10:23:47 -04:00
Ryan Nystrom
6912f7617f Repo paging control (#336)
* WIP paging control on repos

* paging working but inset still broken

* remove old repo VC and replace with paging
2017-09-22 18:12:05 -04:00
Bas Broek
cd269665df Add cancel button to repository more options 2017-09-22 07:41:42 +02:00
Ryan Nystrom
e2999fdff2 proper push from issues VC 2017-09-18 22:50:26 -04:00
Rizwan Mohamed Ibrahim
5567c20d5f Adds more options to repo with share actions 2017-09-18 19:18:28 +05:30
Ryan Nystrom
c73576eb66 Merge branch 'master' of github.com:rnystrom/GitHawk 2017-09-17 17:41:34 -04:00
Ryan Nystrom
1592d9b29b intro parsing options 2017-09-17 17:41:29 -04:00
James Sherlock
b2f71a54d2 Merge branch 'master' into tabBarHeight 2017-09-17 22:15:41 +01:00
Ryan Nystrom
ee5ffd03e9 Merge pull request #310 from rizwankce/fix/empty-state-for-repo-overview
Adds empty state when no readme for repository
2017-09-17 16:59:36 -04:00