Commit Graph

142 Commits

Author SHA1 Message Date
Ryan Nystrom
e9899fb935 Delete NSAttributedStringSizing (#1826)
* Delete NSAttributedStringSizing

* compile
2018-05-21 11:15:38 -04:00
Bas Broek
1507b17025 Synthesize Equatable conformances 2018-05-10 10:36:08 +02:00
Ryan Nystrom
b02c7cf0ad functioning watch app 2018-04-29 21:38:25 -04:00
Ryan Nystrom
518824f634 add space to default search string (#1750) 2018-04-22 13:41:04 -04:00
Ryan Nystrom
715fd12c14 github syntax search working 2018-04-16 21:46:18 -04:00
Ryan Nystrom
178d7700b7 Remove MMMarkdown dependency (#1729)
* replace old markdown callsites

* unit tests working

* remove unused parsing

* final removal of old parsing, build and tests succeed

* remove dependency

* capture readme ref branch
2018-04-14 23:12:03 -04:00
Bas Broek
7482881711 Change two flatMaps to compactMap 2018-04-10 11:51:18 +02:00
Orta
6dc2988d23 Port to Xcode 9.3 (#1696) 2018-04-07 23:24:51 -04:00
Ryan Nystrom
62e2763a85 Refactor markdown parsing to use text lib (#1674)
* milestones refactored with styled text

* reference refactored

* refactor commit references

* fix styled text bug

* request event refactored

* refactor titles

* warm caches for bg-gen models

* delete old text cell

* move shortlinks into MMMarkdown

* almost there

* build green

* running and trimming whitespaces

* styled text working

* fix tests

* tests passing
2018-03-31 10:12:51 -04:00
Ryan Nystrom
66dc61ace0 Refactor labeled events to use StyledText (#1659)
* refactor tap handling on attributed views

* styled cell interaction working

* share menu code

* label events finished
2018-03-18 14:55:57 -04:00
Ryan Nystrom
83acbea441 Start refactoring text views with StyledText (#1658)
* refactoring with styledtext

* issue rename refactored

* fix tests
2018-03-17 18:55:08 -04:00
Ryan Nystrom
002de8d4ed Update Apollo to 0.8.0 and codegen to 0.18.8 (#1656) 2018-03-17 15:54:18 -04:00
Ivan Magda
6c3c451677 Add PDF support (#1596)
* Add string extension for searching pdf files (#1552)

* Create RepositoryWebViewController (#1552)

* Initial presenting of the pdf files (#1552)

* refactor: Rename String+Resource -> String+BinaryFile (#1552)

* Build destination URL (#1552)

* Configure title (#1552)

* Encode file path

* Use EmptyView for errors

* Replace UIWebView with WKWebView

* Review fixes

* refactor: Make binarySuffix computed property

* Unify if-else path

* Group guard statements
2018-03-11 15:59:51 -04:00
Ryan Nystrom
45335eb4a0 [WIP] Refactor networking to shared lib (#1602)
* [WIP] Refactor networking to shared lib

* notification models as codable and tests

* default request params

* break out into files

* fix tests

* check notification values

* add milestones

* add milestone response

* repo notifications

* refactor v3 response

* refactor to support passing response to response initializer

* add release fetch and model

* add examples from githawk

* notifications working

* almost all notifications requests migrated

* finish notification migration, add graphql request/response

* replace issue requests

* replace milestones request

* fetch assignees migrated

* readme fetch migrated

* migrate badge request

* delete unused request from client

* remove paging

* nearly done w/ migration

* local build green

* refactor gql fetches, replace mutations

* build green, slim down client

* strip session manager from client

* everything working
2018-03-04 21:35:36 -05:00
Luciano Almeida
83a2ffe6bd Removing #available conditionals (#1578) 2018-02-26 22:24:08 -08:00
Luciano Almeida
12fb61a318 Fixing files dont have code highlighting (#1543) 2018-02-19 20:32:17 -05:00
Luciano Almeida
9a3b301dae Fixing topLayoutGuide and bottomLayoutGuide iOS 11 deprecated Warnings (#1510) 2018-02-11 18:40:27 -05:00
Ryan Nystrom
0001920b75 Refactor text styles to use StyledText (#1490) 2018-02-04 19:09:42 -05:00
Rizwan Mohamed Ibrahim
99989c3b8b [FIX] Remove user name action from repo view (#1410) 2018-01-14 12:11:32 -05:00
Ryan Nystrom
cb15bc47c8 use new dropdown for browsing files (#1400) 2018-01-13 16:37:29 -05:00
Ryan Nystrom
ca3bc322a7 New navigation title dropdown control (#1399)
* create new nav view

* issue nav title wired up

* more button now system action

* better sized bookmark assets

* wire up title actions on repo

* tweak compression UI

* revert helper hack
2018-01-13 15:54:20 -05:00
Ryan Nystrom
d5fe0646ff error message for repo dir (#1350) 2018-01-05 13:24:19 -05:00
Joe Rocca
17ecfbb518 Added wrapping labels view to RepoSummaryCell (#1245)
* added label list view to repo summary cell

* simpler total label width calculation

* simplified label list view height caching
2017-12-19 14:51:45 -05:00
Bas Broek
377161aed0 Fix Int format crash + unify String localization (#1273)
* Use %d over %zi to prevent a possible crash

* Clean up / unify localization behavior

Before, we were doing double localization (Feeding a `LocalizedString` into a `.localizedStringWithFormat`).
2017-12-17 16:10:57 -05:00
Dragiša Spasojević
09f0ba6ff5 Remove unused code 2017-12-17 18:33:45 +01:00
Ryan Nystrom
0fc619e420 Tapping checkboxes updates the UI and edits on the server (#1272)
* edit checkboxes working

* always can update when editing

* edit comment sent to client
2017-12-17 09:19:19 -05:00
Ryan Nystrom
eb7069f6f7 Refactor date formatting from String (#1229)
* refactor date formatting from String

* undo new file
2017-12-16 22:16:01 -05:00
Bas Broek
0db76b3b76 Add + update a11x for navigation titles (#1257)
* Add + update a11x for navigation items

* A file is not a file extension
2017-12-16 22:15:29 -05:00
Ryan Nystrom
8e30bacb81 master repo VC background is white (#1214) 2017-12-11 09:04:03 -05:00
Bas Broek
7f04139794 Disable animations when reduce motion enabled (#1167) 2017-12-10 18:15:44 -05:00
Ryan Nystrom
8b83e96fe3 Hide/show disclosure icons on dirs and files (#1177) 2017-12-03 20:12:58 -05:00
Ryan Nystrom
270903e1ae refactor dir and blob paths, add tests (#1165) 2017-12-03 16:36:43 -05:00
Ryan Nystrom
e1467b6b9f convert readme to base list vc (#1141) 2017-12-02 19:16:45 -05:00
Ryan Nystrom
9f40b07e93 Remove repo dir and blob back title (#1138) 2017-12-02 19:16:14 -05:00
Ryan Nystrom
7c47cdc025 Repo code highlighting (#1137)
* Fix repo blob loading bug

* Repo code highlighting
2017-12-02 19:15:51 -05:00
Ryan Nystrom
bd55b07aa8 Fix repo blob loading bug (#1136) 2017-12-02 19:15:40 -05:00
Bas Broek
872da1f458 [Cleanup] Remove nil-default completion parameters (#1131)
* Remove nil-default completion parameters

* Remove redundant character trimming
2017-12-02 18:48:32 -05:00
Bas Broek
0ccf2d0ca7 Add repo+author name to action sheet, title accessibility (#1120) 2017-12-02 11:26:37 -05:00
Ryan Nystrom
3de0859b2e open fullscreen images when tapping web view (#1106) 2017-11-28 20:20:48 -05:00
Ryan Nystrom
3724798277 Convert repo code browsing to base VC and IGLK (#1097) 2017-11-27 13:08:44 -05:00
Ryan Nystrom
7bc969a5f5 PR patch files use base list VC (#1092)
* PR patch files use base list VC

* white bg on cell

* remove dead code, update schema, thread file count
2017-11-27 13:07:58 -05:00
Ryan Nystrom
bb2828e9c8 share code text view with repo and issue (#1089) 2017-11-26 12:29:21 -05:00
Bas Broek
1717b14ab3 Generate accessibility labels for cells (#1052)
* Add accessibility cell label generation

* Replace manual labels with generated ones
2017-11-23 11:30:48 -05:00
Ryan Nystrom
00414833fd local Tabman to fix inset issues (#923) 2017-11-11 21:53:12 -05:00
Joe Rocca
ca9c9df1df Tightened right bar items (#916)
* tightened right bar items, closes #896

* added UIBarButtonItem and UIPopoverPresentationController extensions
2017-11-10 12:39:40 -05:00
Rizwan Mohamed Ibrahim
ab28e739bc [CHOR] @objc at same line as func (#888) 2017-11-07 13:37:36 -05:00
Ryan Nystrom
33faea80f2 More shared logic for bookmarks in nav item (#884)
* Use even more shared code for bookmarks in nav bar

* correct selected/not logic

* restore image changing in action

* add haptics

* swap actions between add and remove
2017-11-07 09:57:25 -05:00
Rizwan Mohamed Ibrahim
7c23286628 Changes Bookmark action to be a nav bar item (#879)
* Add Bookmark nav items

* [ADD] Bookmark actions to nav right item and remove bookmark alert action

* [ADD] Bookmark nav right item for Repo and remove bookmark alert action

* [CHOR] Clean up old bookmark alert action

* [ADD] Shared function for toggling bookmark
2017-11-07 08:46:12 -05:00
Hesham Salman
1e2e0c1698 Chore/bookmark rewrite (#865)
* Unified store behavior, new bookmark model

- Added a `Store` protocol to the project with default implementations
  that should be sufficient for most models. (#855)
- Switched images in the notification type category to #imageLiterals,
  so we can avoid the optionality of the image.

* Implemented BookMark ViewModel

* Created Bookmark Collection Cell

* Created Bookmark View Controller

Done:
  - Displays empty state
  - Displays bookmarks
  - Allows for adding of new bookmarks
  - Navigating to bookmarks

In flight:
  - Clear All

TODO:
  - Search
  - Cleanup old files & remove SwipeCell hacks

* Unified search and clear all behavior

The search bar and clear all buttons between the search and bookmarks
page had different styles and behavior. This PR:
  - Makes a generic clear-all header
  - Gives one to each VC
  - Makes them behave the same to the user re: visibility etc

* Re-implemented filter

* Deleted old files

* Attributed String Sizing

* Removed bookmark store tests

* Reloading bookmarks & namespacing

Can now reload bookmarks through the listener pattern (#773, #783).
Bookmark store is now correctly namespaced again.
2017-11-06 09:03:29 -05:00
Ryan Nystrom
0851d198d7 Update Tabman with recent bugfixes (#868)
* Update Tabman with recent bugfixes

* remove debug code
2017-11-06 09:01:46 -05:00