Commit Graph

993 Commits

Author SHA1 Message Date
Ryan Nystrom
b04ffc1ac7 layout bookmark cell on settings change (#1130) 2017-12-02 16:14:06 -05:00
Ryan Nystrom
c38f506947 convert reference to attr string (#1126) 2017-12-02 15:26:59 -05:00
Ryan Nystrom
1d3b6169ad Add and remove PR reviewers (#1122)
* refactor models for managing

* refactor people mutation to use assign or reviewers

* fix bug when removing reviewers

* tune spacing
2017-12-02 15:23:20 -05:00
Bas Broek
0ccf2d0ca7 Add repo+author name to action sheet, title accessibility (#1120) 2017-12-02 11:26:37 -05:00
Ryan Nystrom
16c4443312 Clean label background drawing (#1114) 2017-11-29 10:11:18 -05:00
Rizwan Mohamed Ibrahim
9180cb3267 [FIX] Accessibility for manage buttons on issues VC (#1115) 2017-11-29 10:11:05 -05:00
Ryan Nystrom
2a3f40d9de Prevent UIRefreshControl from double inset bug (#1105) 2017-11-28 20:21:26 -05:00
Ryan Nystrom
3de0859b2e open fullscreen images when tapping web view (#1106) 2017-11-28 20:20:48 -05:00
Ryan Nystrom
3724798277 Convert repo code browsing to base VC and IGLK (#1097) 2017-11-27 13:08:44 -05:00
Ryan Nystrom
7bc969a5f5 PR patch files use base list VC (#1092)
* PR patch files use base list VC

* white bg on cell

* remove dead code, update schema, thread file count
2017-11-27 13:07:58 -05:00
Rizwan Mohamed Ibrahim
797ab90294 Make Bookmark cell and Search Recent cell accessible (#1099)
* [ADD] Make Bookmark cell and Search Recent cell accessible

* [ADD] Make selectable cell accessible
2017-11-27 13:07:50 -05:00
Ryan Nystrom
a45fdb3bd4 warm label event size caches (#1090) 2017-11-26 12:34:29 -05:00
James Sherlock
a504a87033 Use AttributedStringCell for IssueLabeledCell (#1071)
* Use AttributedStringCell for IssueLabeledCell

* Code review changes
2017-11-26 12:31:27 -05:00
Ryan Nystrom
bb2828e9c8 share code text view with repo and issue (#1089) 2017-11-26 12:29:21 -05:00
Ryan Nystrom
0a5ca14843 Add syntax highlighting for comments (#1087) 2017-11-26 12:29:10 -05:00
Ryan Nystrom
178b37eb27 Render checkmarks (#1078)
* add assets

* put marker for checked and unchecked

* attachment working

* export smaller assets

* use lighter blue for checked

* thread can-update, undo accident

* nudge down checkmark attachment

* add tests
2017-11-26 12:27:32 -05:00
Ryan Nystrom
bb8a8ac45f search cell shares common height (#1077) 2017-11-24 21:19:19 -05:00
Ryan Nystrom
4128f950a8 Only keep one bitmap cache at a time (#1076)
* only keep one bitmap cache at a time

* add leftover changes
2017-11-24 21:18:55 -05:00
Ryan Nystrom
90cd6f478a Milestone event cells use attributed text system (#1073)
* move milestone attr string to model

* address api changes for milestone model
2017-11-24 20:52:35 -05:00
James Sherlock
0dffae020b API Keys read from environment variables (#1075)
* Update client keys to use environment vars

* Extra logging to assist with debugging

* Add other files to test target (temporary solution)

* Update Project Target References

* Add arguments and share scheme

* Disable failing FBSnapshot tests

* If at first you fail, wait 20 minutes for a build and then try again

* Update test to also ensure it's not using the template keys

* Update gitignore

* Remove intentional failing test

* revert pod changes

* revert podfile
2017-11-24 20:51:31 -05:00
Ryan Nystrom
7a82d152a3 Reference commit cell uses text height (#1072)
* Reference commit cell height to text

* remove sample code
2017-11-23 11:48:16 -05:00
Bas Broek
1717b14ab3 Generate accessibility labels for cells (#1052)
* Add accessibility cell label generation

* Replace manual labels with generated ones
2017-11-23 11:30:48 -05:00
James Sherlock
905dd7d695 Add better error messages for Image Upload fail states (#1062) 2017-11-23 11:30:32 -05:00
Ryan Nystrom
a313f6e110 reference commit cells use attr string cell (#1068) 2017-11-23 11:30:06 -05:00
Ryan Nystrom
2d2b2f29ad Add support for cross reference events (#1070)
* update gql schema

* add cross ref event

* wire up cross ref event

* adjust reference cell

* nudge icon down
2017-11-23 11:29:42 -05:00
Ryan Nystrom
42e5669ff1 Top/bottom insets for request events (#1066)
* top/bottom insets for request events

* tighter spacing
2017-11-23 11:28:38 -05:00
Bas Broek
c27ebab527 Add magic tap to saving comment/sending issue (#1045)
* Add magic tap to saving comment/sending issue

* Update EditCommentViewController.swift
2017-11-22 13:29:40 -05:00
Ryan Nystrom
c73ac14981 Use actual imgur key (#1050) 2017-11-22 09:24:32 -05:00
Bas Broek
9ed7c9c8b3 Disable the right item editing a comment to an empty one (#1041)
* Disable the right item editing a comment to an empty one

* remove guard
2017-11-22 09:24:21 -05:00
Bas Broek
fe4895af7e Add initial accessibility support for text cell (#1040) 2017-11-22 09:23:05 -05:00
Ryan Nystrom
69a6793adc Fix constants in config (#1036) 2017-11-21 17:22:38 -05:00
Bas Broek
14bed98d0f Add accessibility labels to markdown bar operations (#1030) 2017-11-21 15:00:46 -05:00
Bas Broek
8723664af4 Sort labels alphabetically (#1029) 2017-11-21 14:03:11 -05:00
Ryan Nystrom
8f88e430a9 Add and remove assignees (#1011)
* add and remove assignees

* add bottom view so there arent trailing separators
2017-11-20 17:22:31 -05:00
Ryan Nystrom
086af29cbb allow double-tap like when reaction not visible (#1009) 2017-11-20 17:22:19 -05:00
Ryan Nystrom
e31e07821c Environment variables and secrets refactor (#999)
* add config and env variable files

* add env vars script to ignore file

* script working, ignore config changes

* ignore env vars

* remove ignored files from cache

* gen secrets config, imported by others

* objc secrets files
2017-11-19 18:57:22 -05:00
Ryan Nystrom
ff2d54b867 Reverse managing cell animation direction (#1004) 2017-11-19 18:17:45 -05:00
Ryan Nystrom
2d02c01cff Add Crashlytics and Answers (#1001)
* add fabric

* name runscript
2017-11-19 18:17:35 -05:00
Ryan Nystrom
69e29b9959 Dump bitmap caches on memory warning (#1002) 2017-11-19 18:16:51 -05:00
Ryan Nystrom
47db193a5b Prevent tapping managing cells while animating (#1003)
* Prevent tapping managing cells while animating

* always deselect
2017-11-19 18:15:57 -05:00
Ryan Nystrom
4d9b0e3800 labels done style consistent (#1005) 2017-11-19 18:15:43 -05:00
Joe Rocca
76914651ad Adds double tap comment to 👍 (#809)
* Added double tap on comment to react with thumbs up

* Changed func name for consistency

* added DoubleTappableCell to project file

* added no-op for PR review comments

* added pr review comment flag check instead of vc
2017-11-19 16:47:34 -05:00
Ryan Nystrom
5f6d3efe14 Move neck load cell beneath root comment (#987) 2017-11-18 17:03:18 -05:00
Ryan Nystrom
dac2c00c62 Bookmark cell refactor for consistent UI (#980)
* Bookmark cell refactor for consistent UI

* remove useless test
2017-11-18 16:47:12 -05:00
Ryan Nystrom
45cc1391a9 New comments use FlatCache mutation system (#984) 2017-11-18 16:47:01 -05:00
Ryan Nystrom
c8029a0dcd Add optimistic label events (#982) 2017-11-18 16:46:50 -05:00
Ryan Nystrom
24d949cc05 Search UI consistent with app (#981) 2017-11-18 16:46:39 -05:00
Ryan Nystrom
3019c3c725 Use collab permissions endpoint to check collab status (#966)
* Use collab permissions endpoint to check collab status

* handle forbidden and errors

* parse permissions into an enum

* remove values, use defaults
2017-11-18 11:53:47 -05:00
Bas Broek
61008c4982 More expressive search placeholders (#977)
* More expressive search placeholders

* PR review comments
2017-11-18 11:53:05 -05:00
Ryan Nystrom
57f85298cd Milestone shares bg color (#961) 2017-11-16 08:54:45 -05:00