Commit Graph

1213 Commits

Author SHA1 Message Date
Ryan Nystrom
69a6793adc Fix constants in config (#1036) 2017-11-21 17:22:38 -05:00
Ryan Nystrom
c943a8c652 Add new API key setup info (#1035) 2017-11-21 17:22:29 -05:00
Bas Broek
14bed98d0f Add accessibility labels to markdown bar operations (#1030) 2017-11-21 15:00:46 -05:00
Bas Broek
8723664af4 Sort labels alphabetically (#1029) 2017-11-21 14:03:11 -05:00
Merrick Sapsford
b3bfaf933c Update Tabman to 1.0.7 (#1014)
* Update Tabman to latest version

1.0.6

* Remove local copy of Tabman

* Update Podfile

Remove local Tabman entry

* Update Tabman

1.0.7
2017-11-20 17:22:42 -05:00
Ryan Nystrom
8f88e430a9 Add and remove assignees (#1011)
* add and remove assignees

* add bottom view so there arent trailing separators
2017-11-20 17:22:31 -05:00
Ryan Nystrom
086af29cbb allow double-tap like when reaction not visible (#1009) 2017-11-20 17:22:19 -05:00
Ryan Nystrom
e31e07821c Environment variables and secrets refactor (#999)
* add config and env variable files

* add env vars script to ignore file

* script working, ignore config changes

* ignore env vars

* remove ignored files from cache

* gen secrets config, imported by others

* objc secrets files
2017-11-19 18:57:22 -05:00
Ryan Nystrom
2b19b007ef fix unit tests (#1007) 2017-11-19 18:20:41 -05:00
Ryan Nystrom
ff2d54b867 Reverse managing cell animation direction (#1004) 2017-11-19 18:17:45 -05:00
Ryan Nystrom
2d02c01cff Add Crashlytics and Answers (#1001)
* add fabric

* name runscript
2017-11-19 18:17:35 -05:00
Ryan Nystrom
69e29b9959 Dump bitmap caches on memory warning (#1002) 2017-11-19 18:16:51 -05:00
Ryan Nystrom
125761389c Bump version to 1.14.0 (#1000) 2017-11-19 18:16:07 -05:00
Ryan Nystrom
47db193a5b Prevent tapping managing cells while animating (#1003)
* Prevent tapping managing cells while animating

* always deselect
2017-11-19 18:15:57 -05:00
Ryan Nystrom
4d9b0e3800 labels done style consistent (#1005) 2017-11-19 18:15:43 -05:00
Joe Rocca
76914651ad Adds double tap comment to 👍 (#809)
* Added double tap on comment to react with thumbs up

* Changed func name for consistency

* added DoubleTappableCell to project file

* added no-op for PR review comments

* added pr review comment flag check instead of vc
2017-11-19 16:47:34 -05:00
Ryan Nystrom
5f6d3efe14 Move neck load cell beneath root comment (#987) 1.13.0 2017-11-18 17:03:18 -05:00
Ryan Nystrom
dac2c00c62 Bookmark cell refactor for consistent UI (#980)
* Bookmark cell refactor for consistent UI

* remove useless test
2017-11-18 16:47:12 -05:00
Ryan Nystrom
45cc1391a9 New comments use FlatCache mutation system (#984) 2017-11-18 16:47:01 -05:00
Ryan Nystrom
c8029a0dcd Add optimistic label events (#982) 2017-11-18 16:46:50 -05:00
Ryan Nystrom
24d949cc05 Search UI consistent with app (#981) 2017-11-18 16:46:39 -05:00
Ryan Nystrom
3019c3c725 Use collab permissions endpoint to check collab status (#966)
* Use collab permissions endpoint to check collab status

* handle forbidden and errors

* parse permissions into an enum

* remove values, use defaults
2017-11-18 11:53:47 -05:00
Bas Broek
61008c4982 More expressive search placeholders (#977)
* More expressive search placeholders

* PR review comments
2017-11-18 11:53:05 -05:00
Ryan Nystrom
57f85298cd Milestone shares bg color (#961) 2017-11-16 08:54:45 -05:00
Ryan Nystrom
710dae0388 Manage milestones on issues & PRs (#954)
* setup for mutating milestones on issues

* finish milestones
2017-11-16 08:46:35 -05:00
Hesham Salman
b18858ac6e Bookmark subtitle color (#957)
Updated the bookmark subtitle color and the issue # color to medium-gray
2017-11-16 08:46:25 -05:00
Ryan Nystrom
f272f08135 Move label editing to a managing control with collaborator request (#936)
* Move label editing to a managing control with collaborator request

* tighten spacing on chevron

* move action cell to top-right, highlight states, action icons
2017-11-15 15:12:53 -05:00
Ryan Nystrom
d5c0b2dfd3 Bump to version 1.13.0 (#953) 2017-11-15 15:12:31 -05:00
Ryan Nystrom
c79cbd5e41 Bump version to 1.12.1 (#948)
* Bump version to 1.13.0

* 1.12.1 instead for a hotfix
1.12.1
2017-11-14 10:38:27 -05:00
James Sherlock
50ddf0863e Remove last comment URL from the required subject model (#949) 2017-11-14 10:37:25 -05:00
James Sherlock
c25941fd83 Allow user to preview image upload using NYTPhotoViewer (#941) 2017-11-14 09:47:52 -05:00
James Sherlock
609ac8e817 Define viewController for image upload to present chooser/upload UI (#940) 2017-11-14 09:46:10 -05:00
Ryan Nystrom
53b0db103c Use IGListCollectionViewLayout (#932)
* Use IGListCollectionViewLayout

* use layout category and add comment
2017-11-13 21:17:38 -05:00
Ryan Nystrom
14e5625048 Remove Search subtitle from shortcut (#925) 1.12.0 2017-11-12 11:05:14 +08:00
Ryan Nystrom
b404b866a3 actually hide and show the text view (#921) 2017-11-11 21:53:30 -05:00
Ryan Nystrom
d4defc6bf1 send kb to bottom as keyboard rises (#922) 2017-11-11 21:53:21 -05:00
Ryan Nystrom
00414833fd local Tabman to fix inset issues (#923) 2017-11-11 21:53:12 -05:00
Ryan Nystrom
9c1fe7eabf Open review access in Safari.app on iOS 11 (#924) 2017-11-11 21:53:02 -05:00
Ryan Nystrom
1fee729885 Fix incorrect state sent to status API (#917) 2017-11-10 16:27:50 -05:00
Joe Rocca
ca9c9df1df Tightened right bar items (#916)
* tightened right bar items, closes #896

* added UIBarButtonItem and UIPopoverPresentationController extensions
2017-11-10 12:39:40 -05:00
Ryan Nystrom
a232cb823b Empty view background clear (#915) 2017-11-09 11:05:09 -05:00
Ryan Nystrom
f208148ba0 Add keyboard helpers to remove duped code (#897) 2017-11-09 10:38:58 -05:00
Ryan Nystrom
7a91200d3b Revert "Use ListCollectionViewLayout for VC lists" (#912)
* Revert "Open GitHub Status when tapping cell (#905)"

This reverts commit 8e14a5642b.

* Revert "Increased tap target for ... buttons (#909)"

This reverts commit 160705a724.

* Revert "Comment cell images don't scale to fit (#903)"

This reverts commit 4adf511ea4.

* Revert "Fixed styling and alignment issues (#898)"

This reverts commit 34083c9ede.

* Revert "Use ListCollectionViewLayout for VC lists (#892)"

This reverts commit 2eb12b2dd5.
2017-11-09 10:38:25 -05:00
Bas Broek
8e14a5642b Open GitHub Status when tapping cell (#905)
* Open GitHub Status when tapping cell

* Use StyledTableCell for consistency
2017-11-09 10:37:41 -05:00
Joe Rocca
160705a724 Increased tap target for ... buttons (#909)
* increased tap target for ... buttons, fixes #902

* fixed right offset
2017-11-09 10:37:27 -05:00
Ryan Nystrom
4adf511ea4 Comment cell images don't scale to fit (#903)
* images scale to top

* layout image view based on image size
2017-11-09 10:37:12 -05:00
Hesham Salman
34083c9ede Fixed styling and alignment issues (#898)
Fixed:
  - Alignment issues
  - Bottom border inset
  - Selection behavior

How:
  - Replaced using an AttributedStringView with a UILabel, continued to
    use the sizing from the NSAttributedStringSizing to calculate height
  - Changed styling to match the rest of the app re: insets.
2017-11-08 10:57:47 -05:00
Ryan Nystrom
2eb12b2dd5 Use ListCollectionViewLayout for VC lists (#892) 2017-11-07 20:39:29 -05:00
James Sherlock
d6c9dcb14f Enable image upload for comments (#891) 2017-11-07 18:06:47 -05:00
Rizwan Mohamed Ibrahim
ab28e739bc [CHOR] @objc at same line as func (#888) 2017-11-07 13:37:36 -05:00