Commit Graph

18 Commits

Author SHA1 Message Date
Hesham Salman
1e2e0c1698 Chore/bookmark rewrite (#865)
* Unified store behavior, new bookmark model

- Added a `Store` protocol to the project with default implementations
  that should be sufficient for most models. (#855)
- Switched images in the notification type category to #imageLiterals,
  so we can avoid the optionality of the image.

* Implemented BookMark ViewModel

* Created Bookmark Collection Cell

* Created Bookmark View Controller

Done:
  - Displays empty state
  - Displays bookmarks
  - Allows for adding of new bookmarks
  - Navigating to bookmarks

In flight:
  - Clear All

TODO:
  - Search
  - Cleanup old files & remove SwipeCell hacks

* Unified search and clear all behavior

The search bar and clear all buttons between the search and bookmarks
page had different styles and behavior. This PR:
  - Makes a generic clear-all header
  - Gives one to each VC
  - Makes them behave the same to the user re: visibility etc

* Re-implemented filter

* Deleted old files

* Attributed String Sizing

* Removed bookmark store tests

* Reloading bookmarks & namespacing

Can now reload bookmarks through the listener pattern (#773, #783).
Bookmark store is now correctly namespaced again.
2017-11-06 09:03:29 -05:00
Ryan Nystrom
8276fc5492 Bookmark tab icons (#727)
* Bookmark tab icons

* tweak so inner star is slightly smaller
2017-10-24 23:46:17 -04:00
Bas Broek
359794debf Some general text improvements 2017-10-22 22:49:52 +02:00
Rizwan Mohamed Ibrahim
bd10b4e032 Add Bookmarks tab (#601)
* [ADD] Bookmarks for repo, issues and pull request

* [FIX] Bookmark model decoding from archive

* [ADD] Clear all option for bookmarks

* [ADD] Search bookmarks with search bar

* [ADD] Swipe to delete for bookmarks (only when search bar is not active)

* [ADD] Bookmark cell accessible and some cleanup

* [ADD] Incorporate review comments

* [ADD] Reuse notification type instead of bookmark type

* [ADD] Incorporate review comments
- Enum over struct on bookmark model
- Github bookmark tab icon
- Smooth deselection, Single tap to scroll to top, cleanup
-
2017-10-22 14:00:50 -04:00
Ryan Nystrom
5bae4ba89d [WIP] Add FlatCache lib and use for Notifications (#632)
* init FlatCache lib

* tests for all other cases

* install flatcache to freeitme project, move VM creation into client

* refactor and split up inbox design

* fixup flatcache pod
2017-10-22 00:08:42 -04:00
Bas Broek
980fba6cc0 Move some hardcoded "Search"es to Constants (#616) 2017-10-21 20:35:57 -04:00
Ryan Nystrom
30c758b4ac new base list VC, refactor repo issues, fixes #493 2017-10-05 22:37:40 +01:00
James Sherlock
f40557eeaf Native Create Issue (#311)
* Add a "Create Issue" view controller, Hook up networking, Enable bug reporting

* Add create issue button to all repos

* Fix navigation for tablet, Add markdown controls view

* Remove new issue button if issues are not enabled

* Add localization for new issue text

* Update scrollView insets on keyboard, Add slight background

* More style changes, moved preview to it's own button, expanding text view, return takes you to next field

* Update bug report repository

* Design changes

* Add markdown controls to new issue
2017-09-25 11:24:14 -04:00
Ryan Nystrom
d83fff055c notifications now inbox 2017-09-05 23:19:59 -04:00
Ryan Nystrom
4fe95bbc25 custom tab bar icons 2017-09-04 11:57:34 -04:00
Ryan Nystrom
f5a7d8e487 move settings to tab 2017-09-02 17:33:54 -04:00
Ryan Nystrom
d9e5406aff adding personal access token 2017-08-25 23:37:11 -04:00
Ryan Nystrom
084ec29316 remove "2" from new settings 2017-07-31 15:41:10 -06:00
Ryan Nystrom
8fc79c685a refactor settings to use SB 2017-07-31 15:39:11 -06:00
Ryan Nystrom
1b58d1f458 remove tab VC, refactor settings and login 2017-06-25 21:26:10 -04:00
Ryan Nystrom
c911da1222 setup to add issue cells, title cell working, fixup vc title 2017-05-19 18:21:28 -04:00
Ryan Nystrom
ecf7a76b63 add account working 2017-05-17 12:17:43 -04:00
Ryan Nystrom
a4cfd20c6e refactor to support multiple accounts 2017-05-17 10:33:45 -04:00