Hesham Salman
f213bac924
Thin SwiftLint ruleset ( #704 )
...
* Thin SwiftLint ruleset
* Disabled trailing_whitespace rule
2017-10-23 16:58:09 -04:00
Viktor Gardart
d43fe6d3d1
🐛 Disable selection in IssueCommentHtmlCell ( #600 )
...
* 🐛 Disable selection in IssueCommentHtmlCell
* 🔥 made the template a "swift 4 string"
2017-10-21 20:17:11 -04:00
Ryan Nystrom
357e7e1bde
Finish wiring up edit comments ( #594 )
2017-10-18 12:14:17 -04:00
Ryan Nystrom
148dbd853a
disable collapse overlay animations
2017-10-16 21:07:33 -04:00
Ryan Nystrom
16a3e2375c
fix crash when tapping on image, fixes #584
2017-10-16 10:03:17 -04:00
Ryan Nystrom
ca5ba59908
do safe area insetting on UICollectionView the "right" way, fixes #581
2017-10-16 09:41:56 -04:00
James Sherlock
edf76f42f3
Add ability to delete comments ( #530 )
...
* Add alert action to delete comments, add viewerCanDelete variable
[skip ci]
* Add delete confirmation message
* Enable networking for deleting comments
* Updates as per @BasThomas feedback
* Update comment, oops
2017-10-14 14:41:45 -04:00
Ryan Nystrom
5b17a19ae3
fix array OOB mismatch from #542
2017-10-14 12:30:32 -04:00
Bas Broek
105336275a
Use model.count instead of users.count which caps at 3 ( #542 )
...
* Use model.count instead of users.count which caps at 3
* Add tests for reactionDetailLabel
2017-10-14 12:11:55 -04:00
Weyert de Boer
1ffda90eae
Renamed Strings.swift to Constants.swift ( #517 )
...
* Renamed `Strings.swift` to `Constants.swift`, fixes #498
Added the product urls to `Constants.swift`, partly fixes #494
* Wrapped the strings in a `Strings`-enum
* Really shouldn't manually retype things
* Update project.pbxproj
2017-10-14 11:06:25 -04:00
James Sherlock
ba4a0713ec
Add support for shortening GitHub issues links ( #531 )
...
* Add support for shortening GitHub issues links
Relates to #411
* Added Tests
2017-10-13 19:42:23 -04:00
James Sherlock
d85cb91f07
Add support for GIFs in comments ( #547 )
2017-10-13 19:41:39 -04:00
Ryan Nystrom
4adfad92c8
flip didRemove guard
2017-10-13 18:38:58 -04:00
Ryan Nystrom
7d17e59609
prevent over reacting (lol), fixes #492 #510
2017-10-13 18:34:55 -04:00
Weyert de Boer
a1810c0529
Search for Inbox ( #503 )
...
* Added the generic SearchBar section controller
Added a helper method for searching notifications
* Strip the unwanted characters from the search query
2017-10-13 18:14:21 -04:00
Weyert de Boer
4d1d5f330b
Fixed a bunch of compiler warnings ( #505 )
...
* Fixed a bunch of compiler warnings
* Update UIColor+Hex.swift
2017-10-09 09:27:32 -04:00
Ryan Nystrom
cfd93c14a0
resuable cancel action, text view config, MD actions menu and control, init edit comments
2017-10-08 20:53:40 +01:00
Ryan Nystrom
ae17aac55c
add global cache for image and html caching, fixes #495
2017-10-08 10:45:23 +01:00
Ryan Nystrom
1c38ff4d5c
swift 4 migration
2017-10-07 14:46:10 +01:00
Ryan Nystrom
2df96426dc
quicker reaction dismiss animation
2017-10-03 21:48:36 +02:00
Ryan Nystrom
ce14d5118b
animated reactions
2017-10-03 21:30:26 +02:00
Ryan Nystrom
dcbdc98667
refactor rx cell to separate count and emoji labels
2017-10-03 16:51:13 +02:00
Ivan Magda
f8d0cc7f12
Move duplicate share UIAlertActions to AlertAction struct #359 ( #431 )
...
* Move duplicate share UIAlertActions to AlertActions struct #359
Create helper AlertActions struct for convenient UIAlertAction's instantiation.
* Create AlertActionBuilder #359
The AlertActionBuilder is used to create custom UIAlertAction's with constituent parts.
* Create UIAlertController+Action #359
UIAlertController+Action extension provide a convinient way for adding actions into the UIAlertController.
* Move additional UIAlertAction duplicates into AlertAction #359
* NewIssueTableViewController: Use correct titles for alert actions #359
Use "Go back" and "Discard" titles instead of "No" and "Yes".
* IssueCommentSectionController: Refactor alert actions #359
* SettingsViewController: Refactor onSignOut alert actions #359
2017-09-29 16:21:17 -04:00
Ryan Nystrom
fb4a4ee69c
center ... with avatar in comments, fixes #461
2017-09-28 19:36:45 -04:00
Ryan Nystrom
1b0e09c5f9
thread viewerCanUpdate for each comment
2017-09-27 22:33:42 -04:00
Ryan Nystrom
e29b0c06da
pipe raw md to comment models
2017-09-27 22:17:42 -04:00
Ryan Nystrom
582e3e224f
fix table height bug, fixes #438
2017-09-27 21:45:39 -04:00
Ryan Nystrom
e9dad512e8
comment "send to" feature, fixes #393
2017-09-27 21:27:29 -04:00
Ryan Nystrom
3542ca3951
owner/repo/#123 shorthand, part of #146
2017-09-26 22:59:43 -04:00
Ryan Nystrom
bd7750c28a
fix paging broken on repo issues
2017-09-26 22:05:29 -04:00
Ryan Nystrom
b339731834
image size respects aspect ratio, fixes #417
2017-09-26 22:03:17 -04:00
Ryan Nystrom
6aaa097c9c
fix local image paths, fixes #314
2017-09-26 21:32:46 -04:00
Rizwan Mohamed Ibrahim
2a770c6a1b
Fixes referenced issue view controller being pushed without nav bar ( #423 )
...
* Fixes referenced issue view controller being pushed without nav bar
* Fixes referenced issue view controller being pushed without nav bar from Issues Review
2017-09-25 10:34:01 -04:00
Ryan Nystrom
d65796f5b0
table rows calculated height based on text
2017-09-20 22:11:42 -04:00
Bas Broek
15f41c94af
Prefer interpolation over concatenation
2017-09-20 19:02:32 +02:00
Ryan Nystrom
e8160beb00
haptic feedback on reaction
2017-09-17 21:06:08 -04:00
Ryan Nystrom
abb1411e46
local, optimistic emoji mutations
2017-09-17 20:32:25 -04:00
Ryan Nystrom
1592d9b29b
intro parsing options
2017-09-17 17:41:29 -04:00
Ryan Nystrom
3acd485807
Merge pull request #315 from rnystrom/relativeImages
...
Allow relative images to display in README files
2017-09-17 17:07:39 -04:00
Ryan Nystrom
0196c8f318
Merge pull request #308 from weyert/fixed/emoji-issue
...
Added the pod `HTMLString`, fixes #307
2017-09-17 16:54:31 -04:00
Ryan Nystrom
50b59a2ddb
Update IssueCommentTableModel.swift
2017-09-17 16:54:17 -04:00
James Sherlock
1f849bfcdd
Allow raw images to display in README files
2017-09-17 16:31:44 +01:00
Ryan Nystrom
81a9a167ce
shorthand issues are tappable to push new issue VC
2017-09-16 23:34:12 -04:00
Weyert de Boer
c599b851a8
Added the pod HTMLString
...
Updated the Markdown parsing so it calls `HTMLString`'s `removingHTMLEntities`-method so the html entities get converted to the real deal like a Emoji
Fixed the issue that the height of a table row was hard-coded to `30` now it's being calculated and the biggest tone is used for all other rows
2017-09-15 00:04:56 +02:00
Ryan Nystrom
8b8b22d4b2
setting to append githawk signature to comments
2017-09-13 14:15:36 -04:00
Ryan Nystrom
691188fc04
hide webview while loading content
2017-09-11 09:07:52 -04:00
Ryan Nystrom
7f0616aa8d
check path extension for svg instead of url suffix
2017-09-11 08:51:05 -04:00
Ryan Nystrom
1f029ad43c
fallback svg images to webviews
2017-09-10 23:41:56 -04:00
Ryan Nystrom
5b5c9f3b7c
disallow spaces after brackets for inline links, fixes #175
2017-09-07 23:27:05 -04:00
Ryan Nystrom
f6f03effd7
fix html sizing KVO (again)
2017-09-05 23:13:56 -04:00
