* clean up title model
* update title style
* organize issue SC method
* remove background colors from styled text in issues
* collection view bg white
* remove card inset and clean up snap superview code
* clean up label design
* thread is root and change base font size
* remove borders on comment cells
* adjust collapse design
* adjust comment line spacing and make non-root body smaller
* refactor detail view
* viewer header background color
* more buttons in reaction cell
* vertical spacers working
* design basically finished;
* scroll to bottom accounts for inset
* PR review background color white
* fixup PR review comments
* spacing on merge and review
* readme background white
* rename to just "spacer"
* horizontal spacing
* fix tests
* replace old markdown callsites
* unit tests working
* remove unused parsing
* final removal of old parsing, build and tests succeed
* remove dependency
* capture readme ref branch
* add cmark lib, build succeeds
* building and running (with dupe asserts)
* list newlines, quote styles
* tables working in cmark
* fix table bg color math and code bg color
* code block highlighting only when theres a language
* share code block logic
* mentions need @
* update cmark lib
* shortlinks
* detect issue shortlinks
* simplify and correct shortlinks
* remove html comments
* tests passing
* milestones refactored with styled text
* reference refactored
* refactor commit references
* fix styled text bug
* request event refactored
* refactor titles
* warm caches for bg-gen models
* delete old text cell
* move shortlinks into MMMarkdown
* almost there
* build green
* running and trimming whitespaces
* styled text working
* fix tests
* tests passing
* add assets
* put marker for checked and unchecked
* attachment working
* export smaller assets
* use lighter blue for checked
* thread can-update, undo accident
* nudge down checkmark attachment
* add tests
* Update client keys to use environment vars
* Extra logging to assist with debugging
* Add other files to test target (temporary solution)
* Update Project Target References
* Add arguments and share scheme
* Disable failing FBSnapshot tests
* If at first you fail, wait 20 minutes for a build and then try again
* Update test to also ensure it's not using the template keys
* Update gitignore
* Remove intentional failing test
* revert pod changes
* revert podfile
* Picked up the easy bits of Ryan's review #855
- Replaced "// MARK: -" with "// MARK:"
- Added final to classes
- Added newlines for readability
- Computed and stored diffIdentifier of BookmarkViewModel
* Removed NSObject from BookmarkViewModel
* Moved icon logic to the configure block of the BookmarkCell
* Unified store behavior, new bookmark model
- Added a `Store` protocol to the project with default implementations
that should be sufficient for most models. (#855)
- Switched images in the notification type category to #imageLiterals,
so we can avoid the optionality of the image.
* Implemented BookMark ViewModel
* Created Bookmark Collection Cell
* Created Bookmark View Controller
Done:
- Displays empty state
- Displays bookmarks
- Allows for adding of new bookmarks
- Navigating to bookmarks
In flight:
- Clear All
TODO:
- Search
- Cleanup old files & remove SwipeCell hacks
* Unified search and clear all behavior
The search bar and clear all buttons between the search and bookmarks
page had different styles and behavior. This PR:
- Makes a generic clear-all header
- Gives one to each VC
- Makes them behave the same to the user re: visibility etc
* Re-implemented filter
* Deleted old files
* Attributed String Sizing
* Removed bookmark store tests
* Reloading bookmarks & namespacing
Can now reload bookmarks through the listener pattern (#773, #783).
Bookmark store is now correctly namespaced again.
* [ADD] Bookmarks for repo, issues and pull request
* [FIX] Bookmark model decoding from archive
* [ADD] Clear all option for bookmarks
* [ADD] Search bookmarks with search bar
* [ADD] Swipe to delete for bookmarks (only when search bar is not active)
* [ADD] Bookmark cell accessible and some cleanup
* [ADD] Incorporate review comments
* [ADD] Reuse notification type instead of bookmark type
* [ADD] Incorporate review comments
- Enum over struct on bookmark model
- Github bookmark tab icon
- Smooth deselection, Single tap to scroll to top, cleanup
-
* WIP: Basic image upload for bug reports
* Added image upload UI, Improved flow, Sped up process, Accurate information is passed through
* Improved navigation structure and transitions
* Tidy up of code, enable actual submission to Imgur
* Update to use table view
* Minor changes as per @BasThomas code review
* Remove all classes from Test target, Added @testable
Should fix Buddybuild issues
* Tweaks as per Ryan code review, Moved image upload logic to shared controller, added flag to toggle upload action
