* Unified store behavior, new bookmark model
- Added a `Store` protocol to the project with default implementations
that should be sufficient for most models. (#855)
- Switched images in the notification type category to #imageLiterals,
so we can avoid the optionality of the image.
* Implemented BookMark ViewModel
* Created Bookmark Collection Cell
* Created Bookmark View Controller
Done:
- Displays empty state
- Displays bookmarks
- Allows for adding of new bookmarks
- Navigating to bookmarks
In flight:
- Clear All
TODO:
- Search
- Cleanup old files & remove SwipeCell hacks
* Unified search and clear all behavior
The search bar and clear all buttons between the search and bookmarks
page had different styles and behavior. This PR:
- Makes a generic clear-all header
- Gives one to each VC
- Makes them behave the same to the user re: visibility etc
* Re-implemented filter
* Deleted old files
* Attributed String Sizing
* Removed bookmark store tests
* Reloading bookmarks & namespacing
Can now reload bookmarks through the listener pattern (#773, #783).
Bookmark store is now correctly namespaced again.
* [ADD] Bookmarks for repo, issues and pull request
* [FIX] Bookmark model decoding from archive
* [ADD] Clear all option for bookmarks
* [ADD] Search bookmarks with search bar
* [ADD] Swipe to delete for bookmarks (only when search bar is not active)
* [ADD] Bookmark cell accessible and some cleanup
* [ADD] Incorporate review comments
* [ADD] Reuse notification type instead of bookmark type
* [ADD] Incorporate review comments
- Enum over struct on bookmark model
- Github bookmark tab icon
- Smooth deselection, Single tap to scroll to top, cleanup
-
