Commit Graph

19 Commits

Author SHA1 Message Date
Ivan Smetanin
ade56a81a1 Fix preferredContentSizeCategory called on background thread issue (#2037) 2018-08-05 11:37:03 -04:00
Ryan Nystrom
e56c29a9a6 Redesigned Issues interface (#1983)
* clean up title model

* update title style

* organize issue SC method

* remove background colors from styled text in issues

* collection view bg white

* remove card inset and clean up snap superview code

* clean up label design

* thread is root and change base font size

* remove borders on comment cells

* adjust collapse design

* adjust comment line spacing and make non-root body smaller

* refactor detail view

* viewer header background color

* more buttons in reaction cell

* vertical spacers working

* design basically finished;

* scroll to bottom accounts for inset

* PR review background color white

* fixup PR review comments

* spacing on merge and review

* readme background white

* rename to just "spacer"

* horizontal spacing

* fix tests
2018-07-27 11:03:09 -04:00
Ryan Nystrom
e9899fb935 Delete NSAttributedStringSizing (#1826)
* Delete NSAttributedStringSizing

* compile
2018-05-21 11:15:38 -04:00
Ryan Nystrom
178d7700b7 Remove MMMarkdown dependency (#1729)
* replace old markdown callsites

* unit tests working

* remove unused parsing

* final removal of old parsing, build and tests succeed

* remove dependency

* capture readme ref branch
2018-04-14 23:12:03 -04:00
Ryan Nystrom
5fd68c1e6a Rewrite markdown parsing with cmark (#1704)
* add cmark lib, build succeeds

* building and running (with dupe asserts)

* list newlines, quote styles

* tables working in cmark

* fix table bg color math and code bg color

* code block highlighting only when theres a language

* share code block logic

* mentions need @

* update cmark lib

* shortlinks

* detect issue shortlinks

* simplify and correct shortlinks

* remove html comments

* tests passing
2018-04-07 23:27:14 -04:00
Ryan Nystrom
62e2763a85 Refactor markdown parsing to use text lib (#1674)
* milestones refactored with styled text

* reference refactored

* refactor commit references

* fix styled text bug

* request event refactored

* refactor titles

* warm caches for bg-gen models

* delete old text cell

* move shortlinks into MMMarkdown

* almost there

* build green

* running and trimming whitespaces

* styled text working

* fix tests

* tests passing
2018-03-31 10:12:51 -04:00
Ryan Nystrom
66dc61ace0 Refactor labeled events to use StyledText (#1659)
* refactor tap handling on attributed views

* styled cell interaction working

* share menu code

* label events finished
2018-03-18 14:55:57 -04:00
Ryan Nystrom
65959c7c14 Card inset design completely overhauled (#1396)
* card inset design completely overhauled

* respond to safe area changes
2018-01-13 12:37:00 -05:00
Ryan Nystrom
0fc619e420 Tapping checkboxes updates the UI and edits on the server (#1272)
* edit checkboxes working

* always can update when editing

* edit comment sent to client
2017-12-17 09:19:19 -05:00
Ryan Nystrom
3de0859b2e open fullscreen images when tapping web view (#1106) 2017-11-28 20:20:48 -05:00
Ryan Nystrom
53b0db103c Use IGListCollectionViewLayout (#932)
* Use IGListCollectionViewLayout

* use layout category and add comment
2017-11-13 21:17:38 -05:00
Ryan Nystrom
7a91200d3b Revert "Use ListCollectionViewLayout for VC lists" (#912)
* Revert "Open GitHub Status when tapping cell (#905)"

This reverts commit 8e14a5642b.

* Revert "Increased tap target for ... buttons (#909)"

This reverts commit 160705a724.

* Revert "Comment cell images don't scale to fit (#903)"

This reverts commit 4adf511ea4.

* Revert "Fixed styling and alignment issues (#898)"

This reverts commit 34083c9ede.

* Revert "Use ListCollectionViewLayout for VC lists (#892)"

This reverts commit 2eb12b2dd5.
2017-11-09 10:38:25 -05:00
Ryan Nystrom
2eb12b2dd5 Use ListCollectionViewLayout for VC lists (#892) 2017-11-07 20:39:29 -05:00
Hesham Salman
f213bac924 Thin SwiftLint ruleset (#704)
* Thin SwiftLint ruleset

* Disabled trailing_whitespace rule
2017-10-23 16:58:09 -04:00
Ryan Nystrom
1c38ff4d5c swift 4 migration 2017-10-07 14:46:10 +01:00
Ryan Nystrom
b339731834 image size respects aspect ratio, fixes #417 2017-09-26 22:03:17 -04:00
Ryan Nystrom
1592d9b29b intro parsing options 2017-09-17 17:41:29 -04:00
Ryan Nystrom
81a9a167ce shorthand issues are tappable to push new issue VC 2017-09-16 23:34:12 -04:00
Ryan Nystrom
84cc9fa2e2 preview mode working 2017-08-01 00:53:36 -04:00