Commit Graph

78 Commits

Author SHA1 Message Date
Ivan Smetanin
ade56a81a1 Fix preferredContentSizeCategory called on background thread issue (#2037) 2018-08-05 11:37:03 -04:00
Ryan Nystrom
e56c29a9a6 Redesigned Issues interface (#1983)
* clean up title model

* update title style

* organize issue SC method

* remove background colors from styled text in issues

* collection view bg white

* remove card inset and clean up snap superview code

* clean up label design

* thread is root and change base font size

* remove borders on comment cells

* adjust collapse design

* adjust comment line spacing and make non-root body smaller

* refactor detail view

* viewer header background color

* more buttons in reaction cell

* vertical spacers working

* design basically finished;

* scroll to bottom accounts for inset

* PR review background color white

* fixup PR review comments

* spacing on merge and review

* readme background white

* rename to just "spacer"

* horizontal spacing

* fix tests
2018-07-27 11:03:09 -04:00
Ryan Nystrom
3028081c3c Migrate Toast component to new Squawk CocoaPod library (#1900)
* add Squawk lib

* delete Toast

* Build green

* fix build after rebase
2018-07-14 18:26:47 -04:00
Ryan Nystrom
c97598be84 People menu in IGListKit+Swift (#1851)
* Create new people with IGLK+Swift, fix AX+l18n, fix bug where cant remove people

* smaller font for people cell
2018-06-03 18:10:46 -04:00
Ryan Nystrom
87882cbc30 show error message when cannot react (#1852) 2018-06-03 18:10:38 -04:00
Ryan Nystrom
ae26f96f76 Only display repo-allowed merge methods on PRs (#1817)
* update to latest GQL schema

* remove deprecated GQL

* add merge-allowed APIs

* wire up merge methods

* remove pref type if changed
2018-05-19 19:08:10 -04:00
Yury Bogdanov
4127535cdf Merge branch 'master' into feature/1389_pr_branches
# Conflicts:
#	Classes/Issues/IssuesViewController.swift
2018-04-08 15:03:19 +03:00
Ryan Nystrom
62e2763a85 Refactor markdown parsing to use text lib (#1674)
* milestones refactored with styled text

* reference refactored

* refactor commit references

* fix styled text bug

* request event refactored

* refactor titles

* warm caches for bg-gen models

* delete old text cell

* move shortlinks into MMMarkdown

* almost there

* build green

* running and trimming whitespaces

* styled text working

* fix tests

* tests passing
2018-03-31 10:12:51 -04:00
Ryan Nystrom
66dc61ace0 Refactor labeled events to use StyledText (#1659)
* refactor tap handling on attributed views

* styled cell interaction working

* share menu code

* label events finished
2018-03-18 14:55:57 -04:00
Yury Bogdanov
1a10b7e315 Merge branch 'master' into feature/1389_pr_branches 2018-03-18 09:05:50 +03:00
Ryan Nystrom
83acbea441 Start refactoring text views with StyledText (#1658)
* refactoring with styledtext

* issue rename refactored

* fix tests
2018-03-17 18:55:08 -04:00
Yury Bogdanov
78f761390e requests
fetchBranches method removed
2018-03-18 00:20:38 +03:00
Yury Bogdanov
1428663700 GraphQL
- added base branch reference to GraphQL query
- removed previous base branch request implementation
- IssuesViewController adopted new request implementation
2018-03-18 00:20:17 +03:00
Yury Bogdanov
e1289f733e displaying data
Displaying branches in IssuesViewController
2018-03-13 22:39:33 +03:00
Yury Bogdanov
8fd55d3ba2 request
requesting pull request information in IssuesViewController
2018-03-13 21:52:09 +03:00
Ryan Nystrom
45335eb4a0 [WIP] Refactor networking to shared lib (#1602)
* [WIP] Refactor networking to shared lib

* notification models as codable and tests

* default request params

* break out into files

* fix tests

* check notification values

* add milestones

* add milestone response

* repo notifications

* refactor v3 response

* refactor to support passing response to response initializer

* add release fetch and model

* add examples from githawk

* notifications working

* almost all notifications requests migrated

* finish notification migration, add graphql request/response

* replace issue requests

* replace milestones request

* fetch assignees migrated

* readme fetch migrated

* migrate badge request

* delete unused request from client

* remove paging

* nearly done w/ migration

* local build green

* refactor gql fetches, replace mutations

* build green, slim down client

* strip session manager from client

* everything working
2018-03-04 21:35:36 -05:00
Ryan Nystrom
0b9508493e [WIP] Merge PRs (#1511)
* display merge status

* refactor merge button and wire up interactivity

* wire up merge type selection

* merge working
2018-02-15 22:30:14 -05:00
Ryan Nystrom
eb7069f6f7 Refactor date formatting from String (#1229)
* refactor date formatting from String

* undo new file
2017-12-16 22:16:01 -05:00
Ryan Nystrom
7008971a1b Show file change count and additions/deletions on PRs (#1187)
* add additions and deletions to PR, thread

* setup ui
2017-12-04 22:04:52 -05:00
Ryan Nystrom
0f8b76e8c7 Milestone progress view (#1186)
* add open/total count and thread

* show milestone progress indicator

* adjust constraints
2017-12-04 22:04:44 -05:00
Ryan Nystrom
1d3b6169ad Add and remove PR reviewers (#1122)
* refactor models for managing

* refactor people mutation to use assign or reviewers

* fix bug when removing reviewers

* tune spacing
2017-12-02 15:23:20 -05:00
Ryan Nystrom
7bc969a5f5 PR patch files use base list VC (#1092)
* PR patch files use base list VC

* white bg on cell

* remove dead code, update schema, thread file count
2017-11-27 13:07:58 -05:00
Ryan Nystrom
a45fdb3bd4 warm label event size caches (#1090) 2017-11-26 12:34:29 -05:00
James Sherlock
a504a87033 Use AttributedStringCell for IssueLabeledCell (#1071)
* Use AttributedStringCell for IssueLabeledCell

* Code review changes
2017-11-26 12:31:27 -05:00
Ryan Nystrom
8f88e430a9 Add and remove assignees (#1011)
* add and remove assignees

* add bottom view so there arent trailing separators
2017-11-20 17:22:31 -05:00
Ryan Nystrom
c8029a0dcd Add optimistic label events (#982) 2017-11-18 16:46:50 -05:00
Ryan Nystrom
3019c3c725 Use collab permissions endpoint to check collab status (#966)
* Use collab permissions endpoint to check collab status

* handle forbidden and errors

* parse permissions into an enum

* remove values, use defaults
2017-11-18 11:53:47 -05:00
Ryan Nystrom
710dae0388 Manage milestones on issues & PRs (#954)
* setup for mutating milestones on issues

* finish milestones
2017-11-16 08:46:35 -05:00
Ryan Nystrom
f272f08135 Move label editing to a managing control with collaborator request (#936)
* Move label editing to a managing control with collaborator request

* tighten spacing on chevron

* move action cell to top-right, highlight states, action icons
2017-11-15 15:12:53 -05:00
Ryan Nystrom
1fee729885 Fix incorrect state sent to status API (#917) 2017-11-10 16:27:50 -05:00
Ryan Nystrom
4733859946 Open PR comments in another VC (#828)
* WIP PR comments

* thread comment count to PR review model

* PR review comments in another VC
2017-11-04 21:46:21 -04:00
James Sherlock
63cc844b0a Use repository default branch rather than master for file view (#849) 2017-11-04 21:42:54 -04:00
Ryan Nystrom
b39e998d5b Issues use FlatCache for optimistic state changes (#796)
* add Cachable conformance to IssueResult

* refactor issue VC to use flat cache

* update issue feed with FlatCache hooks

* unlock/lock optimistic flow using flat cache mutations

* open/close responses use flat cache

* local status cleanup
2017-10-31 21:31:50 -07:00
Ryan Nystrom
94e1125408 Trim page sizes for GQL requests (#794) 2017-10-29 15:04:56 -04:00
Hesham Salman
f213bac924 Thin SwiftLint ruleset (#704)
* Thin SwiftLint ruleset

* Disabled trailing_whitespace rule
2017-10-23 16:58:09 -04:00
Ryan Nystrom
357e7e1bde Finish wiring up edit comments (#594) 2017-10-18 12:14:17 -04:00
James Sherlock
edf76f42f3 Add ability to delete comments (#530)
* Add alert action to delete comments, add viewerCanDelete variable

[skip ci]

* Add delete confirmation message

* Enable networking for deleting comments

* Updates as per @BasThomas feedback

* Update comment, oops
2017-10-14 14:41:45 -04:00
James Sherlock
e818cd1e88 Add ability to lock/unlock issues (#528)
Closes #143
2017-10-13 19:39:52 -04:00
Ryan Nystrom
8d6f0ab118 upgrade apollo to 0.6.5 and codegen to 0.16.5 2017-10-07 13:30:46 +01:00
Ryan Nystrom
1b0e09c5f9 thread viewerCanUpdate for each comment 2017-09-27 22:33:42 -04:00
Rizwan Mohamed Ibrahim
79cc91ae68 Adds "view repository" alert action from Issues (#425) 2017-09-25 12:46:17 -04:00
Ryan Nystrom
57604bf92b restore label editing perms to "can update" 2017-09-25 10:29:49 -04:00
Ryan Nystrom
e941dc3aed disable commenting when cannot admin and locked 2017-09-24 09:07:21 -04:00
Ryan Nystrom
27c659400d refactor networking to use indicator when using gql 2017-09-17 20:45:44 -04:00
Ryan Nystrom
81a9a167ce shorthand issues are tappable to push new issue VC 2017-09-16 23:34:12 -04:00
Ryan Nystrom
72d2de0c2e tweak close behavior 2017-08-27 22:51:34 -07:00
Ryan Nystrom
cd69f64aa8 remove milestone progress graphics since gql doesnt support it 2017-08-27 22:33:43 -07:00
Ryan Nystrom
f25ce83780 refactor for single Result type 2017-08-27 20:41:01 -04:00
Ryan Nystrom
54c8f0c73f close and reopen issue/pr 2017-08-27 20:02:40 -04:00
Ryan Nystrom
e02de3c496 refactor issue actions into functions 2017-08-27 19:26:12 -04:00