Commit Graph

36 Commits

Author SHA1 Message Date
Ehud Adler
6e1b004372 Resign keyboard search (#2077)
* Project icon

* Resign keyboard
2018-08-10 12:00:11 -04:00
Ivan Smetanin
ade56a81a1 Fix preferredContentSizeCategory called on background thread issue (#2037) 2018-08-05 11:37:03 -04:00
Ryan Nystrom
e5e31bcd31 Better bookmark assets (#2004) 2018-07-29 19:29:59 -04:00
Ryan Nystrom
1ac9348852 update to new StyledTextKit lib name (#1849) 2018-06-02 23:14:11 -04:00
Ryan Nystrom
f8b8a977d6 Update StyledText with new highlight API (#1844) 2018-05-30 22:28:32 -04:00
Ryan Nystrom
bca41482ba Merge pull request #1803 from GitHawkApp/synthesized-equatable
Synthesize Equatable conformances
2018-05-11 09:11:14 -04:00
Ryan Nystrom
de801c5601 Merge pull request #1780 from GitHawkApp/vulnerability-support
Add support for vulnerability alerts
2018-05-10 09:09:25 -04:00
Bas Broek
1507b17025 Synthesize Equatable conformances 2018-05-10 10:36:08 +02:00
BrianLitwin
27b83b666d update bookmark nav item state between viewDidLoad and Issue Load (#1791) 2018-05-07 20:26:59 -07:00
Bas Broek
1a795e028c Add a security vulnerability notification type 2018-05-01 21:43:19 +02:00
Orta
6dc2988d23 Port to Xcode 9.3 (#1696) 2018-04-07 23:24:51 -04:00
Ryan Nystrom
62e2763a85 Refactor markdown parsing to use text lib (#1674)
* milestones refactored with styled text

* reference refactored

* refactor commit references

* fix styled text bug

* request event refactored

* refactor titles

* warm caches for bg-gen models

* delete old text cell

* move shortlinks into MMMarkdown

* almost there

* build green

* running and trimming whitespaces

* styled text working

* fix tests

* tests passing
2018-03-31 10:12:51 -04:00
Ryan Nystrom
83acbea441 Start refactoring text views with StyledText (#1658)
* refactoring with styledtext

* issue rename refactored

* fix tests
2018-03-17 18:55:08 -04:00
Ryan Nystrom
1012faf943 Release notifications (#1546)
* releases WIP

* loading releases working
2018-02-26 22:37:06 -08:00
Rizwan Mohamed Ibrahim
891d84d2ee [CHOR] Delete old bookmark model and cleanup folder structure (#1589) 2018-02-26 22:23:46 -08:00
Hesham Salman
1e2e0c1698 Chore/bookmark rewrite (#865)
* Unified store behavior, new bookmark model

- Added a `Store` protocol to the project with default implementations
  that should be sufficient for most models. (#855)
- Switched images in the notification type category to #imageLiterals,
  so we can avoid the optionality of the image.

* Implemented BookMark ViewModel

* Created Bookmark Collection Cell

* Created Bookmark View Controller

Done:
  - Displays empty state
  - Displays bookmarks
  - Allows for adding of new bookmarks
  - Navigating to bookmarks

In flight:
  - Clear All

TODO:
  - Search
  - Cleanup old files & remove SwipeCell hacks

* Unified search and clear all behavior

The search bar and clear all buttons between the search and bookmarks
page had different styles and behavior. This PR:
  - Makes a generic clear-all header
  - Gives one to each VC
  - Makes them behave the same to the user re: visibility etc

* Re-implemented filter

* Deleted old files

* Attributed String Sizing

* Removed bookmark store tests

* Reloading bookmarks & namespacing

Can now reload bookmarks through the listener pattern (#773, #783).
Bookmark store is now correctly namespaced again.
2017-11-06 09:03:29 -05:00
Ryan Nystrom
eb0e887f09 Fix bookmarks tests (#871) 2017-11-05 17:58:43 -05:00
Ryan Nystrom
0158f3f582 Empty view for bookmarks (#851)
* Empty state background for Bookmarks

* psd changes
2017-11-04 21:47:41 -04:00
James Sherlock
63cc844b0a Use repository default branch rather than master for file view (#849) 2017-11-04 21:42:54 -04:00
Rizwan Mohamed Ibrahim
1b9a8b2740 Bookmark cell dynamic size and fix swipe to delete crash (#819)
* [FIX] Bookmark cell dynamic size and fix swipe to delete crash

* [FIX] Dynamic size-ing for bookmark cell

* [FIX] Init style for bookmark cell
2017-11-04 10:58:56 -04:00
Rizwan Mohamed Ibrahim
66481af678 Sorted/Ordered Bookmarks (#825)
* [ADD] Sort bookmarks before converting into Array

* Changes from Set<BookmarkModel> to NSMutableOrderedSet
2017-11-04 10:54:34 -04:00
Ryan Nystrom
aa15d3e6d5 Remove iOS 11 navigation titles (#816) 2017-10-31 22:02:53 -07:00
Rizwan Mohamed Ibrahim
684d643d46 Update bookmarks without reloading view (#783)
* [FIX] Update bookmarks without reloading view

* [ADD] Listener wrapper and fix speeling mistake

* [ADD] BookmarksStoreListener tests
2017-10-31 19:59:37 -07:00
Ryan Nystrom
f0efae3317 Inject bookmarks, cleanup (#780) 2017-10-27 11:35:19 -04:00
Rizwan Mohamed Ibrahim
7f743af503 Fixes bookmark search behaviours (#729)
* [FIX] Bookmark search  for iOS 11 and 10

* [ADD] hide the search bar under the nav bar for iOS 11
2017-10-27 10:55:46 -04:00
Rizwan Mohamed Ibrahim
199ce48047 [ADD] Bookmarks per user account (#738) 2017-10-27 10:55:22 -04:00
Hesham Salman
51a76fc50c Unified deletion swipes (#720)
* nified cell

standardized cell style

* Made swipe delete action generic

* Fixed clear all button behavior

* Added attributed string

* Cleanup

* Resolved merge conflicts
2017-10-24 23:08:49 -04:00
Rizwan Mohamed Ibrahim
fba236450b Adds options to remove bookmark (#696)
* [ADD] options to remove bookmark

* [ADD] Move bookmark actions to bottom of action sheet
2017-10-24 21:43:22 -04:00
Rizwan Mohamed Ibrahim
40091dd4a1 [ADD] Large title for bookmarks with search controller (#692) 2017-10-24 21:40:35 -04:00
Bas Broek
073fab0bde Merge branch 'master' into text-fixes 2017-10-24 05:43:22 +02:00
Hesham Salman
38252844cf Removed cell dividers, added bg color (#690) 2017-10-23 17:32:51 -04:00
Rizwan Mohamed Ibrahim
0aacad0ae3 [FIX] scroll to top for bookmarks screen (#693) 2017-10-23 17:06:53 -04:00
Hesham Salman
f213bac924 Thin SwiftLint ruleset (#704)
* Thin SwiftLint ruleset

* Disabled trailing_whitespace rule
2017-10-23 16:58:09 -04:00
Bas Broek
609151d013 Remove erroneous double localization 2017-10-22 22:53:05 +02:00
Bas Broek
359794debf Some general text improvements 2017-10-22 22:49:52 +02:00
Rizwan Mohamed Ibrahim
bd10b4e032 Add Bookmarks tab (#601)
* [ADD] Bookmarks for repo, issues and pull request

* [FIX] Bookmark model decoding from archive

* [ADD] Clear all option for bookmarks

* [ADD] Search bookmarks with search bar

* [ADD] Swipe to delete for bookmarks (only when search bar is not active)

* [ADD] Bookmark cell accessible and some cleanup

* [ADD] Incorporate review comments

* [ADD] Reuse notification type instead of bookmark type

* [ADD] Incorporate review comments
- Enum over struct on bookmark model
- Github bookmark tab icon
- Smooth deselection, Single tap to scroll to top, cleanup
-
2017-10-22 14:00:50 -04:00