237 Commits

Author SHA1 Message Date
Ryan Nystrom
7d3298a7c9 disable the send button when text is empty (#2088) 2018-08-11 14:51:11 -04:00
Ryan Nystrom
8a8da143b5 new send button position (#2066) 2018-08-08 21:54:20 -04:00
Ryan Nystrom
4be9a9328e Add insets to readme (#2038)
* fix build error from #2037

* inset readmes
2018-08-05 12:19:45 -04:00
Ivan Smetanin
ade56a81a1 Fix preferredContentSizeCategory called on background thread issue (#2037) 2018-08-05 11:37:03 -04:00
Ryan Nystrom
27ebb18b06 improved send UI, quieter merge buttons (#2001) 2018-07-29 19:29:25 -04:00
Ryan Nystrom
e56c29a9a6 Redesigned Issues interface (#1983)
* clean up title model

* update title style

* organize issue SC method

* remove background colors from styled text in issues

* collection view bg white

* remove card inset and clean up snap superview code

* clean up label design

* thread is root and change base font size

* remove borders on comment cells

* adjust collapse design

* adjust comment line spacing and make non-root body smaller

* refactor detail view

* viewer header background color

* more buttons in reaction cell

* vertical spacers working

* design basically finished;

* scroll to bottom accounts for inset

* PR review background color white

* fixup PR review comments

* spacing on merge and review

* readme background white

* rename to just "spacer"

* horizontal spacing

* fix tests
2018-07-27 11:03:09 -04:00
Rodrigo Bermúdez Schettino
bd6bbe2cf9 Add space when replying to issue comment (#1959)
Fixes #1930.
2018-07-21 07:57:38 -04:00
Ryan Nystrom
c9a21b1bef fix crash from management refactor (#1915) 2018-07-15 19:56:10 -04:00
Ryan Nystrom
1daf87fc86 New ContextMenu UX for managing Issues & PRs (#1912)
* wip

* New managing UX using ContextMenu
2018-07-15 19:50:01 -04:00
Ryan Nystrom
3028081c3c Migrate Toast component to new Squawk CocoaPod library (#1900)
* add Squawk lib

* delete Toast

* Build green

* fix build after rebase
2018-07-14 18:26:47 -04:00
Ryan Nystrom
f3f3d45ff2 Autocompelte for issue search (#1903) 2018-07-14 18:22:49 -04:00
Ryan Nystrom
faca5497a8 New Inbox design (#1870)
* New Inbox design

* rename ident to number

* use ax animation

* building with old notifications removed

* remove "2" suffix

* use latest IGLK+Swift

* apply IGLK perf fixes

* fix build

* Update with IGLK binding bug fix
2018-06-17 14:47:59 -04:00
Ryan Nystrom
0388cb9227 Fix bottom clipping on message view (#1855) 2018-06-03 16:57:45 -04:00
BrianLitwin
450025f571 show issueMergeSectionController only if issue is open (#1848) 2018-06-02 20:36:14 -04:00
BrianLitwin
27b83b666d update bookmark nav item state between viewDidLoad and Issue Load (#1791) 2018-05-07 20:26:59 -07:00
Ryan Nystrom
e33fd79617 less thrashy loading spinner 2018-04-15 12:45:12 -04:00
Joan Disho
a33a3f69ea support the case for IssueTargetBranchModel (#1720) 2018-04-11 10:10:30 -04:00
Joan Disho
641d7e6cc3 refactor the code 2018-04-10 11:42:52 +02:00
Joan Disho
eab6797d47 quote a substring of the comment and mention the user in messageView on reply. 2018-04-10 11:42:52 +02:00
Joan Disho
b0fefae3ab focus on the comment on reply action 2018-04-10 11:42:52 +02:00
Joan Disho
2a7664968b make messageView firstResponder onReply action 2018-04-10 11:42:52 +02:00
Yury Bogdanov
22a4c5ee2a New text system adopted
- changed NSAttributedStringSizing to StyledTextRenderer (IssueTargetBranchModel)
- Removed redundand code from IssuesViewController
- Changed method for text height in IssueBranchesSectionController
2018-04-08 15:23:25 +03:00
Yury Bogdanov
4127535cdf Merge branch 'master' into feature/1389_pr_branches
# Conflicts:
#	Classes/Issues/IssuesViewController.swift
2018-04-08 15:03:19 +03:00
Ryan Nystrom
62e2763a85 Refactor markdown parsing to use text lib (#1674)
* milestones refactored with styled text

* reference refactored

* refactor commit references

* fix styled text bug

* request event refactored

* refactor titles

* warm caches for bg-gen models

* delete old text cell

* move shortlinks into MMMarkdown

* almost there

* build green

* running and trimming whitespaces

* styled text working

* fix tests

* tests passing
2018-03-31 10:12:51 -04:00
Yury Bogdanov
1428663700 GraphQL
- added base branch reference to GraphQL query
- removed previous base branch request implementation
- IssuesViewController adopted new request implementation
2018-03-18 00:20:17 +03:00
Yury Bogdanov
f0d46a5be5 cleanup
commented code removed
2018-03-15 21:49:40 +03:00
Yury Bogdanov
2e3a8d7f52 text setup
text setup moved to IssueTargetBranchModel
2018-03-15 21:45:46 +03:00
Yury Bogdanov
e9f26dc1f2 ui
moved branches label higher
2018-03-13 23:22:25 +03:00
Yury Bogdanov
e1289f733e displaying data
Displaying branches in IssuesViewController
2018-03-13 22:39:33 +03:00
Yury Bogdanov
8fd55d3ba2 request
requesting pull request information in IssuesViewController
2018-03-13 21:52:09 +03:00
Bas Broek
39dcc7145e Accessibility improvements (#1603)
* Add an a11y hint to the navigationbar title

* Improve accessibility for merge contexts

* Improve accessibility for merge summaries

* Improve accessibility for the merge button
2018-03-04 21:36:48 -05:00
Ryan Nystrom
45335eb4a0 [WIP] Refactor networking to shared lib (#1602)
* [WIP] Refactor networking to shared lib

* notification models as codable and tests

* default request params

* break out into files

* fix tests

* check notification values

* add milestones

* add milestone response

* repo notifications

* refactor v3 response

* refactor to support passing response to response initializer

* add release fetch and model

* add examples from githawk

* notifications working

* almost all notifications requests migrated

* finish notification migration, add graphql request/response

* replace issue requests

* replace milestones request

* fetch assignees migrated

* readme fetch migrated

* migrate badge request

* delete unused request from client

* remove paging

* nearly done w/ migration

* local build green

* refactor gql fetches, replace mutations

* build green, slim down client

* strip session manager from client

* everything working
2018-03-04 21:35:36 -05:00
Luciano Almeida
83a2ffe6bd Removing #available conditionals (#1578) 2018-02-26 22:24:08 -08:00
Ryan Nystrom
ead9e86618 smarter auto scroll to last element (#1519) 2018-02-15 22:52:48 -05:00
Ryan Nystrom
0b9508493e [WIP] Merge PRs (#1511)
* display merge status

* refactor merge button and wire up interactivity

* wire up merge type selection

* merge working
2018-02-15 22:30:14 -05:00
Ryan Nystrom
ec4807d415 Reply to Pull Request Review comments (#1483)
* wip

* reply cell shows up in comments

* focus on reply model and scroll to reply

* api to create PR comment replies

* reply working

* clean and code reuse

* even more reuse

* organize
2018-02-04 19:08:34 -05:00
Ivan Magda
0455ab5694 Remove SlackTextViewController (#1390)
* Remove SlackTextViewController #1319

* Replace SLKTextView with UITextView #1319

* Move placeholder from MessageView into MessageTextView (#1319)

* Use new placeholder API for MessageView (#1319)

* Use MessageTextView (#1319)

- Use MessageTextView instead of plain UITextView
- Drop code for showing placeholder label
- Use MessageTextView's placeholder label
2018-01-20 11:51:02 -05:00
Ryan Nystrom
57e0f09670 Fix bad link for profiles (#1424) 2018-01-16 19:50:31 -05:00
Bas Broek
671ffe8d72 Distinguish owner from repository in dropdown actionsheet (#1411)
* Distinguish between owner and repo in action sheet

* Bonus: fix test warning
2018-01-14 12:11:44 -05:00
Ryan Nystrom
ca3bc322a7 New navigation title dropdown control (#1399)
* create new nav view

* issue nav title wired up

* more button now system action

* better sized bookmark assets

* wire up title actions on repo

* tweak compression UI

* revert helper hack
2018-01-13 15:54:20 -05:00
Ryan Nystrom
65959c7c14 Card inset design completely overhauled (#1396)
* card inset design completely overhauled

* respond to safe area changes
2018-01-13 12:37:00 -05:00
Ryan Nystrom
a585324f11 author can close their own issues and PRs (#1378) 2018-01-09 12:01:07 -05:00
Ryan Nystrom
dfb877ecc3 fix bottom scroll offset positions (#1370) 2018-01-06 12:43:36 -05:00
Ryan Nystrom
93256e1a60 scroll to last element minus action menu on comment and notification 2018-01-05 22:00:09 -05:00
Ryan Nystrom
755be5af2e Refactor autocomplete control and wire it up in comment editing (#1326)
* refactor text view delegate to be 1:many

* move autocomplete stuff to its own controller + API

* refactor VC to work with new autocomplete controller

* update pods with new message stuff

* reorganize and fixup files

* app builds

* better names

* thread autocomplete to comment SC

* autocomplete working in edit

* finish refactor
2018-01-02 09:14:28 -05:00
Ryan Nystrom
56864889a7 Manage button scrolls to bottom to reveal actions (#1327)
* new prototype of managing UX

* add tested helper for calculating item width without hanging chad

* adjust math to even last row when theres a chad
2018-01-02 07:15:48 -05:00
Ryan Nystrom
685e61f374 setup message control after feed is loaded (#1311) 2017-12-27 13:56:04 -05:00
Ryan Nystrom
7aee23d415 new send icon, finish wiring up control (#1309) 2017-12-26 23:37:58 -05:00
Ryan Nystrom
b3ec648b2a New UITextView control to replace SlackTextViewController (#1307)
* init new text view lib

* autocomplete finding

* autocomplete working

* add caching

* new message VC working
2017-12-24 17:42:11 -05:00
Bas Broek
377161aed0 Fix Int format crash + unify String localization (#1273)
* Use %d over %zi to prevent a possible crash

* Clean up / unify localization behavior

Before, we were doing double localization (Feeding a `LocalizedString` into a `.localizedStringWithFormat`).
2017-12-17 16:10:57 -05:00