Commit Graph

1747 Commits

Author SHA1 Message Date
Ryan Nystrom
cec09518b7 open issue from notification 2018-10-09 22:23:50 -04:00
Ryan Nystrom
caf86a5087 Always update shortcuts on app launch (#2248) 2018-10-08 22:21:52 -04:00
Ryan Nystrom
b2d5b5f519 Simpler logic for review access button handling (#2249) 2018-10-08 22:21:42 -04:00
Brian Litwin
b70e2649a0 PeopleVC: Sort users with self first (#2246)
- moves sorting logic from fetch(page:) into type method
- unit test
2018-10-08 11:42:31 -04:00
Rizwan Mohamed Ibrahim
93e70b0d4f [FIX] Settings write review indent (#2242) 2018-10-08 08:10:18 -04:00
Ryan Nystrom
64f920a3f0 new routing library and refactor shortcuts (#2241) 2018-10-07 23:46:57 -04:00
Ashley Ng
c45b35e721 use edge inset to right align image (#2232) 2018-10-07 16:00:48 -04:00
Ashley Ng
5c94d98cf6 Adds more share actions when browsing a repository (#2161) (#2237)
* add additional share actions

* fix share URLs
2018-10-07 16:00:14 -04:00
Ryan Nystrom
e2b2bc9d47 Huge refactor of AppDelegate and authentication routing (#2238)
* refactor with new app controller, replace root nav mgr

* finish refactoring out root nav mgr

* remove root mgr
2018-10-07 15:59:18 -04:00
Ryan Nystrom
a5ed67a924 Fix readme duplicate identifier asserts (#2219)
* WIP to fix readme asserts

* remove newline

* improved markdown parsing working

* fix tests
2018-10-04 20:58:07 -04:00
Brian Litwin
cfdd6d1388 Order repo branches after fetch (#2228)
* Order repo branches after fetch
- added func to order branches + unit tests
- replaced 'var branch: String' w/ 'private(set) var selectedBranch: String'
& added a defaultBranch variable
- changed fetch(page:) to update(animated:) in didSelect(value:) - an oversight from original pr

* AX animation
2018-10-04 19:27:17 -04:00
Brian Litwin
4bb4bc6244 set spinner color in RepoBranchVC (#2221) 2018-10-03 13:21:37 -04:00
dtranmobil
ceaee75563 Update Setup.md (#2218)
Grammatical change to md
2018-10-02 21:45:42 -04:00
Ryan Nystrom
d43139484f Localize Inbox Zero and allow for per-year holidays (#2215) 2018-10-02 21:45:25 -04:00
Brian Litwin
c62ce4a62d change repo branch (#2202)
* change repo branch

additions:
- A change-repository-branch workflow thats very similar to the workflow in Milestones
- GraphQL query to fetch a repo's branches

modifications:
- a mutable "branch" string in RepositoryOverviewController and RepositoryCodeDirectoryViewController
- updated the V3RepositoryReadME fetch to include a branch parameter
- a protocol RepositoryBranchUpdatable to flag and update the appropriate ViewControllers when a user switches branches
- ContextMenu and UIAlertAction setup
- Removed some outdated code to get a repo's branch name from fetch(page:) in RepositoryOverviewViewController
- Added a line feed.adapter.reloadData() in fetch(page:) because app was crashing intermittently after a user switched branches without that line - was always an IGListKit duplicate identifier error on StyledTextRenderers  -  to reproduce, remove the feed.adapter.reloadData(), go to https://github.com/TheAlgorithms/Python, try to switch branches and the app will crash. I'm working raising an issue for it.

* requested changes

- changed public var to private(set) for var branch: String
- removed wasteful feed.adapter.reloadData() call
- re-formated params in switchBranchAction()

* style nit
2018-09-30 15:25:01 -04:00
Ryan Nystrom
d94eb86199 Fix entitlements path (#2211) 2018-09-30 00:39:44 -04:00
Ehud Adler
14aef44d19 Settings cell textColor (#2193)
* Set API Status cell textColor to custom (Matching the rest of the settings page)

* Updated Double Tap Reaction off color to custom

* Updated Enabled textColor to custom

* Updated reaction textColors to proper custom

* Switched all labels to settingsLabels
2018-09-30 00:30:59 -04:00
Ehud Adler
64fa20864d Fixed cell border on merge button (#2204)
* Fixed cell border on merge button

* Fixed nits
2018-09-30 00:15:18 -04:00
Ryan Nystrom
a23f2b5e19 Move entitlements to Resources (#2209) 2018-09-30 00:15:03 -04:00
Ryan Nystrom
dc01bf9ea0 Restore readme images after assets move (#2210) 2018-09-30 00:14:58 -04:00
Ryan Nystrom
c65877a15c Delete AppStore.md 2018-09-30 00:10:21 -04:00
Ryan Nystrom
f9ec9575da Delete appcenter-post-clone.sh 2018-09-30 00:10:09 -04:00
Ryan Nystrom
cdd988f952 move designs to own repo (#2208) 2018-09-30 00:09:50 -04:00
Ehud Adler
3193097ca4 Switched to constants (#2207) 2018-09-30 00:09:41 -04:00
Ehud Adler
1029698c2b Move lock (#2206)
* Moves lock under divider

* fix param style

* Update IssueManagingContextController.swift
2018-09-30 00:09:11 -04:00
Ehud Adler
3ebd279d55 fixed icon name (#2203) 2018-09-30 00:01:24 -04:00
Ryan Nystrom
c5ec7728b0 move blog to own repo (#2205) 2018-09-29 23:54:10 -04:00
Ryan Nystrom
965bb2fa4f Delete CNAME 2018-09-29 23:43:10 -04:00
Ryan Nystrom
7b07463321 Use updatedAt time to key notification send times (#2201)
* Use updatedAt time to key notification send times

* better formatting and fix tests
2018-09-29 14:09:11 -04:00
Ryan Nystrom
6c6c9476e1 Attempt to fix iTunes Connect issue where watchOS needs min target (#2173)
* attempt to fix iTunes Connect issue where watchOS needs min target

* fix podfile
2018-09-28 19:20:01 -04:00
Ryan Nystrom
cf09107576 Fortify local notifications code (#2191)
* move path/defaults to be injected

* remove unused defaults

* add tests for notification db, fix settings, avoid dupe inbox requests

* better tests, fix dupe insert bug
2018-09-28 17:31:34 -04:00
Ehud Adler
3eb648a6a8 Merge button status (#2189)
* Addresses #2178
Shows merge status without button when you cannot merge.

* Swift naming
2018-09-28 16:52:00 -04:00
Brian Litwin
cbb20f8e0e allows setting Milestone's loading indicator's color (#2195)
* allows setting loading indicator's color

* updated spinner color to .white in Milestones/Labels/People
2018-09-28 16:51:30 -04:00
Ehud Adler
95a20d997b Fixed color issue. (#2188) 2018-09-28 07:54:16 -04:00
certainly
da2dc16462 fix double tap tab invalid (#2192)
this bug is caused by the time interval between two taps which is too small.
2018-09-28 07:50:37 -04:00
Ryan Nystrom
ef468a8583 Add TestFlight link to README (#2194)
* Add TestFlight link to README

* Update README.md
2018-09-27 21:13:11 -04:00
Drew Volz
bb2d56a214 grammatical change to code signing instructions (#2186) 2018-09-26 08:00:20 +02:00
Ehud Adler
05fe58394c Action Controller images (#2135)
* Add images to action controller

* Added pod to podfile
Added icon to NotificationSectionController

* Installed Pod

* ContextMenu Dominant corner

* Target support files

* Fixed support

* Updated Action Image Controller
2018-09-24 11:00:41 -04:00
Brian Litwin
fd2ed27ab6 adds review GitHubAccess button to notifications view controller (#2176) 2018-09-24 10:56:59 -04:00
Ehud Adler
966cb1a4d1 Load Consistency (#2159)
* Combine 2 load cells into 1

* Fixed load more in BaseViewController

* Switch if-else to ternary
2018-09-22 14:45:25 -04:00
Ehud Adler
6974a7583f Fixes bug where send button is enabled after sending a comment (#2158) 2018-09-22 14:44:57 -04:00
Ehud Adler
facd09d28b Added activity indicator (#2157) 2018-09-22 14:44:43 -04:00
Talip Göksu
919138089e Add UIAppearance styling for UISwitch & UISearchBar (#2144)
* Add(UIAppearance styling for UISwitch)

* Add(UIAppearance for UISearchBar)
2018-09-22 14:43:59 -04:00
Ryan Nystrom
b489e8db97 Local push notifications (#2145)
* add fmdb

* add local notification cache mechanism

* rewiring to update local db when fetching notifications

* local pushes working

* building for xcode 10
2018-09-22 14:40:35 -04:00
Ehud Adler
f131dc6525 Don't override entire message when replying (#2160) 2018-09-14 06:54:19 -04:00
Ryan Nystrom
5c6d48bca4 Replace "Inbox Zero" functionality and remove Firebase (#2142)
* simpler inbox zero date that allows date planning

* clean up

* remove firebase
2018-08-25 21:47:43 -04:00
Ryan Nystrom
be79f4c9eb bump version to 1.23 (#2143) 2018-08-25 21:47:29 -04:00
Rodrigo Bermúdez Schettino
fc619ebe30 Add issue template for bug report (#2131)
Use GitHub template.
2018-08-19 22:28:35 -04:00
Rodrigo Bermúdez Schettino
143ed3bccb Add issue template for feature request (#2132)
Use GitHub template.
2018-08-19 22:28:10 -04:00
Heath Borders
8a545e4588 Fixed s/nuber/number/ typo in SECURITY.md (#2130) 2018-08-19 10:38:50 +02:00