Commit Graph

99 Commits

Author SHA1 Message Date
BrianLitwin
6b42450c51 lines up contextMenu labels (#2082) 2018-08-10 18:02:50 -04:00
Ryan Nystrom
b37db3a98b restore system color divider line for ipad (#1989) 2018-07-28 17:01:48 -04:00
Bas Broek
4d0644e6e0 Fix indentation from 813e091996 2018-07-28 18:34:51 +02:00
Ehud Adler
813e091996 [Issue #1923] Added color to constrastContext struct (#1938) 2018-07-28 10:41:32 -04:00
Talip Göksu
eb19255d97 Initial ContextMenu cells made accessibility buttons (#1951)
* Add(Button as accessibilityTrait so it reads out that it is a button)

* Fix(Change assign button)

* Fix(add isAccessibilityElement boolean)
2018-07-20 11:53:08 -04:00
Ryan Nystrom
2483726ff8 add done button to menu VCs (#1934) 2018-07-19 09:23:00 -04:00
Ryan Nystrom
1daf87fc86 New ContextMenu UX for managing Issues & PRs (#1912)
* wip

* New managing UX using ContextMenu
2018-07-15 19:50:01 -04:00
Ryan Nystrom
8452d73ab9 Display empty notification cell (#1884) 2018-06-25 08:59:10 -04:00
Ryan Nystrom
faca5497a8 New Inbox design (#1870)
* New Inbox design

* rename ident to number

* use ax animation

* building with old notifications removed

* remove "2" suffix

* use latest IGLK+Swift

* apply IGLK perf fixes

* fix build

* Update with IGLK binding bug fix
2018-06-17 14:47:59 -04:00
Ryan Nystrom
c97598be84 People menu in IGListKit+Swift (#1851)
* Create new people with IGLK+Swift, fix AX+l18n, fix bug where cant remove people

* smaller font for people cell
2018-06-03 18:10:46 -04:00
Ryan Nystrom
d7084328f6 Testing out IGLK swift branch (#1743)
* testing out IGLK swift branch

* using local IGListKit, update labels to latest

* new labels working
2018-05-27 11:01:34 -04:00
Ryan Nystrom
e9899fb935 Delete NSAttributedStringSizing (#1826)
* Delete NSAttributedStringSizing

* compile
2018-05-21 11:15:38 -04:00
Ryan Nystrom
e33fd79617 less thrashy loading spinner 2018-04-15 12:45:12 -04:00
Ryan Nystrom
1f03d5e18b Fix flickering when navigating back (#1728) 2018-04-14 23:12:15 -04:00
Orta
6dc2988d23 Port to Xcode 9.3 (#1696) 2018-04-07 23:24:51 -04:00
Ryan Nystrom
62e2763a85 Refactor markdown parsing to use text lib (#1674)
* milestones refactored with styled text

* reference refactored

* refactor commit references

* fix styled text bug

* request event refactored

* refactor titles

* warm caches for bg-gen models

* delete old text cell

* move shortlinks into MMMarkdown

* almost there

* build green

* running and trimming whitespaces

* styled text working

* fix tests

* tests passing
2018-03-31 10:12:51 -04:00
Ryan Nystrom
66dc61ace0 Refactor labeled events to use StyledText (#1659)
* refactor tap handling on attributed views

* styled cell interaction working

* share menu code

* label events finished
2018-03-18 14:55:57 -04:00
Ryan Nystrom
751d4bc4e3 Move session management to local pod and add app group (#1636)
* move session management to local pod and add app group

* copy paste fail from SO
2018-03-11 16:42:15 -04:00
Bas Broek
ddddb6363f Add merge status tests (#1604)
* Add merge status tests

* Introduce containsAll and containsNone

* Rename containsAll to containsOnly
2018-03-04 21:36:25 -05:00
Ryan Nystrom
1012faf943 Release notifications (#1546)
* releases WIP

* loading releases working
2018-02-26 22:37:06 -08:00
Rizwan Mohamed Ibrahim
8fb4200a9a [ADD] Refactoring short cut handler to use enum based Routes (#1591) 2018-02-26 22:23:36 -08:00
Ryan Nystrom
0001920b75 Refactor text styles to use StyledText (#1490) 2018-02-04 19:09:42 -05:00
Bas Broek
6075edcee5 Add "Jump to..." to make an action sheet more expressive (#1405) 2018-01-13 17:21:32 -05:00
Ryan Nystrom
cb15bc47c8 use new dropdown for browsing files (#1400) 2018-01-13 16:37:29 -05:00
Ryan Nystrom
755be5af2e Refactor autocomplete control and wire it up in comment editing (#1326)
* refactor text view delegate to be 1:many

* move autocomplete stuff to its own controller + API

* refactor VC to work with new autocomplete controller

* update pods with new message stuff

* reorganize and fixup files

* app builds

* better names

* thread autocomplete to comment SC

* autocomplete working in edit

* finish refactor
2018-01-02 09:14:28 -05:00
Ryan Nystrom
29f7f67ff8 View notifications by repository (#1291)
* get subscriptions api

* stub subscription ctrl

* use icon bar items, inject inbox type

* wire up repo list

* push notif, show all for repos

* clean path

* fix spinner bar item bugs

* call correct mark-read apis

* alert titles

* sort repos by alpha

* unify show-all callsite

* nits
2017-12-19 10:11:59 -05:00
Ryan Nystrom
20e1b6f6df Design polish (#1275)
* new tab icon design

* more spacing for action cells

* action cells larger, background colors

* fix assignee/reviewer spacing

* label colors, refine header spacing

* bump up label radius

* add close and lock options

* wire up close mutation

* wire up lock

* remove dead code
2017-12-17 16:09:26 -05:00
Bas Broek
0db76b3b76 Add + update a11x for navigation titles (#1257)
* Add + update a11x for navigation items

* A file is not a file extension
2017-12-16 22:15:29 -05:00
Bas Broek
7f04139794 Disable animations when reduce motion enabled (#1167) 2017-12-10 18:15:44 -05:00
Ryan Nystrom
7a60f6a4a0 auto shrink title label (#1169) 2017-12-03 16:59:52 -05:00
Ryan Nystrom
270903e1ae refactor dir and blob paths, add tests (#1165) 2017-12-03 16:36:43 -05:00
Ryan Nystrom
50b6ed7581 actually show an empty state on base list vc (#1140) 2017-12-02 19:16:27 -05:00
Bas Broek
872da1f458 [Cleanup] Remove nil-default completion parameters (#1131)
* Remove nil-default completion parameters

* Remove redundant character trimming
2017-12-02 18:48:32 -05:00
Ryan Nystrom
3724798277 Convert repo code browsing to base VC and IGLK (#1097) 2017-11-27 13:08:44 -05:00
James Sherlock
a504a87033 Use AttributedStringCell for IssueLabeledCell (#1071)
* Use AttributedStringCell for IssueLabeledCell

* Code review changes
2017-11-26 12:31:27 -05:00
Ryan Nystrom
a313f6e110 reference commit cells use attr string cell (#1068) 2017-11-23 11:30:06 -05:00
Joe Rocca
ca9c9df1df Tightened right bar items (#916)
* tightened right bar items, closes #896

* added UIBarButtonItem and UIPopoverPresentationController extensions
2017-11-10 12:39:40 -05:00
Hesham Salman
1e2e0c1698 Chore/bookmark rewrite (#865)
* Unified store behavior, new bookmark model

- Added a `Store` protocol to the project with default implementations
  that should be sufficient for most models. (#855)
- Switched images in the notification type category to #imageLiterals,
  so we can avoid the optionality of the image.

* Implemented BookMark ViewModel

* Created Bookmark Collection Cell

* Created Bookmark View Controller

Done:
  - Displays empty state
  - Displays bookmarks
  - Allows for adding of new bookmarks
  - Navigating to bookmarks

In flight:
  - Clear All

TODO:
  - Search
  - Cleanup old files & remove SwipeCell hacks

* Unified search and clear all behavior

The search bar and clear all buttons between the search and bookmarks
page had different styles and behavior. This PR:
  - Makes a generic clear-all header
  - Gives one to each VC
  - Makes them behave the same to the user re: visibility etc

* Re-implemented filter

* Deleted old files

* Attributed String Sizing

* Removed bookmark store tests

* Reloading bookmarks & namespacing

Can now reload bookmarks through the listener pattern (#773, #783).
Bookmark store is now correctly namespaced again.
2017-11-06 09:03:29 -05:00
Ryan Nystrom
2ca2cfb9dc Better FlatCache usage in notifications (#795)
* Better FlatCache usage in notifications

* fix paging bug on notifications
2017-10-31 21:31:20 -07:00
Ryan Nystrom
0dd568396a Add title/subtitle header style and use for Issues (#761) 2017-10-27 10:46:18 -04:00
Ryan Nystrom
8276fc5492 Bookmark tab icons (#727)
* Bookmark tab icons

* tweak so inner star is slightly smaller
2017-10-24 23:46:17 -04:00
Bas Broek
073fab0bde Merge branch 'master' into text-fixes 2017-10-24 05:43:22 +02:00
Hesham Salman
f213bac924 Thin SwiftLint ruleset (#704)
* Thin SwiftLint ruleset

* Disabled trailing_whitespace rule
2017-10-23 16:58:09 -04:00
Bas Broek
359794debf Some general text improvements 2017-10-22 22:49:52 +02:00
Hesham Salman
ad6caa286d Swapped Bar Button Items (#644)
Catpitalization
2017-10-22 14:01:18 -04:00
Rizwan Mohamed Ibrahim
bd10b4e032 Add Bookmarks tab (#601)
* [ADD] Bookmarks for repo, issues and pull request

* [FIX] Bookmark model decoding from archive

* [ADD] Clear all option for bookmarks

* [ADD] Search bookmarks with search bar

* [ADD] Swipe to delete for bookmarks (only when search bar is not active)

* [ADD] Bookmark cell accessible and some cleanup

* [ADD] Incorporate review comments

* [ADD] Reuse notification type instead of bookmark type

* [ADD] Incorporate review comments
- Enum over struct on bookmark model
- Github bookmark tab icon
- Smooth deselection, Single tap to scroll to top, cleanup
-
2017-10-22 14:00:50 -04:00
Ryan Nystrom
5bae4ba89d [WIP] Add FlatCache lib and use for Notifications (#632)
* init FlatCache lib

* tests for all other cases

* install flatcache to freeitme project, move VM creation into client

* refactor and split up inbox design

* fixup flatcache pod
2017-10-22 00:08:42 -04:00
Bas Broek
980fba6cc0 Move some hardcoded "Search"es to Constants (#616) 2017-10-21 20:35:57 -04:00
Ryan Nystrom
357e7e1bde Finish wiring up edit comments (#594) 2017-10-18 12:14:17 -04:00
Ryan Nystrom
deb937ef00 only filter notifications at end so inbox zero doesnt show up on empty results 2017-10-14 12:11:43 -04:00