480 Commits

Author SHA1 Message Date
Ryan Nystrom
c23945ac7d Enable SwiftLint and fix issues (#2292)
* update swiftlint

* build with lint enabled

* fix almost all warnings

* remove wholemodule
2018-10-16 21:54:55 -04:00
Ryan Nystrom
c9f5254183 move background handling into feed for better state control (#2285) 2018-10-13 23:09:24 -04:00
Ryan Nystrom
18de137111 Button to display Push Notification info in Settings (#2282)
* Add push notification info in settings

* better sizing
2018-10-13 13:41:01 -04:00
Ryan Nystrom
fbb223f5f1 open issue from notification (#2259) 2018-10-09 23:19:48 -04:00
Ryan Nystrom
64f920a3f0 new routing library and refactor shortcuts (#2241) 2018-10-07 23:46:57 -04:00
Ryan Nystrom
e2b2bc9d47 Huge refactor of AppDelegate and authentication routing (#2238)
* refactor with new app controller, replace root nav mgr

* finish refactoring out root nav mgr

* remove root mgr
2018-10-07 15:59:18 -04:00
Brian Litwin
cfdd6d1388 Order repo branches after fetch (#2228)
* Order repo branches after fetch
- added func to order branches + unit tests
- replaced 'var branch: String' w/ 'private(set) var selectedBranch: String'
& added a defaultBranch variable
- changed fetch(page:) to update(animated:) in didSelect(value:) - an oversight from original pr

* AX animation
2018-10-04 19:27:17 -04:00
Brian Litwin
c62ce4a62d change repo branch (#2202)
* change repo branch

additions:
- A change-repository-branch workflow thats very similar to the workflow in Milestones
- GraphQL query to fetch a repo's branches

modifications:
- a mutable "branch" string in RepositoryOverviewController and RepositoryCodeDirectoryViewController
- updated the V3RepositoryReadME fetch to include a branch parameter
- a protocol RepositoryBranchUpdatable to flag and update the appropriate ViewControllers when a user switches branches
- ContextMenu and UIAlertAction setup
- Removed some outdated code to get a repo's branch name from fetch(page:) in RepositoryOverviewViewController
- Added a line feed.adapter.reloadData() in fetch(page:) because app was crashing intermittently after a user switched branches without that line - was always an IGListKit duplicate identifier error on StyledTextRenderers  -  to reproduce, remove the feed.adapter.reloadData(), go to https://github.com/TheAlgorithms/Python, try to switch branches and the app will crash. I'm working raising an issue for it.

* requested changes

- changed public var to private(set) for var branch: String
- removed wasteful feed.adapter.reloadData() call
- re-formated params in switchBranchAction()

* style nit
2018-09-30 15:25:01 -04:00
Ryan Nystrom
d94eb86199 Fix entitlements path (#2211) 2018-09-30 00:39:44 -04:00
Ryan Nystrom
a23f2b5e19 Move entitlements to Resources (#2209) 2018-09-30 00:15:03 -04:00
Ryan Nystrom
cf09107576 Fortify local notifications code (#2191)
* move path/defaults to be injected

* remove unused defaults

* add tests for notification db, fix settings, avoid dupe inbox requests

* better tests, fix dupe insert bug
2018-09-28 17:31:34 -04:00
Ehud Adler
05fe58394c Action Controller images (#2135)
* Add images to action controller

* Added pod to podfile
Added icon to NotificationSectionController

* Installed Pod

* ContextMenu Dominant corner

* Target support files

* Fixed support

* Updated Action Image Controller
2018-09-24 11:00:41 -04:00
Ehud Adler
966cb1a4d1 Load Consistency (#2159)
* Combine 2 load cells into 1

* Fixed load more in BaseViewController

* Switch if-else to ternary
2018-09-22 14:45:25 -04:00
Talip Göksu
919138089e Add UIAppearance styling for UISwitch & UISearchBar (#2144)
* Add(UIAppearance styling for UISwitch)

* Add(UIAppearance for UISearchBar)
2018-09-22 14:43:59 -04:00
Ryan Nystrom
b489e8db97 Local push notifications (#2145)
* add fmdb

* add local notification cache mechanism

* rewiring to update local db when fetching notifications

* local pushes working

* building for xcode 10
2018-09-22 14:40:35 -04:00
Ryan Nystrom
5c6d48bca4 Replace "Inbox Zero" functionality and remove Firebase (#2142)
* simpler inbox zero date that allows date planning

* clean up

* remove firebase
2018-08-25 21:47:43 -04:00
Ryan Nystrom
be79f4c9eb bump version to 1.23 (#2143) 2018-08-25 21:47:29 -04:00
Ryan Nystrom
e7386183de Reactions with ContextMenu (#2112)
* reactions with ContextMenu

* Remove dead code

* add haptics

* slightly faster presentation for reactions
2018-08-14 09:47:18 -04:00
Ryan Nystrom
e2b967b4d2 Switches share style, fix default reaction padding (#2095) 2018-08-11 22:54:30 -04:00
Ryan Nystrom
28b76e61e1 Clean up reactions settings (#2084) 2018-08-11 13:50:36 -04:00
Ryan Nystrom
4be9a9328e Add insets to readme (#2038)
* fix build error from #2037

* inset readmes
2018-08-05 12:19:45 -04:00
Ryan Nystrom
5070f605f2 replace signature with badge (#2003) 2018-07-29 19:29:49 -04:00
Ryan Nystrom
2abec91b05 Make inbox buttons more tappable (#1990)
* Make inbox buttons more tappable

* add missing file
2018-07-28 17:04:35 -04:00
Ryan Nystrom
b37db3a98b restore system color divider line for ipad (#1989) 2018-07-28 17:01:48 -04:00
Ryan Nystrom
e56c29a9a6 Redesigned Issues interface (#1983)
* clean up title model

* update title style

* organize issue SC method

* remove background colors from styled text in issues

* collection view bg white

* remove card inset and clean up snap superview code

* clean up label design

* thread is root and change base font size

* remove borders on comment cells

* adjust collapse design

* adjust comment line spacing and make non-root body smaller

* refactor detail view

* viewer header background color

* more buttons in reaction cell

* vertical spacers working

* design basically finished;

* scroll to bottom accounts for inset

* PR review background color white

* fixup PR review comments

* spacing on merge and review

* readme background white

* rename to just "spacer"

* horizontal spacing

* fix tests
2018-07-27 11:03:09 -04:00
Yury Bogdanov
d1ffd0bbd5 [Issue#1579] login animation (#1977)
* added animation to bird

* added rotating branches

* selfreview: methods renamed
2018-07-26 09:06:49 -04:00
Ryan Nystrom
2483726ff8 add done button to menu VCs (#1934) 2018-07-19 09:23:00 -04:00
Ryan Nystrom
1daf87fc86 New ContextMenu UX for managing Issues & PRs (#1912)
* wip

* New managing UX using ContextMenu
2018-07-15 19:50:01 -04:00
Ryan Nystrom
3028081c3c Migrate Toast component to new Squawk CocoaPod library (#1900)
* add Squawk lib

* delete Toast

* Build green

* fix build after rebase
2018-07-14 18:26:47 -04:00
Ryan Nystrom
f3f3d45ff2 Autocompelte for issue search (#1903) 2018-07-14 18:22:49 -04:00
Ryan Nystrom
faca5497a8 New Inbox design (#1870)
* New Inbox design

* rename ident to number

* use ax animation

* building with old notifications removed

* remove "2" suffix

* use latest IGLK+Swift

* apply IGLK perf fixes

* fix build

* Update with IGLK binding bug fix
2018-06-17 14:47:59 -04:00
Ryan Nystrom
76f9b95817 Remove old menu VCs (#1879)
* remove old menu VCs

* move files

* rename label cell since its already taken

* move label VC

* rename all "2" classes
2018-06-16 18:42:40 -04:00
Ryan Nystrom
58c4ce4af0 Bump to version 1.22.0 (#1871) 2018-06-16 18:41:53 -04:00
Ryan Nystrom
c97598be84 People menu in IGListKit+Swift (#1851)
* Create new people with IGLK+Swift, fix AX+l18n, fix bug where cant remove people

* smaller font for people cell
2018-06-03 18:10:46 -04:00
Ryan Nystrom
8a009a6668 Milestones menu in IGListKit+Swift (#1853)
* Milestones menu in IGListKit+Swift

* layout tweak and vc title
2018-06-03 16:58:02 -04:00
Ryan Nystrom
1ac9348852 update to new StyledTextKit lib name (#1849) 2018-06-02 23:14:11 -04:00
Ryan Nystrom
a38dd5ada9 Fix IGListKit branch archive breakage (#1837) 2018-05-29 08:22:03 -04:00
Ryan Nystrom
d7084328f6 Testing out IGLK swift branch (#1743)
* testing out IGLK swift branch

* using local IGListKit, update labels to latest

* new labels working
2018-05-27 11:01:34 -04:00
BrianLitwin
650756fe1d updates add reviewers url path (#1832) 2018-05-25 19:50:28 -04:00
Ryan Nystrom
e9899fb935 Delete NSAttributedStringSizing (#1826)
* Delete NSAttributedStringSizing

* compile
2018-05-21 11:15:38 -04:00
Ryan Nystrom
8642d03a51 View raw markdown on comments (#1819) 2018-05-19 19:07:52 -04:00
Bas Broek
344a6c652d Improve Watch app accessibility (#1807)
* Improve accessibility on the Watch app

* Move utilities to their own folder
2018-05-19 12:28:48 -04:00
Ryan Nystrom
ef91d08901 add version as user setting, bump to 1.21.0 (#1810) 2018-05-14 15:49:23 -04:00
BrianLitwin
27b83b666d update bookmark nav item state between viewDidLoad and Issue Load (#1791) 2018-05-07 20:26:59 -07:00
Ryan Nystrom
1ab8df2c6d Fix Watch App Store submission (#1792) 2018-05-06 08:40:05 -07:00
Ryan Nystrom
b02c7cf0ad functioning watch app 2018-04-29 21:38:25 -04:00
Ryan Nystrom
b1c881cddb watch target added and working 2018-04-29 21:36:58 -04:00
Merrick Sapsford
e1ca4fc3ba Update Tabman to 1.8.2 (#1764)
Pageboy 2.5.1
AutoInsetter 1.2.3
2018-04-29 21:33:49 -04:00
Ryan Nystrom
e33fd79617 less thrashy loading spinner 2018-04-15 12:45:12 -04:00
Ryan Nystrom
1f03d5e18b Fix flickering when navigating back (#1728) 2018-04-14 23:12:15 -04:00