32 Commits

Author SHA1 Message Date
Ryan Nystrom
c23945ac7d Enable SwiftLint and fix issues (#2292)
* update swiftlint

* build with lint enabled

* fix almost all warnings

* remove wholemodule
2018-10-16 21:54:55 -04:00
Ryan Nystrom
e56c29a9a6 Redesigned Issues interface (#1983)
* clean up title model

* update title style

* organize issue SC method

* remove background colors from styled text in issues

* collection view bg white

* remove card inset and clean up snap superview code

* clean up label design

* thread is root and change base font size

* remove borders on comment cells

* adjust collapse design

* adjust comment line spacing and make non-root body smaller

* refactor detail view

* viewer header background color

* more buttons in reaction cell

* vertical spacers working

* design basically finished;

* scroll to bottom accounts for inset

* PR review background color white

* fixup PR review comments

* spacing on merge and review

* readme background white

* rename to just "spacer"

* horizontal spacing

* fix tests
2018-07-27 11:03:09 -04:00
Ryan Nystrom
0001920b75 Refactor text styles to use StyledText (#1490) 2018-02-04 19:09:42 -05:00
Ryan Nystrom
65959c7c14 Card inset design completely overhauled (#1396)
* card inset design completely overhauled

* respond to safe area changes
2018-01-13 12:37:00 -05:00
Ryan Nystrom
20e1b6f6df Design polish (#1275)
* new tab icon design

* more spacing for action cells

* action cells larger, background colors

* fix assignee/reviewer spacing

* label colors, refine header spacing

* bump up label radius

* add close and lock options

* wire up close mutation

* wire up lock

* remove dead code
2017-12-17 16:09:26 -05:00
Ryan Nystrom
ed3adf74c5 Polish header spacing (#1228)
* label styles match github.com

* size assignee to content

* size milestones to content

* polish header spacings
2017-12-10 18:13:08 -05:00
Ryan Nystrom
0e3265cc0c Simplify labels (#1205)
* [WIP] Simplify labels

* inset

* cleanup unused stuff

* ax and selection support

* wire up selection delegate
2017-12-09 12:28:13 -05:00
Joe Rocca
1290b83522 added wrapping label view (#1203) 2017-12-08 18:02:44 -05:00
Ryan Nystrom
ab9e0cb9de Improve scroll perf of DotListView, add border (#1135) 2017-12-02 18:48:45 -05:00
Bas Broek
1717b14ab3 Generate accessibility labels for cells (#1052)
* Add accessibility cell label generation

* Replace manual labels with generated ones
2017-11-23 11:30:48 -05:00
Ryan Nystrom
f272f08135 Move label editing to a managing control with collaborator request (#936)
* Move label editing to a managing control with collaborator request

* tighten spacing on chevron

* move action cell to top-right, highlight states, action icons
2017-11-15 15:12:53 -05:00
Hesham Salman
7b25f6acb0 Picked up the easy bits of Ryan's review #865 (#877)
* Picked up the easy bits of Ryan's review #855

- Replaced "// MARK: -" with "// MARK:"
- Added final to classes
- Added newlines for readability
- Computed and stored diffIdentifier of BookmarkViewModel

* Removed NSObject from BookmarkViewModel

* Moved icon logic to the configure block of the BookmarkCell
2017-11-07 08:45:31 -05:00
Hesham Salman
f213bac924 Thin SwiftLint ruleset (#704)
* Thin SwiftLint ruleset

* Disabled trailing_whitespace rule
2017-10-23 16:58:09 -04:00
Joe Rocca
a6275bb5b9 Adds label summary dots to repo issues/PR cell (#622)
* added labelableFields to RepoPages queries

* added labels to RepositoryIssueSummaryModel

* added DotListView

* replaced UICollectionView with DotListView

* added DotListView to RepositorySummaryCell

* fixed max items calculation

* removed constraints and set collection view frame instead
2017-10-22 13:58:51 -04:00
Ryan Nystrom
ca5ba59908 do safe area insetting on UICollectionView the "right" way, fixes #581 2017-10-16 09:41:56 -04:00
Ryan Nystrom
5ecfc19fee replace status bar calls with toast 2017-10-12 21:34:51 -04:00
Ryan Nystrom
1c38ff4d5c swift 4 migration 2017-10-07 14:46:10 +01:00
Ryan Nystrom
571f7c09dc refactor issues to have shared model that can be passed around 2017-08-11 23:27:26 -04:00
Ryan Nystrom
561efb8524 ipad popover for editing labels 2017-08-08 20:00:16 -04:00
Ryan Nystrom
ec8e11b197 add permissions error handling 2017-08-08 16:22:39 -04:00
Ryan Nystrom
38a2f92eed edit labels 2017-08-08 15:27:56 -04:00
Ryan Nystrom
aba2c88505 add edit labels button when updateable 2017-08-06 18:00:33 -04:00
Bas Broek
ff449d24b4 Make the issue label summary a button 2017-07-24 17:59:30 +02:00
Ryan Nystrom
b7c62f5db0 merged event, fixes #9 2017-06-29 15:38:55 -07:00
Ryan Nystrom
2dd7f5e935 use fatalError instead of guard in critical failures 2017-06-26 10:38:21 -04:00
Ryan Nystrom
2dbdce6719 update iglk to 3.0 2017-06-22 22:44:11 -04:00
Ryan Nystrom
6d7fd1cb47 change color to string, add font size consts 2017-06-22 21:44:23 -04:00
Ryan Nystrom
4352faafb7 label and reaction spacing 2017-06-07 16:31:37 -04:00
Ryan Nystrom
fdc9eb9430 status cell, refactor networking 2017-06-04 23:44:39 -04:00
Ryan Nystrom
840f89c131 remove extensions 2017-06-02 14:16:04 -04:00
Ryan Nystrom
5bae0be922 remove genned models that arent in notifications endpoint 2017-06-02 14:02:16 -04:00
Ryan Nystrom
ffa7cc7575 reorganize issues 2017-06-01 00:07:21 -04:00