Commit Graph

152 Commits

Author SHA1 Message Date
Ryan Nystrom
7bc969a5f5 PR patch files use base list VC (#1092)
* PR patch files use base list VC

* white bg on cell

* remove dead code, update schema, thread file count
2017-11-27 13:07:58 -05:00
Ryan Nystrom
bb2828e9c8 share code text view with repo and issue (#1089) 2017-11-26 12:29:21 -05:00
Bas Broek
1717b14ab3 Generate accessibility labels for cells (#1052)
* Add accessibility cell label generation

* Replace manual labels with generated ones
2017-11-23 11:30:48 -05:00
Ryan Nystrom
00414833fd local Tabman to fix inset issues (#923) 2017-11-11 21:53:12 -05:00
Joe Rocca
ca9c9df1df Tightened right bar items (#916)
* tightened right bar items, closes #896

* added UIBarButtonItem and UIPopoverPresentationController extensions
2017-11-10 12:39:40 -05:00
Rizwan Mohamed Ibrahim
ab28e739bc [CHOR] @objc at same line as func (#888) 2017-11-07 13:37:36 -05:00
Ryan Nystrom
33faea80f2 More shared logic for bookmarks in nav item (#884)
* Use even more shared code for bookmarks in nav bar

* correct selected/not logic

* restore image changing in action

* add haptics

* swap actions between add and remove
2017-11-07 09:57:25 -05:00
Rizwan Mohamed Ibrahim
7c23286628 Changes Bookmark action to be a nav bar item (#879)
* Add Bookmark nav items

* [ADD] Bookmark actions to nav right item and remove bookmark alert action

* [ADD] Bookmark nav right item for Repo and remove bookmark alert action

* [CHOR] Clean up old bookmark alert action

* [ADD] Shared function for toggling bookmark
2017-11-07 08:46:12 -05:00
Hesham Salman
1e2e0c1698 Chore/bookmark rewrite (#865)
* Unified store behavior, new bookmark model

- Added a `Store` protocol to the project with default implementations
  that should be sufficient for most models. (#855)
- Switched images in the notification type category to #imageLiterals,
  so we can avoid the optionality of the image.

* Implemented BookMark ViewModel

* Created Bookmark Collection Cell

* Created Bookmark View Controller

Done:
  - Displays empty state
  - Displays bookmarks
  - Allows for adding of new bookmarks
  - Navigating to bookmarks

In flight:
  - Clear All

TODO:
  - Search
  - Cleanup old files & remove SwipeCell hacks

* Unified search and clear all behavior

The search bar and clear all buttons between the search and bookmarks
page had different styles and behavior. This PR:
  - Makes a generic clear-all header
  - Gives one to each VC
  - Makes them behave the same to the user re: visibility etc

* Re-implemented filter

* Deleted old files

* Attributed String Sizing

* Removed bookmark store tests

* Reloading bookmarks & namespacing

Can now reload bookmarks through the listener pattern (#773, #783).
Bookmark store is now correctly namespaced again.
2017-11-06 09:03:29 -05:00
Ryan Nystrom
0851d198d7 Update Tabman with recent bugfixes (#868)
* Update Tabman with recent bugfixes

* remove debug code
2017-11-06 09:01:46 -05:00
Ryan Nystrom
4733859946 Open PR comments in another VC (#828)
* WIP PR comments

* thread comment count to PR review model

* PR review comments in another VC
2017-11-04 21:46:21 -04:00
James Sherlock
63cc844b0a Use repository default branch rather than master for file view (#849) 2017-11-04 21:42:54 -04:00
Nicholas Meschke
306eea70ec Add Cell setup code to an StyledTableCell Extension (#797)
* Add Code Repository Cell extension file

* Move cell setup code to an extension of a StyledTableViewCell

* Add fatalError instead of force unwrap
2017-11-04 10:55:05 -04:00
Ryan Nystrom
e82e23df29 Repo uses title/subtitle (#820) 2017-10-31 23:59:36 -07:00
Ryan Nystrom
18801a1064 Refactor alert titles (#818) 2017-10-31 22:03:15 -07:00
Ryan Nystrom
aa15d3e6d5 Remove iOS 11 navigation titles (#816) 2017-10-31 22:02:53 -07:00
Ryan Nystrom
2ca2cfb9dc Better FlatCache usage in notifications (#795)
* Better FlatCache usage in notifications

* fix paging bug on notifications
2017-10-31 21:31:20 -07:00
Ryan Nystrom
94e1125408 Trim page sizes for GQL requests (#794) 2017-10-29 15:04:56 -04:00
Ryan Nystrom
f0efae3317 Inject bookmarks, cleanup (#780) 2017-10-27 11:35:19 -04:00
Rizwan Mohamed Ibrahim
199ce48047 [ADD] Bookmarks per user account (#738) 2017-10-27 10:55:22 -04:00
Bas Broek
f1768753fd Move Equatable conformances to static funcs (#746) 2017-10-27 10:48:09 -04:00
Bas Broek
baf6ccc18b Improve code browsing accessibility (#748)
* Files are buttons too; added types

* Add accessibility hint for file / directory cells
2017-10-27 10:47:47 -04:00
Ryan Nystrom
2585f2c39a Faster label summary equality for diffing (#725)
* Faster label summary equality for diffing

* actually build & fix errors
2017-10-24 21:58:59 -04:00
Joe Rocca
282a84683b added labels equatable check to ListDiffable isEqual method, fixes #715 (#716) 2017-10-24 21:46:31 -04:00
Rizwan Mohamed Ibrahim
fba236450b Adds options to remove bookmark (#696)
* [ADD] options to remove bookmark

* [ADD] Move bookmark actions to bottom of action sheet
2017-10-24 21:43:22 -04:00
Rizwan Mohamed Ibrahim
40091dd4a1 [ADD] Large title for bookmarks with search controller (#692) 2017-10-24 21:40:35 -04:00
Hesham Salman
f213bac924 Thin SwiftLint ruleset (#704)
* Thin SwiftLint ruleset

* Disabled trailing_whitespace rule
2017-10-23 16:58:09 -04:00
Ryan Nystrom
a78e96c63a Ceiling final height of repo issue cells (#668) 2017-10-22 14:50:00 -04:00
Rizwan Mohamed Ibrahim
bd10b4e032 Add Bookmarks tab (#601)
* [ADD] Bookmarks for repo, issues and pull request

* [FIX] Bookmark model decoding from archive

* [ADD] Clear all option for bookmarks

* [ADD] Search bookmarks with search bar

* [ADD] Swipe to delete for bookmarks (only when search bar is not active)

* [ADD] Bookmark cell accessible and some cleanup

* [ADD] Incorporate review comments

* [ADD] Reuse notification type instead of bookmark type

* [ADD] Incorporate review comments
- Enum over struct on bookmark model
- Github bookmark tab icon
- Smooth deselection, Single tap to scroll to top, cleanup
-
2017-10-22 14:00:50 -04:00
Joe Rocca
a6275bb5b9 Adds label summary dots to repo issues/PR cell (#622)
* added labelableFields to RepoPages queries

* added labels to RepositoryIssueSummaryModel

* added DotListView

* replaced UICollectionView with DotListView

* added DotListView to RepositorySummaryCell

* fixed max items calculation

* removed constraints and set collection view frame instead
2017-10-22 13:58:51 -04:00
Hesham Salman
a52e533b5f User can receive search results while typing (#611)
* Cancelled networking when the cancel button is pressed

* Responded to comments: code formatting & cleanup

* Can now search while typing

Slight formatting changes

* Prevented search term from showing up in recent before search succeeds

* Show loading screen while typing

* Less complicated network cancellation

* Cleaned up groups

* Recently viewed repos (#631)

* Recently Viewed Repos saved in search store

* Styling changes

* Equatable changes and visual updates

* Visually update after selecting a repo

* Rebased

* Slowed down the debouncer a bit
2017-10-22 00:11:12 -04:00
Ryan Nystrom
5bae4ba89d [WIP] Add FlatCache lib and use for Notifications (#632)
* init FlatCache lib

* tests for all other cases

* install flatcache to freeitme project, move VM creation into client

* refactor and split up inbox design

* fixup flatcache pod
2017-10-22 00:08:42 -04:00
Bas Broek
980fba6cc0 Move some hardcoded "Search"es to Constants (#616) 2017-10-21 20:35:57 -04:00
Bas Broek
a6e8ddab47 Adds sharing to code browsing (#602) 2017-10-21 20:31:36 -04:00
Ryan Nystrom
ca5ba59908 do safe area insetting on UICollectionView the "right" way, fixes #581 2017-10-16 09:41:56 -04:00
Ryan Nystrom
1acde1acd4 use empty bg view for file load failures 2017-10-15 15:14:14 -04:00
Ryan Nystrom
5355a93921 show error when loading non-text 2017-10-15 15:02:41 -04:00
Ryan Nystrom
3178fd242e browse repo file blobs 2017-10-15 15:01:01 -04:00
Ryan Nystrom
1f734514a9 browse repo dirs 2017-10-14 15:40:36 -04:00
Ryan Nystrom
a58c26836d add filtering to base list VC 2017-10-14 11:56:23 -04:00
Weyert de Boer
6779557f22 Add search to issues (#506)
* Added the generic SearchBar section controller
Added a helper method for searching notifications

* Strip the unwanted characters from the search query

* Add a first version of searching issues in Repository screen

* Improve the search for the Repository screen

* Improve the filtering of issues by changing the order

* Fixed the compiling issues to make the project compile again
2017-10-14 11:11:07 -04:00
Weyert de Boer
1ffda90eae Renamed Strings.swift to Constants.swift (#517)
* Renamed `Strings.swift` to `Constants.swift`, fixes #498
Added the product urls to `Constants.swift`, partly fixes #494

* Wrapped the strings in a `Strings`-enum

* Really shouldn't manually retype things

* Update project.pbxproj
2017-10-14 11:06:25 -04:00
Ryan Nystrom
34ebd869ad Revert "Added iOS 11 searchController UINavigationItem (#522)"
This reverts commit c32eda7989.
2017-10-13 20:05:16 -04:00
Ryan Nystrom
5ecfc19fee replace status bar calls with toast 2017-10-12 21:34:51 -04:00
Joe Rocca
c32eda7989 Added iOS 11 searchController UINavigationItem (#522)
* added iOS 11 searchController UINavigationItem, fixes #376

* set iOS 11 UINavigationItem largeTitleDisplayMode to never
2017-10-11 13:40:55 -04:00
Ryan Nystrom
22223d1e4b begin code browsing 2017-10-08 21:28:07 +01:00
Ryan Nystrom
cb4cec0c3a fix tabman to 1.0.1 to avoid bugs 2017-10-07 18:37:51 +01:00
Ryan Nystrom
1c38ff4d5c swift 4 migration 2017-10-07 14:46:10 +01:00
Ryan Nystrom
8d6f0ab118 upgrade apollo to 0.6.5 and codegen to 0.16.5 2017-10-07 13:30:46 +01:00
Ryan Nystrom
30c758b4ac new base list VC, refactor repo issues, fixes #493 2017-10-05 22:37:40 +01:00