Repo PRs render PR icon, more whitespace (#2089)

* more spacing in issues/prs

* fix bug where PRs were flagged as issues

* fix invert on bottom padding
This commit is contained in:
Ryan Nystrom
2018-08-11 14:51:29 -04:00
committed by GitHub
parent 568bdd06b2
commit fadf071b03
3 changed files with 4 additions and 4 deletions

View File

@@ -89,7 +89,7 @@ extension RepoSearchPagesQuery.Data.Search.Node.AsPullRequest: RepositoryIssueSu
}
var pullRequest: Bool {
return false
return true
}
var status: IssueStatus {

View File

@@ -14,7 +14,7 @@ import DateAgo
final class RepositorySummaryCell: SelectableCell {
static let titleInset = UIEdgeInsets(
top: Styles.Sizes.rowSpacing,
top: Styles.Sizes.gutter,
left: Styles.Sizes.icon.width + 2*Styles.Sizes.columnSpacing,
bottom: Styles.Sizes.rowSpacing,
right: Styles.Sizes.gutter
@@ -53,7 +53,7 @@ final class RepositorySummaryCell: SelectableCell {
detailsStackView.addArrangedSubview(secondaryLabel)
detailsStackView.addArrangedSubview(labelListView)
detailsStackView.snp.makeConstraints { (make) in
make.bottom.equalTo(contentView).offset(-Styles.Sizes.rowSpacing)
make.bottom.equalTo(contentView).offset(-Styles.Sizes.gutter)
make.left.equalTo(reasonImageView.snp.right).offset(Styles.Sizes.columnSpacing)
make.right.equalTo(contentView.snp.right).offset(-Styles.Sizes.columnSpacing)
}

View File

@@ -36,7 +36,7 @@ final class RepositorySummarySectionController: ListGenericSectionController<Rep
let height = object.title.viewSize(in: width).height
+ Styles.Text.secondary.preferredFont.lineHeight
+ Styles.Sizes.rowSpacing
+ Styles.Sizes.gutter
+ labelListViewHeightAndSpacing
return CGSize(width: width, height: ceil(height))
}