kylefang/GitHawk
1
0
Fork 0
mirror of https://github.com/zhigang1992/GitHawk.git synced 2026-04-17 12:17:27 +08:00
Code Issues Packages Projects Releases Wiki Activity

New navigation title dropdown control (#1399)

Browse Source 
* create new nav view

* issue nav title wired up

* more button now system action

* better sized bookmark assets

* wire up title actions on repo

* tweak compression UI

* revert helper hack
This commit is contained in:
Ryan Nystrom
2018-01-13 15:54:20 -05:00
committed by GitHub
parent f18c1916fc
commit ca3bc322a7
10 changed files with 185 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
Classes/Repository/RepositoryViewController.swift
View File

@@ -75,13 +75,28 @@ NewIssueTableViewControllerDelegate {
})
configureNavigationItems()
let navigationTitle = NavigationTitleDropdownView()
navigationItem.titleView = navigationTitle
navigationTitle.addTarget(self, action: #selector(onNavigationTitle(sender:)), for: .touchUpInside)
let labelFormat = NSLocalizedString("Repository %@ by %@", comment: "Accessibility label for a repository navigation item")
let accessibilityLabel = String(format: labelFormat, arguments: [repo.name, repo.owner])
navigationItem.configure(title: repo.name, subtitle: repo.owner, accessibilityLabel: accessibilityLabel)
navigationTitle.configure(title: repo.name, subtitle: repo.owner, accessibilityLabel: accessibilityLabel)
}
// MARK: Private API
@objc func onNavigationTitle(sender: UIView) {
let alert = UIAlertController.configured(preferredStyle: .actionSheet)
weak var weakSelf = self
alert.addActions([
AlertAction(AlertActionBuilder { $0.rootViewController = weakSelf })
.view(owner: repo.owner),
AlertAction.cancel()
])
alert.popoverPresentationController?.setSourceView(sender)
present(alert, animated: trueUnlessReduceMotionEnabled)
}
var repoUrl: URL {
return URL(string: "https://github.com/\(repo.owner)/\(repo.name)")!
}
@@ -124,7 +139,7 @@ NewIssueTableViewControllerDelegate {
AlertAction(alertBuilder).share([repoUrl], activities: [TUSafariActivity()]) {
$0.popoverPresentationController?.setSourceView(sender)
},
AlertAction(alertBuilder).view(owner: repo.owner, url: repo.ownerURL),
AlertAction(alertBuilder).view(owner: repo.owner),
AlertAction.cancel()
])
alert.popoverPresentationController?.setSourceView(sender)