From 5fe34ce6981e8c525ddf4381f4bbff77a2d80010 Mon Sep 17 00:00:00 2001 From: Ryan Nystrom Date: Tue, 26 Sep 2017 21:05:13 -0400 Subject: [PATCH] fix tabman bug when tabbar is visible --- Classes/Repository/RepositoryIssuesViewController.swift | 5 +++++ Classes/Repository/RepositoryOverviewViewController.swift | 4 ++++ Classes/Repository/RepositoryViewController.swift | 3 ++- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/Classes/Repository/RepositoryIssuesViewController.swift b/Classes/Repository/RepositoryIssuesViewController.swift index 20ef9e05..fba403cb 100644 --- a/Classes/Repository/RepositoryIssuesViewController.swift +++ b/Classes/Repository/RepositoryIssuesViewController.swift @@ -34,6 +34,7 @@ LoadMoreSectionControllerDelegate { self.repo = repo self.client = RepositoryClient(githubClient: client, owner: repo.owner, name: repo.name) self.type = type + super.init(nibName: nil, bundle: nil) switch type { @@ -51,6 +52,10 @@ LoadMoreSectionControllerDelegate { feed.viewDidLoad() feed.adapter.dataSource = self + + // set the frame in -viewDidLoad is required when working with TabMan + feed.collectionView.frame = view.bounds + if #available(iOS 11.0, *) { feed.collectionView.contentInsetAdjustmentBehavior = .never } diff --git a/Classes/Repository/RepositoryOverviewViewController.swift b/Classes/Repository/RepositoryOverviewViewController.swift index 9aa29871..cf441c07 100644 --- a/Classes/Repository/RepositoryOverviewViewController.swift +++ b/Classes/Repository/RepositoryOverviewViewController.swift @@ -40,6 +40,10 @@ ListAdapterDataSource { feed.viewDidLoad() feed.adapter.dataSource = self + + // set the frame in -viewDidLoad is required when working with TabMan + feed.collectionView.frame = view.bounds + if #available(iOS 11.0, *) { feed.collectionView.contentInsetAdjustmentBehavior = .never } diff --git a/Classes/Repository/RepositoryViewController.swift b/Classes/Repository/RepositoryViewController.swift index 245cc92f..13808a54 100644 --- a/Classes/Repository/RepositoryViewController.swift +++ b/Classes/Repository/RepositoryViewController.swift @@ -30,7 +30,8 @@ class RepositoryViewController: TabmanViewController, PageboyViewControllerDataS self.controllers = controllers super.init(nibName: nil, bundle: nil) - title = "\(repo.owner)/\(repo.name)" + + self.title = "\(repo.owner)/\(repo.name)" } required init?(coder aDecoder: NSCoder) {