kylefang/GitHawk
1
0
Fork 0
mirror of https://github.com/zhigang1992/GitHawk.git synced 2026-04-30 04:54:57 +08:00
Code Issues Packages Projects Releases Wiki Activity

Prevent tapping managing cells while animating (#1003)

Browse Source 
* Prevent tapping managing cells while animating

* always deselect
This commit is contained in:
Ryan Nystrom
2017-11-19 18:15:57 -05:00
committed by GitHub
parent 4d9b0e3800
commit 47db193a5b
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
Classes/Issues/Managing/IssueManagingSectionController.swift
View File

@@ -30,6 +30,7 @@ MilestonesViewControllerDelegate {
private let model: IssueDetailsModel
private let client: GithubClient
private var expanded = false
private var updating = false
init(id: String, model: IssueDetailsModel, client: GithubClient) {
self.id = id
@@ -135,16 +136,21 @@ MilestonesViewControllerDelegate {
didSelectItemAt index: Int,
viewModel: Any
) {
guard let viewModel = viewModel as? ListDiffable,
collectionContext?.deselectItem(at: index, sectionController: self, animated: true)
guard updating == false,
let viewModel = viewModel as? ListDiffable,
let cell = collectionContext?.cellForItem(at: index, sectionController: self)
else { return }
collectionContext?.deselectItem(at: index, sectionController: self, animated: true)
if let cell = cell as? IssueManagingExpansionCell {
expanded = !expanded
cell.animate(expanded: expanded)
update(animated: true)
updating = true
update(animated: true, completion: { [weak self] _ in
self?.updating = false
})
} else if viewModel === Action.labels {
let controller = newLabelsController()
present(controller: controller, from: cell)