Do not allow review request from PR author (#1883)

* Finishes #1850
This commit is contained in:
Benny Wong
2018-06-25 08:59:00 -04:00
committed by Ryan Nystrom
parent faca5497a8
commit 0858ae13c7
2 changed files with 25 additions and 8 deletions

View File

@@ -109,12 +109,24 @@ ContextMenuDelegate {
func newPeopleController(type: PeopleViewController.PeopleType) -> UIViewController {
let selections: [String]
let exclusions: [String]
switch type {
case .assignee: selections = issueResult?.assignee.users.map { $0.login } ?? []
case .reviewer: selections = issueResult?.reviewers?.users.map { $0.login } ?? []
case .assignee:
selections = issueResult?.assignee.users.map { $0.login } ?? []
exclusions = []
case .reviewer:
selections = issueResult?.reviewers?.users.map { $0.login } ?? []
if let isPullRequest = issueResult?.pullRequest,
let pullRequestAuthor = issueResult?.rootComment?.details.login,
isPullRequest {
exclusions = [pullRequestAuthor]
} else {
exclusions = []
}
}
return PeopleViewController(
selections: selections,
exclusions: exclusions,
type: type,
client: client,
owner: model.owner,