From 05735d2abf0974dc01d3d33f69e92de993b279e5 Mon Sep 17 00:00:00 2001 From: segayuu Date: Tue, 7 Nov 2017 12:14:42 +0900 Subject: [PATCH 1/8] Activate unnecessarily ignored rules --- types/bluebird-retry/tslint.json | 59 -------------------------------- 1 file changed, 59 deletions(-) diff --git a/types/bluebird-retry/tslint.json b/types/bluebird-retry/tslint.json index a41bf5d19a..6994644fac 100644 --- a/types/bluebird-retry/tslint.json +++ b/types/bluebird-retry/tslint.json @@ -1,79 +1,20 @@ { "extends": "dtslint/dt.json", "rules": { - "adjacent-overload-signatures": false, - "array-type": false, - "arrow-return-shorthand": false, - "ban-types": false, - "callable-types": false, "comment-format": false, "dt-header": false, "eofline": false, - "export-just-namespace": false, - "import-spacing": false, - "interface-name": false, - "interface-over-type-literal": false, - "jsdoc-format": false, - "max-line-length": false, - "member-access": false, - "new-parens": false, - "no-any-union": false, - "no-boolean-literal-compare": false, - "no-conditional-assignment": false, "no-consecutive-blank-lines": false, - "no-construct": false, - "no-declare-current-package": false, - "no-duplicate-imports": false, - "no-duplicate-variable": false, - "no-empty-interface": false, - "no-for-in-array": false, - "no-inferrable-types": false, - "no-internal-module": false, - "no-irregular-whitespace": false, - "no-mergeable-namespace": false, - "no-misused-new": false, - "no-namespace": false, - "no-object-literal-type-assertion": false, "no-padding": false, - "no-redundant-jsdoc": false, - "no-redundant-jsdoc-2": false, - "no-redundant-undefined": false, "no-reference-import": false, - "no-relative-import-in-test": false, - "no-self-import": false, - "no-single-declare-module": false, - "no-string-throw": false, - "no-unnecessary-callback-wrapper": false, - "no-unnecessary-class": false, - "no-unnecessary-generics": false, - "no-unnecessary-qualifier": false, - "no-unnecessary-type-assertion": false, - "no-useless-files": false, "no-var-keyword": false, - "no-var-requires": false, - "no-void-expression": false, - "no-trailing-whitespace": false, - "object-literal-key-quotes": false, - "object-literal-shorthand": false, - "one-line": false, - "one-variable-per-declaration": false, "only-arrow-functions": false, - "prefer-conditional-expression": false, "prefer-const": false, - "prefer-declare-function": false, - "prefer-for-of": false, - "prefer-method-signature": false, "prefer-template": false, - "radix": false, "semicolon": false, - "space-before-function-paren": false, "space-within-parens": false, "strict-export-declare-modifiers": false, - "trim-file": false, - "triple-equals": false, "typedef-whitespace": false, - "unified-signatures": false, - "void-return": false, "whitespace": false } } From f8d93098e233c6a54a33dfba4caed5611323a384 Mon Sep 17 00:00:00 2001 From: segayuu Date: Tue, 7 Nov 2017 12:21:14 +0900 Subject: [PATCH 2/8] cleanup ignore format lint errors: comment-format, eofline, no-consecutive-blank-lines, no-padding, semicolon, space-within-parens, typedef-whitespace, whitespace --- types/bluebird-retry/bluebird-retry-tests.ts | 13 ++++++------- types/bluebird-retry/index.d.ts | 1 - types/bluebird-retry/tslint.json | 10 +--------- 3 files changed, 7 insertions(+), 17 deletions(-) diff --git a/types/bluebird-retry/bluebird-retry-tests.ts b/types/bluebird-retry/bluebird-retry-tests.ts index eb3260a007..ce094918f9 100644 --- a/types/bluebird-retry/bluebird-retry-tests.ts +++ b/types/bluebird-retry/bluebird-retry-tests.ts @@ -1,9 +1,9 @@ import Promise = require('bluebird'); import retry = require('bluebird-retry'); -function promiseSuccess(text:string) { +function promiseSuccess(text: string) { return Promise.resolve(text); -}; +} var count = 0; function myfunc() { @@ -16,18 +16,17 @@ function myfunc() { } retry(myfunc) - .done(function(result) { console.log(result); } ); + .done(function(result) { console.log(result); }); - -//Options example +// Options example function logFail() { console.log(new Date().toISOString()); throw new Error('bail'); } -var options:retry.Options = { +var options: retry.Options = { max_tries: 4, interval: 500 }; -retry(logFail, options); \ No newline at end of file +retry(logFail, options); diff --git a/types/bluebird-retry/index.d.ts b/types/bluebird-retry/index.d.ts index 97d756524b..c6f66a11ee 100644 --- a/types/bluebird-retry/index.d.ts +++ b/types/bluebird-retry/index.d.ts @@ -22,7 +22,6 @@ declare namespace retry { context?: any; args?: any; } - } export = retry; diff --git a/types/bluebird-retry/tslint.json b/types/bluebird-retry/tslint.json index 6994644fac..9a40f717d9 100644 --- a/types/bluebird-retry/tslint.json +++ b/types/bluebird-retry/tslint.json @@ -1,20 +1,12 @@ { "extends": "dtslint/dt.json", "rules": { - "comment-format": false, "dt-header": false, - "eofline": false, - "no-consecutive-blank-lines": false, - "no-padding": false, "no-reference-import": false, "no-var-keyword": false, "only-arrow-functions": false, "prefer-const": false, "prefer-template": false, - "semicolon": false, - "space-within-parens": false, - "strict-export-declare-modifiers": false, - "typedef-whitespace": false, - "whitespace": false + "strict-export-declare-modifiers": false } } From 47dd70182ed6713add942549f4a5ba119b487215 Mon Sep 17 00:00:00 2001 From: segayuu Date: Tue, 7 Nov 2017 12:28:03 +0900 Subject: [PATCH 3/8] cleanup ignore lint error: dt-header --- types/bluebird-retry/index.d.ts | 2 +- types/bluebird-retry/tslint.json | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/types/bluebird-retry/index.d.ts b/types/bluebird-retry/index.d.ts index c6f66a11ee..33239e28cc 100644 --- a/types/bluebird-retry/index.d.ts +++ b/types/bluebird-retry/index.d.ts @@ -1,4 +1,4 @@ -// Type definitions for bluebird-retry +// Type definitions for bluebird-retry 0.11 // Project: https://github.com/jut-io/bluebird-retry // Definitions by: Pascal Vomhoff // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped diff --git a/types/bluebird-retry/tslint.json b/types/bluebird-retry/tslint.json index 9a40f717d9..bd08097d46 100644 --- a/types/bluebird-retry/tslint.json +++ b/types/bluebird-retry/tslint.json @@ -1,7 +1,6 @@ { "extends": "dtslint/dt.json", "rules": { - "dt-header": false, "no-reference-import": false, "no-var-keyword": false, "only-arrow-functions": false, From 92c323aadda5cecbcba096022faec1a1ef13c3a6 Mon Sep 17 00:00:00 2001 From: segayuu Date: Tue, 7 Nov 2017 12:29:53 +0900 Subject: [PATCH 4/8] cleanup ignore lint errors: no-var-keyword, prefer-const --- types/bluebird-retry/bluebird-retry-tests.ts | 4 ++-- types/bluebird-retry/tslint.json | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/types/bluebird-retry/bluebird-retry-tests.ts b/types/bluebird-retry/bluebird-retry-tests.ts index ce094918f9..69712384bd 100644 --- a/types/bluebird-retry/bluebird-retry-tests.ts +++ b/types/bluebird-retry/bluebird-retry-tests.ts @@ -5,7 +5,7 @@ function promiseSuccess(text: string) { return Promise.resolve(text); } -var count = 0; +let count = 0; function myfunc() { console.log('myfunc called ' + (++count) + ' times'); if (count < 3) { @@ -24,7 +24,7 @@ function logFail() { throw new Error('bail'); } -var options: retry.Options = { +const options: retry.Options = { max_tries: 4, interval: 500 }; diff --git a/types/bluebird-retry/tslint.json b/types/bluebird-retry/tslint.json index bd08097d46..4d6d0732aa 100644 --- a/types/bluebird-retry/tslint.json +++ b/types/bluebird-retry/tslint.json @@ -2,9 +2,7 @@ "extends": "dtslint/dt.json", "rules": { "no-reference-import": false, - "no-var-keyword": false, "only-arrow-functions": false, - "prefer-const": false, "prefer-template": false, "strict-export-declare-modifiers": false } From 5bd797fde042b525ccc625cba6570793b307df06 Mon Sep 17 00:00:00 2001 From: segayuu Date: Tue, 7 Nov 2017 12:31:23 +0900 Subject: [PATCH 5/8] cleanup ignore lint error: only-arrow-functions --- types/bluebird-retry/bluebird-retry-tests.ts | 2 +- types/bluebird-retry/tslint.json | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/types/bluebird-retry/bluebird-retry-tests.ts b/types/bluebird-retry/bluebird-retry-tests.ts index 69712384bd..597f946335 100644 --- a/types/bluebird-retry/bluebird-retry-tests.ts +++ b/types/bluebird-retry/bluebird-retry-tests.ts @@ -16,7 +16,7 @@ function myfunc() { } retry(myfunc) - .done(function(result) { console.log(result); }); + .done(result => { console.log(result); }); // Options example function logFail() { diff --git a/types/bluebird-retry/tslint.json b/types/bluebird-retry/tslint.json index 4d6d0732aa..0388bdbbed 100644 --- a/types/bluebird-retry/tslint.json +++ b/types/bluebird-retry/tslint.json @@ -2,7 +2,6 @@ "extends": "dtslint/dt.json", "rules": { "no-reference-import": false, - "only-arrow-functions": false, "prefer-template": false, "strict-export-declare-modifiers": false } From 4aa84e56674c98f034297ca17543e5970b7599a8 Mon Sep 17 00:00:00 2001 From: segayuu Date: Tue, 7 Nov 2017 12:32:31 +0900 Subject: [PATCH 6/8] cleanup ignore lint error: no-reference-import --- types/bluebird-retry/index.d.ts | 2 -- types/bluebird-retry/tslint.json | 1 - 2 files changed, 3 deletions(-) diff --git a/types/bluebird-retry/index.d.ts b/types/bluebird-retry/index.d.ts index 33239e28cc..0e39ef3b89 100644 --- a/types/bluebird-retry/index.d.ts +++ b/types/bluebird-retry/index.d.ts @@ -4,8 +4,6 @@ // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.3 -/// - import Promise = require('bluebird'); declare function retry(func: (param: T) => void, options?: retry.Options): Promise; diff --git a/types/bluebird-retry/tslint.json b/types/bluebird-retry/tslint.json index 0388bdbbed..84c5ab57a3 100644 --- a/types/bluebird-retry/tslint.json +++ b/types/bluebird-retry/tslint.json @@ -1,7 +1,6 @@ { "extends": "dtslint/dt.json", "rules": { - "no-reference-import": false, "prefer-template": false, "strict-export-declare-modifiers": false } From 8441c251e8df0337e897b32c4cefb11613454adc Mon Sep 17 00:00:00 2001 From: segayuu Date: Tue, 7 Nov 2017 12:34:10 +0900 Subject: [PATCH 7/8] cleanup ignore lint error: prefer-template --- types/bluebird-retry/bluebird-retry-tests.ts | 2 +- types/bluebird-retry/tslint.json | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/types/bluebird-retry/bluebird-retry-tests.ts b/types/bluebird-retry/bluebird-retry-tests.ts index 597f946335..e9beaf5562 100644 --- a/types/bluebird-retry/bluebird-retry-tests.ts +++ b/types/bluebird-retry/bluebird-retry-tests.ts @@ -7,7 +7,7 @@ function promiseSuccess(text: string) { let count = 0; function myfunc() { - console.log('myfunc called ' + (++count) + ' times'); + console.log(`myfunc called ${++count} times`); if (count < 3) { throw new Error('i fail the first two times'); } else { diff --git a/types/bluebird-retry/tslint.json b/types/bluebird-retry/tslint.json index 84c5ab57a3..4c4fc86ace 100644 --- a/types/bluebird-retry/tslint.json +++ b/types/bluebird-retry/tslint.json @@ -1,7 +1,6 @@ { "extends": "dtslint/dt.json", "rules": { - "prefer-template": false, "strict-export-declare-modifiers": false } } From 68a6a6273d4207dc9743b929c3261505ccbc0f5c Mon Sep 17 00:00:00 2001 From: segayuu Date: Tue, 7 Nov 2017 12:38:03 +0900 Subject: [PATCH 8/8] cleanup lint error: strict-export-declare-modifiers --- types/bluebird-retry/index.d.ts | 2 +- types/bluebird-retry/tslint.json | 7 +------ 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/types/bluebird-retry/index.d.ts b/types/bluebird-retry/index.d.ts index 0e39ef3b89..358c75936d 100644 --- a/types/bluebird-retry/index.d.ts +++ b/types/bluebird-retry/index.d.ts @@ -9,7 +9,7 @@ import Promise = require('bluebird'); declare function retry(func: (param: T) => void, options?: retry.Options): Promise; declare namespace retry { - export interface Options { + interface Options { interval?: number; backoff?: number; max_interval?: number; diff --git a/types/bluebird-retry/tslint.json b/types/bluebird-retry/tslint.json index 4c4fc86ace..3db14f85ea 100644 --- a/types/bluebird-retry/tslint.json +++ b/types/bluebird-retry/tslint.json @@ -1,6 +1 @@ -{ - "extends": "dtslint/dt.json", - "rules": { - "strict-export-declare-modifiers": false - } -} +{ "extends": "dtslint/dt.json" }