From 023117be187ae595c015dc6be82f580dd5d9754e Mon Sep 17 00:00:00 2001 From: Jay Anslow Date: Tue, 7 Mar 2017 10:49:59 +0000 Subject: [PATCH 1/2] deep-equal accepts all types as arguments. Previously only accepted defined objects. Also enable strictNullChecks. --- deep-equal/deep-equal-tests.ts | 7 +++++-- deep-equal/index.d.ts | 6 +++--- deep-equal/tsconfig.json | 2 +- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/deep-equal/deep-equal-tests.ts b/deep-equal/deep-equal-tests.ts index 2f4f238a4f..327067b29d 100644 --- a/deep-equal/deep-equal-tests.ts +++ b/deep-equal/deep-equal-tests.ts @@ -1,8 +1,11 @@ -import * as deepEqual from "deep-equal"; +import deepEqual = require("deep-equal"); let isDeepEqual1: boolean = deepEqual({}, {}); let isDeepEqual2: boolean = deepEqual({}, {}, { strict: true }); let isDeepEqual3: boolean = deepEqual({}, {}, { strict: false }); +let isDeepEqual4: boolean = deepEqual(undefined, undefined); +let isDeepEqual5: boolean = deepEqual(3, false); +let isDeepEqual6: boolean = deepEqual("a-string", null); -console.log(isDeepEqual1, isDeepEqual2, isDeepEqual3); +console.log(isDeepEqual1, isDeepEqual2, isDeepEqual3, isDeepEqual4, isDeepEqual5, isDeepEqual6); diff --git a/deep-equal/index.d.ts b/deep-equal/index.d.ts index eef762a4ea..20a0f30275 100644 --- a/deep-equal/index.d.ts +++ b/deep-equal/index.d.ts @@ -1,6 +1,6 @@ // Type definitions for deep-equal // Project: https://github.com/substack/node-deep-equal -// Definitions by: remojansen +// Definitions by: remojansen , Jay Anslow // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped @@ -10,8 +10,8 @@ interface DeepEqualOptions { } declare let deepEqual: ( - actual: Object, - expected: Object, + actual: any, + expected: any, opts?: DeepEqualOptions) => boolean; export = deepEqual; diff --git a/deep-equal/tsconfig.json b/deep-equal/tsconfig.json index b192443e3f..6d21a4a7e6 100644 --- a/deep-equal/tsconfig.json +++ b/deep-equal/tsconfig.json @@ -7,7 +7,7 @@ ], "noImplicitAny": true, "noImplicitThis": true, - "strictNullChecks": false, + "strictNullChecks": true, "baseUrl": "../", "typeRoots": [ "../" From f102b10f38a9dc9fd96fd56a982a5ceb87fbbaf7 Mon Sep 17 00:00:00 2001 From: Jay Anslow Date: Tue, 7 Mar 2017 11:11:45 +0000 Subject: [PATCH 2/2] Enable linting and fix errors --- deep-equal/deep-equal-tests.ts | 12 ++++++------ deep-equal/index.d.ts | 8 +++----- deep-equal/tslint.json | 3 +++ 3 files changed, 12 insertions(+), 11 deletions(-) create mode 100644 deep-equal/tslint.json diff --git a/deep-equal/deep-equal-tests.ts b/deep-equal/deep-equal-tests.ts index 327067b29d..ed23a35838 100644 --- a/deep-equal/deep-equal-tests.ts +++ b/deep-equal/deep-equal-tests.ts @@ -1,11 +1,11 @@ import deepEqual = require("deep-equal"); -let isDeepEqual1: boolean = deepEqual({}, {}); -let isDeepEqual2: boolean = deepEqual({}, {}, { strict: true }); -let isDeepEqual3: boolean = deepEqual({}, {}, { strict: false }); -let isDeepEqual4: boolean = deepEqual(undefined, undefined); -let isDeepEqual5: boolean = deepEqual(3, false); -let isDeepEqual6: boolean = deepEqual("a-string", null); +const isDeepEqual1: boolean = deepEqual({}, {}); +const isDeepEqual2: boolean = deepEqual({}, {}, { strict: true }); +const isDeepEqual3: boolean = deepEqual({}, {}, { strict: false }); +const isDeepEqual4: boolean = deepEqual(undefined, undefined); +const isDeepEqual5: boolean = deepEqual(3, false); +const isDeepEqual6: boolean = deepEqual("a-string", null); console.log(isDeepEqual1, isDeepEqual2, isDeepEqual3, isDeepEqual4, isDeepEqual5, isDeepEqual6); diff --git a/deep-equal/index.d.ts b/deep-equal/index.d.ts index 20a0f30275..d9c4b5f6cf 100644 --- a/deep-equal/index.d.ts +++ b/deep-equal/index.d.ts @@ -1,17 +1,15 @@ -// Type definitions for deep-equal +// Type definitions for deep-equal 1.0 // Project: https://github.com/substack/node-deep-equal // Definitions by: remojansen , Jay Anslow // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped - - interface DeepEqualOptions { strict: boolean; } -declare let deepEqual: ( +declare function deepEqual( actual: any, expected: any, - opts?: DeepEqualOptions) => boolean; + opts?: DeepEqualOptions): boolean; export = deepEqual; diff --git a/deep-equal/tslint.json b/deep-equal/tslint.json new file mode 100644 index 0000000000..f9e30021f4 --- /dev/null +++ b/deep-equal/tslint.json @@ -0,0 +1,3 @@ +{ + "extends": "../tslint.json" +}