From 6f503d7925b691c89bbd1907fae2f4c82b8b2f2b Mon Sep 17 00:00:00 2001 From: bradacina Date: Sun, 3 Jan 2016 12:06:08 +1100 Subject: [PATCH] Fix showSaveDialog method signature showSaveDialog() filters have the same format as showOpenDialog() filters. It also returns a string containing the file name As per: https://github.com/atom/electron/blob/master/docs/api/dialog.md --- github-electron/github-electron.d.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/github-electron/github-electron.d.ts b/github-electron/github-electron.d.ts index 37dd602228..d0f092c3be 100644 --- a/github-electron/github-electron.d.ts +++ b/github-electron/github-electron.d.ts @@ -1193,8 +1193,12 @@ declare module GitHubElectron { /** * File types that can be displayed, see dialog.showOpenDialog for an example. */ - filters?: string[]; - }, callback?: (fileName: string) => void): void; + + filters?: { + name: string; + extensions: string[]; + }[] + }, callback?: (fileName: string) => void): string; /** * Shows a message box. It will block until the message box is closed. It returns .