From b7612018f25f01cc9ea097ca243db0d629a7a99a Mon Sep 17 00:00:00 2001 From: Samuel DeSota Date: Thu, 18 May 2017 14:44:55 -0400 Subject: [PATCH 1/2] added typings for mapPropsStreamWithConfig and componentFromStreamWithConfig --- types/recompose/index.d.ts | 10 ++++++++++ types/recompose/recompose-tests.tsx | 1 - 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/types/recompose/index.d.ts b/types/recompose/index.d.ts index 6cef47160e..4b37d35fda 100644 --- a/types/recompose/index.d.ts +++ b/types/recompose/index.d.ts @@ -255,11 +255,21 @@ declare module 'recompose' { propsToReactNode: mapper, Subscribable> ): Component; // ??? + // componentFromStreamWithConfig: https://github.com/acdlite/recompose/blob/master/docs/API.md#componentfromstreamwithconfig + export function componentFromStreamWithConfig(config: ObservableConfig): ( + propsToReactNode: mapper, Subscribable> + ) => Component + // mapPropsStream: https://github.com/acdlite/recompose/blob/master/docs/API.md#mapPropsStream export function mapPropsStream( transform: mapper, Subscribable> ): ComponentEnhancer; + // mapPropsStreamWithConfig: https://github.com/acdlite/recompose/blob/master/docs/API.md#mappropsstreamwithconfig + export function mapPropsStreamWithConfig(config: ObservableConfig): ( + transform: mapper, Subscribable> + ) => ComponentEnhancer; + // createEventHandler: https://github.com/acdlite/recompose/blob/master/docs/API.md#createEventHandler type EventHandlerOf> = { handler: (value: T) => void; diff --git a/types/recompose/recompose-tests.tsx b/types/recompose/recompose-tests.tsx index 01bd1d28f5..ce8c55044f 100644 --- a/types/recompose/recompose-tests.tsx +++ b/types/recompose/recompose-tests.tsx @@ -178,4 +178,3 @@ function testRenderComponent() { const enhancer = renderComponent(() => Nop!); const enhanced: React.ComponentClass = enhancer(innerComponent); } - From 9eea1e8a919aff0c71b9ccf34eb782206a6c7727 Mon Sep 17 00:00:00 2001 From: Samuel DeSota Date: Thu, 18 May 2017 14:53:04 -0400 Subject: [PATCH 2/2] added to defs by, changed generic position, and added defs by --- types/recompose/index.d.ts | 7 ++++--- types/recompose/recompose-tests.tsx | 9 +++++++++ 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/types/recompose/index.d.ts b/types/recompose/index.d.ts index 4b37d35fda..0951a04a9f 100644 --- a/types/recompose/index.d.ts +++ b/types/recompose/index.d.ts @@ -1,6 +1,7 @@ -// Type definitions for Recompose v0.22.0 +// Type definitions for Recompose v0.23.4 // Project: https://github.com/acdlite/recompose // Definitions by: Iskander Sierra +// Samuel DeSota // Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped // TypeScript Version: 2.1 @@ -256,7 +257,7 @@ declare module 'recompose' { ): Component; // ??? // componentFromStreamWithConfig: https://github.com/acdlite/recompose/blob/master/docs/API.md#componentfromstreamwithconfig - export function componentFromStreamWithConfig(config: ObservableConfig): ( + export function componentFromStreamWithConfig(config: ObservableConfig): ( propsToReactNode: mapper, Subscribable> ) => Component @@ -266,7 +267,7 @@ declare module 'recompose' { ): ComponentEnhancer; // mapPropsStreamWithConfig: https://github.com/acdlite/recompose/blob/master/docs/API.md#mappropsstreamwithconfig - export function mapPropsStreamWithConfig(config: ObservableConfig): ( + export function mapPropsStreamWithConfig(config: ObservableConfig): ( transform: mapper, Subscribable> ) => ComponentEnhancer; diff --git a/types/recompose/recompose-tests.tsx b/types/recompose/recompose-tests.tsx index ce8c55044f..1d645f412d 100644 --- a/types/recompose/recompose-tests.tsx +++ b/types/recompose/recompose-tests.tsx @@ -16,6 +16,7 @@ import { createSink, componentFromProp, nest, hoistStatics, // Observable utilities componentFromStream, mapPropsStream, createEventHandler, + componentFromStreamWithConfig, mapPropsStreamWithConfig, setObservableConfig, } from "recompose"; import rxjsconfig from "recompose/rxjsObservableConfig"; @@ -178,3 +179,11 @@ function testRenderComponent() { const enhancer = renderComponent(() => Nop!); const enhanced: React.ComponentClass = enhancer(innerComponent); } + +function testWithObservableConfig() { + let componentFromStreamMost = componentFromStreamWithConfig(mostConfig) + componentFromStreamMost = componentFromStream + + let mapPropsStreamMost = mapPropsStreamWithConfig(mostConfig) + mapPropsStreamMost = mapPropsStream +}