kylefang/DefinitelyTyped
1
0
Fork 0
mirror of https://github.com/zhigang1992/DefinitelyTyped.git synced 2026-04-01 12:42:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

github-electron: Fix callback's return type of app.makeSingleInstance() (#9250)

Browse Source 
The callback should return `void`, not `boolean`.

https://github.com/electron/electron/blob/master/docs/api/app.md#appmakesingleinstancecallback
This commit is contained in:
Linda_pp
2016-05-09 17:37:39 +09:00
committed by Horiuchi_H
parent 00cb576708
commit d9e73fad7d
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
github-electron/github-electron-main-tests.ts
View File

@@ -45,7 +45,6 @@ var shouldQuit = app.makeSingleInstance(function(commandLine, workingDirectory)
if (mainWindow.isMinimized()) mainWindow.restore();
mainWindow.focus();
}
return true;
});
if (shouldQuit) {

2
github-electron/github-electron.d.ts vendored
View File

@@ -280,7 +280,7 @@ declare namespace Electron {
* multiple instances of your app to run, this will ensure that only a single instance
* of your app is running, and other instances signal this instance and exit.
*/
makeSingleInstance(callback: (args: string[], workingDirectory: string) => boolean): boolean;
makeSingleInstance(callback: (args: string[], workingDirectory: string) => void): boolean;
/**
* Changes the Application User Model ID to id.
*/