From f73e4844a0583d45ce04687a9b3b7a6ec2c18e5f Mon Sep 17 00:00:00 2001 From: Valentin Robert Date: Mon, 25 Jul 2016 10:35:38 -0700 Subject: [PATCH 1/2] Lodash: find* methods may return undefined --- lodash/lodash-3.10.d.ts | 62 ++++++++++++++++++++--------------------- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/lodash/lodash-3.10.d.ts b/lodash/lodash-3.10.d.ts index b92de15c89..2c9ee995cf 100644 --- a/lodash/lodash-3.10.d.ts +++ b/lodash/lodash-3.10.d.ts @@ -5938,7 +5938,7 @@ declare module _ { collection: List, predicate?: ListIterator, thisArg?: any - ): T; + ): T | undefined; /** * @see _.find @@ -5947,7 +5947,7 @@ declare module _ { collection: Dictionary, predicate?: DictionaryIterator, thisArg?: any - ): T; + ): T | undefined; /** * @see _.find @@ -5956,7 +5956,7 @@ declare module _ { collection: List|Dictionary, predicate?: string, thisArg?: any - ): T; + ): T | undefined; /** * @see _.find @@ -5964,7 +5964,7 @@ declare module _ { find( collection: List|Dictionary, predicate?: TObject - ): T; + ): T | undefined; } interface LoDashImplicitArrayWrapper { @@ -5974,7 +5974,7 @@ declare module _ { find( predicate?: ListIterator, thisArg?: any - ): T; + ): T | undefined; /** * @see _.find @@ -5982,14 +5982,14 @@ declare module _ { find( predicate?: string, thisArg?: any - ): T; + ): T | undefined; /** * @see _.find */ find( predicate?: TObject - ): T; + ): T | undefined; } interface LoDashImplicitObjectWrapper { @@ -5999,7 +5999,7 @@ declare module _ { find( predicate?: ListIterator|DictionaryIterator, thisArg?: any - ): TResult; + ): TResult | undefined; /** * @see _.find @@ -6007,14 +6007,14 @@ declare module _ { find( predicate?: string, thisArg?: any - ): TResult; + ): TResult | undefined; /** * @see _.find */ find( predicate?: TObject - ): TResult; + ): TResult | undefined; } //_.findWhere @@ -6025,7 +6025,7 @@ declare module _ { findWhere( collection: Array, callback: ListIterator, - thisArg?: any): T; + thisArg?: any): T | undefined; /** * @see _.find @@ -6033,7 +6033,7 @@ declare module _ { findWhere( collection: List, callback: ListIterator, - thisArg?: any): T; + thisArg?: any): T | undefined; /** * @see _.find @@ -6041,7 +6041,7 @@ declare module _ { findWhere( collection: Dictionary, callback: DictionaryIterator, - thisArg?: any): T; + thisArg?: any): T | undefined; /** * @see _.find @@ -6049,7 +6049,7 @@ declare module _ { **/ findWhere( collection: Array, - whereValue: W): T; + whereValue: W): T | undefined; /** * @see _.find @@ -6057,7 +6057,7 @@ declare module _ { **/ findWhere( collection: List, - whereValue: W): T; + whereValue: W): T | undefined; /** * @see _.find @@ -6065,7 +6065,7 @@ declare module _ { **/ findWhere( collection: Dictionary, - whereValue: W): T; + whereValue: W): T | undefined; /** * @see _.find @@ -6073,7 +6073,7 @@ declare module _ { **/ findWhere( collection: Array, - pluckValue: string): T; + pluckValue: string): T | undefined; /** * @see _.find @@ -6081,7 +6081,7 @@ declare module _ { **/ findWhere( collection: List, - pluckValue: string): T; + pluckValue: string): T | undefined; /** * @see _.find @@ -6089,7 +6089,7 @@ declare module _ { **/ findWhere( collection: Dictionary, - pluckValue: string): T; + pluckValue: string): T | undefined; } //_.findLast @@ -6105,7 +6105,7 @@ declare module _ { findLast( collection: Array, callback: ListIterator, - thisArg?: any): T; + thisArg?: any): T | undefined; /** * @see _.find @@ -6113,7 +6113,7 @@ declare module _ { findLast( collection: List, callback: ListIterator, - thisArg?: any): T; + thisArg?: any): T | undefined; /** * @see _.find @@ -6121,7 +6121,7 @@ declare module _ { findLast( collection: Dictionary, callback: DictionaryIterator, - thisArg?: any): T; + thisArg?: any): T | undefined; /** * @see _.find @@ -6129,7 +6129,7 @@ declare module _ { **/ findLast( collection: Array, - whereValue: W): T; + whereValue: W): T | undefined; /** * @see _.find @@ -6137,7 +6137,7 @@ declare module _ { **/ findLast( collection: List, - whereValue: W): T; + whereValue: W): T | undefined; /** * @see _.find @@ -6145,7 +6145,7 @@ declare module _ { **/ findLast( collection: Dictionary, - whereValue: W): T; + whereValue: W): T | undefined; /** * @see _.find @@ -6153,7 +6153,7 @@ declare module _ { **/ findLast( collection: Array, - pluckValue: string): T; + pluckValue: string): T | undefined; /** * @see _.find @@ -6161,7 +6161,7 @@ declare module _ { **/ findLast( collection: List, - pluckValue: string): T; + pluckValue: string): T | undefined; /** * @see _.find @@ -6169,7 +6169,7 @@ declare module _ { **/ findLast( collection: Dictionary, - pluckValue: string): T; + pluckValue: string): T | undefined; } interface LoDashImplicitArrayWrapper { @@ -6178,20 +6178,20 @@ declare module _ { */ findLast( callback: ListIterator, - thisArg?: any): T; + thisArg?: any): T | undefined; /** * @see _.findLast * @param _.where style callback */ findLast( - whereValue: W): T; + whereValue: W): T | undefined; /** * @see _.findLast * @param _.where style callback */ findLast( - pluckValue: string): T; + pluckValue: string): T | undefined; } //_.forEach From a3ce89b0d380171be360e0154d4bb3654a04a119 Mon Sep 17 00:00:00 2001 From: Daniel Rosenwasser Date: Tue, 26 Jul 2016 12:35:37 -0700 Subject: [PATCH 2/2] Remove string index signature. --- react/index.d.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/react/index.d.ts b/react/index.d.ts index d7974d56ca..d9e601095a 100644 --- a/react/index.d.ts +++ b/react/index.d.ts @@ -2037,9 +2037,6 @@ declare namespace React { results?: number; security?: string; unselectable?: boolean; - - // Allows aria- and data- Attributes - [key: string]: any; } interface SVGAttributes extends HTMLAttributes {