From a868d3c448da2d5c4890b7a150ef238cef33bf0c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Aur=C3=A9lien=20Herv=C3=A9?= Date: Thu, 24 May 2018 11:18:55 +0200 Subject: [PATCH] fix(algoliasearch): remove duplicate and buggy AlgoliaResponse interface the typings would still provide the old `AlgoliaResponse` interface, which is a _almost_ duplicate interface of `Response`, although it is not called anywhere else. Moreover, `AlgoliaResponse` was buggy (namely, the `nbPages` attribute was declared as `nbPage`. It is more safe to have only one interface that works, so I deleted the old `AlgoliaResponse` interface. --- types/algoliasearch/index.d.ts | 46 ---------------------------------- 1 file changed, 46 deletions(-) diff --git a/types/algoliasearch/index.d.ts b/types/algoliasearch/index.d.ts index 9315a7f6b9..b2890573ce 100644 --- a/types/algoliasearch/index.d.ts +++ b/types/algoliasearch/index.d.ts @@ -1406,52 +1406,6 @@ declare namespace algoliasearch { userData?: string | object; } - interface AlgoliaResponse { - /** - * Contains all the hits matching the query - * https://github.com/algolia/algoliasearch-client-js#response-format - */ - hits: any[]; - /** - * Current page - * https://github.com/algolia/algoliasearch-client-js#response-format - */ - page: number; - /** - * Number of total hits matching the query - * https://github.com/algolia/algoliasearch-client-js#response-format - */ - nbHits: number; - /** - * Number of pages - * https://github.com/algolia/algoliasearch-client-js#response-format - */ - nbPage: number; - /** - * Number of hits per pages - * https://github.com/algolia/algoliasearch-client-js#response-format - */ - hitsPerPage: number; - /** - * Engine processing time (excluding network transfer) - * https://github.com/algolia/algoliasearch-client-js#response-format - */ - processingTimeMS: number; - /** - * Query used to perform the search - * https://github.com/algolia/algoliasearch-client-js#response-format - */ - query: string; - /** - * GET parameters used to perform the search - * https://github.com/algolia/algoliasearch-client-js#response-format - */ - params: string; - facets: { - [facetName: string]: { [facetValue: string]: number }; - }; - } - namespace SearchForFacetValues { interface Parameters extends QueryParameters { /**